picture: add assertion against double free

36a00fd7 · Rémi Denis-Courmont · 70055757 · 36a00fd7
Commit 36a00fd7 authored Jul 04, 2013 by Rémi Denis-Courmont
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 2 deletions

src/misc/picture.c src/misc/picture.c +6 -2

No files found.
--- a/src/misc/picture.c
+++ b/src/misc/picture.c
@@ -266,8 +266,12 @@ picture_t *picture_Hold( picture_t *p_picture )

 void picture_Release( picture_t *p_picture )
 {
-    if( vlc_atomic_dec( &p_picture->gc.refcount ) == 0 &&
-        p_picture->gc.pf_destroy )
+    uintptr_t refs = vlc_atomic_dec( &p_picture->gc.refcount );
+    assert( refs != (uintptr_t)-1 );
+    if( refs > 0 )
+        return;
+
+    if( p_picture->gc.pf_destroy != NULL )
        p_picture->gc.pf_destroy( p_picture );
 }