• Felix Abecassis's avatar
    input: waiting and flushing states should be mutually exclusive · a801b6b7
    Felix Abecassis authored
    A crash could occur in the following situation:
    1) A video decoder is created and starts waiting for the first picture:
       b_waiting = true, b_first = true
    
    2) The first picture is received but the decoder is still in waiting mode:
       b_waiting = true, b_first = false
    
    3) A second picture is received, the decoder is now waiting in
    DecoderWaitUnblock().
    
    4) From the input thread, an EOF event is received, EsOutChangePosition is
    called and sets the decoder in flushing mode.
    
    5) The decoder thread wakes up and exits DecoderWaitUnblock because
    b_flushing is true. However this triggers the assertion in
    DecoderDecodeVideo since we have b_waiting && !b_first.
    
    Fix #11892, #12041
    
    (cherry picked from commit a1603d9e69629a8168f5babce3388307bb677341)
    Signed-off-by: default avatarJean-Baptiste Kempf <jb@videolan.org>
    a801b6b7
decoder.c 66.1 KB