The p_dest object is indeed locked by the calling method (cf mediacontrol_snapshot in src/control/mediacontrol_audio_video.c).

This reverts commit ebbde26e.

It was always set equal to the input's i_bitspersample, which caused
crashes in some transcoding sessions.

Unfortunately taglib does not accept fd's or FILE*, so i ported the code from src/text/unicode.c open() to here.

macosx: Remove VLCApplication Hack. No need for that we properly do everything related to libvlc kill elsewhere.

This file is way too big (!).

Nowadays, it can only deadlock (threads>0) or do nothing (threads==0)

This reverts commit d4485423.

Should fix a crash reported by the bugreport ml.

audioscrobbler: *Never* do module unloading from within the module. You are basically unloading the code you are executing, that's a nice crasher.

Also make sure playlist is not NULL. (This is an attempt to fix a from the famous bugreport ml).

The audio output locking rule seems very vague. Moreover there could be some cross lock issues.

Spotted in our bugreport ml.