Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
V
vlc-1.1
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Redmine
Redmine
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Operations
Operations
Metrics
Environments
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
videolan
vlc-1.1
Commits
a005a22e
Commit
a005a22e
authored
Dec 04, 2005
by
Clément Stenac
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Clean up - convert todos to doxygen style
parent
af10ead7
Changes
5
Hide whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
7 additions
and
14 deletions
+7
-14
modules/gui/skins2/commands/cmd_playtree.cpp
modules/gui/skins2/commands/cmd_playtree.cpp
+1
-1
modules/gui/skins2/controls/ctrl_tree.cpp
modules/gui/skins2/controls/ctrl_tree.cpp
+2
-7
modules/gui/skins2/utils/var_tree.cpp
modules/gui/skins2/utils/var_tree.cpp
+1
-1
modules/gui/skins2/utils/var_tree.hpp
modules/gui/skins2/utils/var_tree.hpp
+1
-1
modules/gui/skins2/vars/playtree.cpp
modules/gui/skins2/vars/playtree.cpp
+2
-4
No files found.
modules/gui/skins2/commands/cmd_playtree.cpp
View file @
a005a22e
...
...
@@ -32,7 +32,7 @@ void CmdPlaytreeDel::execute()
void
CmdPlaytreeSort
::
execute
()
{
//
TODO: Choose sort method
//
/ \todo Choose sort method/order - Need more commands
playlist_t
*
p_playlist
=
getIntf
()
->
p_sys
->
p_playlist
;
vlc_mutex_lock
(
&
p_playlist
->
object_lock
);
playlist_view_t
*
p_view
=
playlist_ViewFind
(
p_playlist
,
p_playlist
->
status
.
i_view
);
...
...
modules/gui/skins2/controls/ctrl_tree.cpp
View file @
a005a22e
...
...
@@ -145,9 +145,7 @@ void CtrlTree::onUpdate( Subject<VarTree, tree_update*> &rTree,
}
else
if
(
arg
->
i_type
==
2
)
// Item-append
{
/* TODO: Check if the item should be visible. If it is, makeImage
* Else, do nothing
*/
/// \todo Check if the really is really visible in the view (we only check if it in the document)
if
(
arg
->
b_visible
==
true
)
{
makeImage
();
...
...
@@ -184,7 +182,6 @@ void CtrlTree::onUpdate( Subject<VarPercent, void*> &rPercent, void* arg)
void
CtrlTree
::
onResize
()
{
// FIXME : shouldn't be the same as the onUpdate function ... but i'm lazy
// Determine what is the first item to display
VarTree
::
Iterator
it
=
m_rTree
.
begin
();
...
...
@@ -665,9 +662,7 @@ void CtrlTree::makeImage()
}
it
=
m_rTree
.
getNextVisibleItem
(
it
);
}
/* TODO: Reposition percentage var to accomodate if it's not suitable anymore
* (if we expanded a node)
*/
/// \todo Reposition percentage var to accomodate if it's not suitable anymore (if we expanded a node)
}
VarTree
::
Iterator
CtrlTree
::
findItemAtPos
(
int
pos
)
...
...
modules/gui/skins2/utils/var_tree.cpp
View file @
a005a22e
...
...
@@ -49,7 +49,7 @@ VarTree::VarTree( intf_thread_t *pIntf, VarTree *pParent, int id,
VarTree
::~
VarTree
()
{
//
TODO :
check that children are deleted
//
/ \todo
check that children are deleted
}
void
VarTree
::
add
(
int
id
,
const
UStringPtr
&
rcString
,
bool
selected
,
...
...
modules/gui/skins2/utils/var_tree.hpp
View file @
a005a22e
...
...
@@ -65,7 +65,7 @@ class VarTree: public Variable, public Subject<VarTree, tree_update*>
/// Remove all elements from the children's list
virtual
void
clear
();
///
FIXME should be private
///
\todo Use accessors for these fields ?
int
m_id
;
UStringPtr
m_cString
;
bool
m_selected
;
...
...
modules/gui/skins2/vars/playtree.cpp
View file @
a005a22e
...
...
@@ -54,7 +54,6 @@ Playtree::Playtree( intf_thread_t *pIntf ): VarTree( pIntf )
Playtree
::~
Playtree
()
{
if
(
iconvHandle
!=
(
vlc_iconv_t
)
-
1
)
vlc_iconv_close
(
iconvHandle
);
// TODO : check that everything is destroyed
}
void
Playtree
::
delSelected
()
...
...
@@ -79,7 +78,7 @@ void Playtree::delSelected()
}
}
}
//
TODO: Do this better
//
/ \todo Do this better (handle item-deleted)
buildTree
();
tree_update
descr
;
descr
.
i_type
=
1
;
...
...
@@ -188,10 +187,9 @@ void Playtree::buildTree()
playlist_view_t
*
p_view
;
p_view
=
playlist_ViewFind
(
m_pPlaylist
,
VIEW_CATEGORY
);
/
* TODO : let the user chose the view type */
/
// \todo let the user chose the view
clear
();
/* XXX : do we need Playlist::clear() instead of VarTree::clear() ? */
/* Set the root's name */
UString
*
pName
=
new
UString
(
getIntf
(),
p_view
->
p_root
->
input
.
psz_name
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment