Skip to content

V
vlc-1.1
Commit 89f05854 authored by Rémi Denis-Courmont's avatar Rémi Denis-Courmont
Browse files
Options

Fix impossible out-of-bound strcmp

parent f953de14
Hide whitespace changes
Inline Side-by-side
Showing with 6 additions and 4 deletions
modules/access/udp.c
View file @ 89f05854
...@@ -136,7 +136,8 @@ static int Open( vlc_object_t *p_this ) ...@@ -136,7 +136,8 @@ static int Open( vlc_object_t *p_this )
int i_bind_port, i_server_port = 0; int i_bind_port, i_server_port = 0;
int fam = AF_UNSPEC, proto = IPPROTO_UDP, cscov = 8; int fam = AF_UNSPEC, proto = IPPROTO_UDP, cscov = 8;
if (strlen (p_access->psz_access) >= 4) if (strlen (p_access->psz_access) >= 3)
{
switch (p_access->psz_access[3]) switch (p_access->psz_access[3])
{ {
case '4': case '4':
...@@ -147,9 +148,10 @@ static int Open( vlc_object_t *p_this ) ...@@ -147,9 +148,10 @@ static int Open( vlc_object_t *p_this )
fam = AF_INET6; fam = AF_INET6;
break; break;
} }
if (strcmp (p_access->psz_access + 3, "lite") == 0) if (strcmp (p_access->psz_access + 3, "lite") == 0)
proto = IPPROTO_UDPLITE; proto = IPPROTO_UDPLITE;
if (strncmp (p_access->psz_access, "rtp", 3) == 0) }
if (strncmp (p_access->psz_access, "rtp", 3) == 0)
/* Checksum coverage: RTP header is AT LEAST 12 bytes /* Checksum coverage: RTP header is AT LEAST 12 bytes
* in addition to UDP header (8 bytes) */ * in addition to UDP header (8 bytes) */
cscov += 12; cscov += 12;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment