Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
V
vlc-1.1
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Redmine
Redmine
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Operations
Operations
Metrics
Environments
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
videolan
vlc-1.1
Commits
442bc8bb
Commit
442bc8bb
authored
Feb 15, 2007
by
Rémi Denis-Courmont
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
- Fix file descriptors leak
- Use net_Read() instead of net_ReadNonBlock()
parent
771953bd
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
12 additions
and
4 deletions
+12
-4
modules/control/rc.c
modules/control/rc.c
+12
-4
No files found.
modules/control/rc.c
View file @
442bc8bb
...
...
@@ -2020,9 +2020,9 @@ vlc_bool_t ReadCommand( intf_thread_t *p_intf, char *p_buffer, int *pi_size )
#endif
while
(
!
intf_ShouldDie
(
p_intf
)
&&
*
pi_size
<
MAX_LINE_LENGTH
&&
(
i_read
=
net_Read
NonBlock
(
p_intf
,
p_intf
->
p_sys
->
i_socket
==
-
1
?
(
i_read
=
net_Read
(
p_intf
,
p_intf
->
p_sys
->
i_socket
==
-
1
?
0
/*STDIN_FILENO*/
:
p_intf
->
p_sys
->
i_socket
,
NULL
,
(
uint8_t
*
)
p_buffer
+
*
pi_size
,
1
,
INTF_IDLE_SLEEP
)
)
>
0
)
(
uint8_t
*
)
p_buffer
+
*
pi_size
,
1
,
VLC_FALSE
)
)
>
0
)
{
if
(
p_buffer
[
*
pi_size
]
==
'\r'
||
p_buffer
[
*
pi_size
]
==
'\n'
)
break
;
...
...
@@ -2031,9 +2031,17 @@ vlc_bool_t ReadCommand( intf_thread_t *p_intf, char *p_buffer, int *pi_size )
}
/* Connection closed */
if
(
i_read
==
-
1
)
if
(
i_read
<=
0
)
{
p_intf
->
p_sys
->
i_socket
=
-
1
;
if
(
p_intf
->
p_sys
->
i_socket
!=
-
1
)
{
net_Close
(
p_intf
->
p_sys
->
i_socket
);
p_intf
->
p_sys
->
i_socket
=
-
1
;
}
else
/* Standard input closed: exit */
p_intf
->
b_die
=
VLC_TRUE
;
p_buffer
[
*
pi_size
]
=
0
;
return
VLC_TRUE
;
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment