Signed-off-by: Jean-Paul Saman <jpsaman@videolan.org>

Signed-off-by: Jean-Paul Saman <jpsaman@videolan.org>

The splice_insert command decoder is implemented in function dvbpsi_sis_cmd_splice_insert_decode().

Rename struct dvbpsi_sis_component_utc_splice_time_t to dvbpsi_sis_component_t and
also rename dvbpsi_sis_splice_event_t::p_splice_utc_time to dvbpsi_sis_splice_event_t::p_component.

The code meant to move the upmost pts_adjustment bit 33 down to the
lowest bit (bit 1), so it can be or-ed to a byte as lowest bit. However
the first part of the calculation (i_pts_adjustment & 0x00800) had as result
zero. Then shifting it over 32 bit, resulted in still zero. The calculation
was plain wrong.

First shift all bits over 32 to the right. This places bit 33 on bit 1, then
mask out all the other bits and keep bit 1, thus; (i_pts_adjustment >> 32) & 0x01

The function dvbpsi_DetachDemux(), which is now a wrapper around dvbpsi_chain_demux_delete()
failed to check the return value. Now it returns an error message when the return value is 'false'.

Dereference after NULL check (Fixes CID #134926, #134927, #134928, #13429, #13430, #134931, #134932, #134933, #134934, #134935, #134936, #134937, #134938, #134939, #134940)

Check the dvbpsi handle before passing it to dvbpsi_chain_demux_delete().

(cherry picked from commit cad97408)
Signed-off-by: Jean-Paul Saman <jpsaman@videolan.org>

All decoders implemented a new property named p_cb_data. This patch
moves the usage to dvbpsi_decoder_t::p_priv. The callback data is now
a dvbpsi decoder generic property.

By removing the i_program_number argument from dvbpsi_pmt_attach() its prototype then
matches that of all other dvbpsi_*_attach() functions. The i_extension was already used
as being the program number in case of PMT tables since the beginning of libdvbpsi its
implementation.

Treat i_program_number as i_extension.

If a dvbpsi_t handle was created but the attached PSI table demuxer was
never triggered because the table is not present in the stream, then the
function dvbpsi_chain_demux_delete() would not free its resources properly.
This caused dvbpsi_delete() on the dvbpsi_t handle to fail.

The function dvbpsi_chain_demux_delete() is changed to handle this situation
properly.

PMT are attached by using dvbpsi_pmt_attach() function directly and not through
a demuxing chain, so release the PMT's in the same manner. Thus using the
function dvbpsi_pmt_detach() directly.

It is the responsibility of the calling application to release dvbpsi_decoder_t::p_priv pointer
and its associated memory.