According to EN 300 468, 12 bits after the frequency field are reserved
for future use. Thus, they should be set to 1.

(cherry picked from commit 6e007df2f7eef82243974e3b619fe1c366a1b6a1)
Signed-off-by: Jean-Paul Saman <jpsaman@videolan.org>

(modified by Jean-Paul Saman <jpsaman@videolan.org>)
Added wrapper function to map dvbpsi_ExtendedChannelNameDr onto dvbpsi_DecodeExtendedChannelNameDr and update documentation.

(cherry picked from commit 7841440f06d01e2857fac3db1be07909446bcad4)
Signed-off-by: Jean-Paul Saman <jpsaman@videolan.org>

The generation function for the subtitling descriptor erroneously uses the
modulo operation instead of a bitwise AND.

(cherry picked from commit bc7bb320854b0d4bd4f74a5851be0852681d629d)
Signed-off-by: Jean-Paul Saman <jpsaman@videolan.org>

The index variable in the generation function for the telext descriptor was
scaled by 8 instead of by 5.

(cherry picked from commit 614bfbaebdbfda25f2cb7015e71f997f8874930e)
Signed-off-by: Jean-Paul Saman <jpsaman@videolan.org>

Due to scaling the index variable by 8 instead of 4, the generation function of
the parental rating descriptor makes out-of-bounds array accesses.

(cherry picked from commit 0752d56b25f3b2724618de4cd50a11d0f9420af2)
Signed-off-by: Jean-Paul Saman <jpsaman@videolan.org>

The generation function for the content descriptor makes out-of-bound array
accesses due to scaling an index value improperly.

(cherry picked from commit dc456b945fc6072154729e712e00bfd72fd32714)
Signed-off-by: Jean-Paul Saman <jpsaman@videolan.org>

The decoding function for the CA identifier descriptor does not take into
account the lower byte of i_ca_system_id.

(cherry picked from commit a6bb209280ed156ff509eb98f1d5d33f9c8d719f)
Signed-off-by: Jean-Paul Saman <jpsaman@videolan.org>

Since one NVOD reference structure takes 6 bytes, the number of all structures
contained in the descriptor should be the length of its payload divided by 6,
not the remainder of this division.

(cherry picked from commit 057ca087fd1c74a5af92422801ca36f2e23787e0)
Signed-off-by: Jean-Paul Saman <jpsaman@videolan.org>

(cherry picked from commit 25669604c1e16f945f7f6d896bf9d7b97e19f03c)
Signed-off-by: Jean-Paul Saman <jpsaman@videolan.org>

Due to the lack of parenthesis, the expression used to read handover_type was
read as (p_descriptor->p_data[7] & (0xF0 >> 4)).

(cherry picked from commit 61bb8944e881d602db9f77a89051ada310958b28)
Signed-off-by: Jean-Paul Saman <jpsaman@videolan.org>

Linkage descriptor's generation and decoding routines improperly calculated the
beginning of the private data region in cases where linkage_type = 8,
handover_info = 0, and origin_type = 1.

(cherry picked from commit 979733f1b500a24d43165ed442d9167991a42452)
Signed-off-by: Jean-Paul Saman <jpsaman@videolan.org>

The shortest valid linkage descriptor contains 56 bits = 7 bytes of payload.
Since the maximum possible payload length is 253 bytes, this leaves 246 bytes
for private data, not 248.

Also, the length checks were changed in order to check the minimum possible
length of the descriptor with the given data, instead of checking maximum
lengths.

(cherry picked from commit 36836f6fec2211d86e62e507570ba7372392d4f6)
Signed-off-by: Jean-Paul Saman <jpsaman@videolan.org>

Descriptor 0x41 was erroneously generated with tag 0x83.

(cherry picked from commit fb8dad5c41ee09e4bc3a44c2baa38379d713cce3)
Signed-off-by: Jean-Paul Saman <jpsaman@videolan.org>

GCC 5.1.0 features stricter warnings about comparing boolean variables
with integer values, and thus compilation with --enable-debug failed
with "comparison of constant 12 with boolean expression is always true".
The leftover pieces of old code which treated integers as booleans are
now fixed, and the test suite is now compilable and runs correctly.

Signed-off-by: Jean-Paul Saman <jpsaman@videolan.org>

Signed-off-by: Jean-Paul Saman <jpsaman@videolan.org>