Check i_fd to have a valid value.

pf_write() returns a ssize_t which was stored inside a size_t (an unsigned).
Later on this value was used in a check against 0.

The pointer to p_subdec should have been evaluated on line 119.

The wrong pointer was checked for having a null value leading to the
null pointer dereference bug.

The bug occurs due to a missing check for allocation failure of p_decoded->i_text.
Instead p_decoded is checked again.

The assert() dereferenced the p_dvbpsi pointer before it was checked for null-value.

The code does not leak a socket descriptor while looping over addrinfo pointer structs.However initializing s_ctl to -1 again after calling close(s_ctl) is good practise.

The code does not leak a socket descriptor while looping over addrinfo pointer structs.However initializing s_ctl to -1 again after calling close(s_ctl) is good practise.

The error path for dvbpsi_AttachDemux() in handle_atsc_MGT failed to release
allocated resources.

The error path for dvbpsi_pmt_attach() in handle_PAT failed to release
allocated resources.

The value of i_nb_programs could exceed the MAX_PROGRAMS limit and thus
produce a buffer overrun.

- syslog.h is not available on Windows platforms.
- O_NONBLOCK is not defined for Windows platforms.

Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>

Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>

- EIT bugfixes and dvbinfo updates
- ETT table
- MGT table
- VCT table
- STT table

Use helper functions:
- dvbpsi_CanDecodeAsDescriptor()
- dvbpsi_IsDescripterDecoded()

Fix weird indentation introduced by commit: 9afd8b97103181a8d68699d368cac9ad27ad6c5c

The preferred coding style is:
- 4 spaces indentation (no tabs)
- indent '{' and '}' on the same column as the 'if', eg:
  if (...)
  {
  }
- function declarations always start in the first column

Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>

Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>

Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>

Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>

Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>