mpeg/psi: Add support for descriptor 0x1b (MPEG-4 video descriptor).

README

@@ -78,6 +78,7 @@ Supported MPEG descriptors
  * Descriptor 0x10: Smoothing buffer descriptor
  * Descriptor 0x11: STD descriptor
  * Descriptor 0x12: IBP descriptor
+ * Descriptor 0x1b: MPEG-4 video descriptor
 
 
 Supported DVB descriptors

TODO

@@ -2,7 +2,6 @@ TODO items for biTStream. The items are not ordered by importance
 so if you like something just do it and send a patch.
 
 - Add support (parser, generator, example) for these MPEG descriptors:
-  - Descriptor 0x1b MPEG-4_video_descriptor
   - Descriptor 0x1c MPEG-4_audio_descriptor
   - Descriptor 0x1d IOD_descriptor
   - Descriptor 0x1e SL_descriptor

examples/dvb_gen_si.c

@@ -225,6 +225,12 @@ static void build_desc12(uint8_t *desc) {
     desc12_set_max_gop_length(desc, 5000);
 }
 
+/* MPEG Descriptor 0x1b: MPEG4 Video descriptor */
+static void build_desc1b(uint8_t *desc) {
+    desc1b_init(desc);
+    desc1b_set_mpeg4_visual_profile_and_level(desc, 0x12);
+}
+
 /* =========================================================================
  * DVB defined descriptors
  * ========================================================================= */
@@ -1476,6 +1482,9 @@ static void generate_pmt(void) {
             desc = descs_get_desc(desc_loop, desc_counter++);
             build_desc11(desc);
 
+            desc = descs_get_desc(desc_loop, desc_counter++);
+            build_desc1b(desc);
+
             // Finish descriptor generation
             desc = descs_get_desc(desc_loop, desc_counter); // Get next descriptor pos
             descs_set_length(desc_loop, desc - desc_loop - DESCS_HEADER_SIZE);

mpeg/psi/desc_1b.h

+/*****************************************************************************
+ * desc_1b.h: ISO/IEC 13818-1 Descriptor 0x1b (MPEG-4 video descriptor)
+ *****************************************************************************
+ * Copyright (C) 2011 Unix Solutions Ltd.
+ *
+ * Authors: Georgi Chorbadzhiyski <georgi@unixsol.org>
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining
+ * a copy of this software and associated documentation files (the
+ * "Software"), to deal in the Software without restriction, including
+ * without limitation the rights to use, copy, modify, merge, publish,
+ * distribute, sublicense, and/or sell copies of the Software, and to
+ * permit persons to whom the Software is furnished to do so, subject
+ * to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be
+ * included in all copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+ * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
+ * MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.
+ * IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY
+ * CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT,
+ * TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE
+ * SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
+ *****************************************************************************/
+
+/*
+ * Normative references:
+ *  - ISO/IEC 13818-1:2007(E) (MPEG-2 Systems)
+ */
+
+#ifndef __BITSTREAM_MPEG_DESC_1B_H__
+#define __BITSTREAM_MPEG_DESC_1B_H__
+
+#include <bitstream/common.h>
+#include <bitstream/mpeg/psi/descriptors.h>
+
+#ifdef __cplusplus
+extern "C"
+{
+#endif
+
+/*****************************************************************************
+ * Descriptor 0x1b (MPEG-4 video descriptor)
+ *****************************************************************************/
+#define DESC1B_HEADER_SIZE      (DESC_HEADER_SIZE + 1)
+
+static inline void desc1b_init(uint8_t *p_desc)
+{
+    desc_set_tag(p_desc, 0x1b);
+    desc_set_length(p_desc, DESC1B_HEADER_SIZE - DESC_HEADER_SIZE);
+}
+
+static inline bool desc1b_validate(const uint8_t *p_desc)
+{
+    return desc_get_length(p_desc) >= DESC1B_HEADER_SIZE - DESC_HEADER_SIZE;
+}
+
+static inline uint8_t desc1b_get_mpeg4_visual_profile_and_level(const uint8_t *p_desc) {
+    return p_desc[2];
+}
+
+static inline void desc1b_set_mpeg4_visual_profile_and_level(uint8_t *p_desc, uint8_t i_mpeg4_visual_profile_and_level) {
+    p_desc[2] = i_mpeg4_visual_profile_and_level;
+}
+
+static inline void desc1b_print(const uint8_t *p_desc, f_print pf_print,
+                                void *opaque, print_type_t i_print_type)
+{
+    switch (i_print_type) {
+    case PRINT_XML:
+        pf_print(opaque, "<MPEG4_VIDEO_DESC visual_profile_and_level=\"0x%02x\"/>",
+                 desc1b_get_mpeg4_visual_profile_and_level(p_desc));
+        break;
+    default:
+        pf_print(opaque,"    - desc 1b mpeg4_video visual_profile_and_level=0x%02x",
+                 desc1b_get_mpeg4_visual_profile_and_level(p_desc));
+    }
+}
+
+#ifdef __cplusplus
+}
+#endif
+
+#endif

mpeg/psi/descs_list.h

@@ -51,5 +51,6 @@
 #include <bitstream/mpeg/psi/desc_10.h>
 #include <bitstream/mpeg/psi/desc_11.h>
 #include <bitstream/mpeg/psi/desc_12.h>
+#include <bitstream/mpeg/psi/desc_1b.h>
 
 #endif

mpeg/psi/descs_print.h

@@ -117,6 +117,7 @@ static inline void descl_print(uint8_t *p_descl, uint16_t i_length,
         CASE_DESC(10)
         CASE_DESC(11)
         CASE_DESC(12)
+        CASE_DESC(1b)
         CASE_DESC_ICONV(40)
         CASE_DESC(41)
         CASE_DESC(43)