Skip to content

L
linux-davinci
Switch branch/tag
  1. 28 Nov, 2006 2 commits
  3. 27 Nov, 2006 3 commits
    • Linus Torvalds's avatar
      Fix 'ALIGN()' macro, take 2 · 2ea58144
      Linus Torvalds authored 
      You wouldn't think that doing an ALIGN() macro that aligns something up
to a power-of-two boundary would be likely to have bugs, would you?

But hey, in the wonderful world of mixing integer types, you have to be
careful.  This just makes sure that the alignment is interpreted in the
same type as the thing to be aligned.

Thanks to Roland Dreier, who noticed that the amso1100 driver got broken
by the previous fix (that just extended the mask to "unsigned long", but
was still broken in "unsigned long long" - it just happened to be the
same on 64-bit architectures).

See commit 4c8bd7ee for the history of
bugs here...
Acked-by: default avatarRoland Dreier <rdreier@cisco.com>
Cc: Andrew Morton <akpm@osdl.org>
Cc: David Miller <davem@davemloft.net>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
      2ea58144
    • Kyle McMartin's avatar
      [PATCH] Fix incorrent type of flags in <asm/semaphore.h> · c9c3b86f
      Kyle McMartin authored 
      I still think using BUILD_BUG_ON() is unacceptable, especially given how
vague the error message was.
Signed-off-by: default avatarKyle McMartin <kyle@parisc-linux.org>
[ And I already removed gthe BUILD_BUG_ON() in the previous commit ]
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
      c9c3b86f
    • Linus Torvalds's avatar
      Revert "[PATCH] Enforce "unsigned long flags;" when spinlocking" · b8e6ec86
      Linus Torvalds authored 
      This reverts commit ee3ce191, since it
broke on at least ARM, MIPS and PA-RISC due to complicated header file
dependencies.

Conflicts in include/linux/spinlock.h (due to the "nested" variety
fixes) fixed up by hand.

Cc: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: Kyle McMartin <kyle@parisc-linux.org>
Cc: Russell King <rmk+lkml@arm.linux.org.uk>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
      b8e6ec86
  5. 26 Nov, 2006 8 commits
  7. 25 Nov, 2006 26 commits
  9. 23 Nov, 2006 1 commit
    • Mel Gorman's avatar
      [PATCH] x86_64: fix bad page state in process 'swapper' · 1abbfb41
      Mel Gorman authored 
      find_min_pfn_for_node() and find_min_pfn_with_active_regions() both
depend on a sorted early_node_map[].  However, sort_node_map() is being
called after fin_min_pfn_with_active_regions() in
free_area_init_nodes().

In most cases, this is ok, but on at least one x86_64, the SRAT table
caused the E820 ranges to be registered out of order.  This gave the
wrong values for the min PFN range resulting in some pages not being
initialised.

This patch sorts the early_node_map in find_min_pfn_for_node().  It has
been boot tested on x86, x86_64, ppc64 and ia64.
Signed-off-by: default avatarMel Gorman <mel@csn.ul.ie>
Acked-by: default avatarAndre Noll <maan@systemlinux.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
      1abbfb41