Skip to content

L
linux-davinci
Switch branch/tag
  1. 16 Dec, 2008 1 commit
  3. 11 Dec, 2008 1 commit
  5. 10 Dec, 2008 1 commit
  7. 03 Dec, 2008 1 commit
  9. 02 Dec, 2008 1 commit
  11. 01 Dec, 2008 2 commits
  13. 28 Nov, 2008 1 commit
  15. 27 Nov, 2008 2 commits
    • Julia Lawall's avatar
      ALSA: sound/pci/mixart/mixart.c: Add missing snd_card_free · 73f6a12e
      Julia Lawall authored 
      The function snd_mixart_create creates a link between mgr and card that
allows snd_mixart_free to free card as well.  But if snd_mixart_create
fails, then the link has not been created and card has to be freed explicitly.

The semantic match that finds the problem is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@r exists@
local idexpression x;
statement S,S1;
position p1,p2,p3;
expression E,E1;
type T,T1;
expression *ptr != NULL;
@@

(
 if ((x@p1 = snd_card_new(...)) == NULL) S
|
 x@p1 = snd_card_new(...);
)
 ... when != snd_card_free(...,(T)x,...)
     when != if (...) { <+... snd_card_free(...,(T)x,...) ...+> }
     when != true x == NULL || ...
     when != x = E
     when != E = (T)x
     when any
(
 if (x == NULL || ...) S1
|
 if@p2 (...) {
  ... when != snd_card_free(...,(T1)x,...)
      when != if (...) { <+... snd_card_free(...,(T1)x,...) ...+> }
      when != x = E1
      when != E1 = (T1)x
(
  return \(0\|<+...x...+>\|ptr\);
|
  return@p3 ...;
)
}
)

@ script:python @
p1 << r.p1;
p3 << r.p3;
@@

print "* file: %s snd_card_new: %s return: %s" % (p1[0].file,p1[0].line,p3[0].line)

// </smpl>
Signed-off-by: default avatarJulia Lawall <julia@diku.dk>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      73f6a12e
    • Daniel Mack's avatar
      ALSA: snd-usb-caiaq: clean up the control adding code · 12666f05
      Daniel Mack authored 
      snd-usb-caiaq: clean up the control adding code by moving dulpicate code
to a function.
Signed-off-by: default avatarDaniel Mack <daniel@caiaq.de>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      12666f05
  17. 18 Nov, 2008 1 commit
  19. 14 Nov, 2008 1 commit
  21. 12 Nov, 2008 2 commits
  23. 07 Nov, 2008 4 commits
  25. 05 Nov, 2008 1 commit
  27. 03 Nov, 2008 5 commits
  29. 01 Nov, 2008 1 commit
  31. 30 Oct, 2008 3 commits
  33. 29 Oct, 2008 3 commits
  35. 27 Oct, 2008 2 commits
  37. 23 Oct, 2008 2 commits
  39. 22 Oct, 2008 1 commit
  41. 21 Oct, 2008 2 commits
  43. 20 Oct, 2008 2 commits