Commits · f13618b8d6ad12509fc4e0e75e6ec8752c0cfb27 · linux / linux-davinci

09 Nov, 2009 1 commit

Quiet the following sparse noise: · f13618b8

H Hartley Sweeten authored Nov 09, 2009

  warning: Using plain integer as NULL pointer
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Greg Kroah-Hartman <gregkh@suse.de>
Cc: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

f13618b8

12 Nov, 2009 1 commit

No need to export those device attributes. · 6a5248d6

Alex Chiang authored Nov 13, 2009

In fact, without this patch, we can trip over a build error if cciss
is a built-in and another driver also declares and exports attributes
with the same name.

You'll see errors like:

	drivers/scsi/built-in.o: multiple definition of `dev_attr_lunid'
	drivers/block/built-in.o: first defined here

Cc: Stephen M. Cameron <scameron@beardog.cce.hp.com>
Signed-off-by: Alex Chiang <achiang@hp.com>
Cc: <mike.miller@hp.com>
Cc: Jens Axboe <jens.axboe@oracle.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

6a5248d6

06 Oct, 2009 1 commit

DAC960_LP_Controller and DAC960_V2_Controller have the same value, but · 3e8920e4

Julia Lawall authored Oct 06, 2009

elsewhere it is DAC960_V1_Controller or DAC960_V2_Controller that is used
in the FirmwareType field.
Signed-off-by: Julia Lawall <julia@diku.dk>
Cc: Jens Axboe <jens.axboe@oracle.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

3e8920e4

03 Nov, 2009 2 commits

struct pmcraid_ioctl_header member buffer_length is unsigned, so this · f7ba06c5

Roel Kluin authored Nov 04, 2009

check appears redundant.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Acked-by: Anil Ravindranath <anil_ravindranath@pmc-sierra.com>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

f7ba06c5

If the NULL test on dev->i2o_dev or i2o_dev is needed, then the dereference · 3126efe0

Julia Lawall authored Nov 03, 2009

should be after the NULL test.

A simplified version of the semantic match that detects this problem is as
follows (http://coccinelle.lip6.fr/):

// <smpl>
@match exists@
expression x, E;
identifier fld;
@@

* x->fld
  ... when != \(x = E\|&x\)
* x == NULL
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Cc: James Bottomley <James.Bottomley@suse.de>
Cc: Kashyap Desai <kashyap.desai@lsi.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

3126efe0

12 Nov, 2009 14 commits

No need to export those device attributes. · d01dcc6e

Alex Chiang authored Nov 13, 2009

In fact, without this patch, we can trip over a build error if hpsa
is a built-in and another driver also declares and exports attributes
with the same name.

You'll see errors like:

	drivers/scsi/built-in.o: multiple definition of `dev_attr_lunid'
	drivers/block/built-in.o: first defined here
Signed-off-by: Alex Chiang <achiang@hp.com>
Cc: Stephen M. Cameron <scameron@beardog.cce.hp.com>
Cc: Mike Miller <mikem@beardog.cce.hp.com>
Cc: Jens Axboe <jens.axboe@oracle.com>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

d01dcc6e

hpsa: fix typo that causes scsi status to be lost · 9197fe19

Stephen M. Cameron authored Nov 12, 2009

Signed-off-by: Stephen M. Cameron <scameron@beardog.cce.hp.com>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Jens Axboe <jens.axboe@oracle.com>
Cc: Mike Miller <mikem@beardog.cce.hp.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

9197fe19

hpsa: Make fill_cmd() return void, and BUG() if it is asked to · b5b6a8bd

Stephen M. Cameron authored Nov 12, 2009

fill out an unknown command or command type, as that should simply
not happen as all the commands and command types are fixed, and
known ahead of time.
Signed-off-by: Stephen M. Cameron <scameron@beardog.cce.hp.com>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Jens Axboe <jens.axboe@oracle.com>
Cc: Mike Miller <mikem@beardog.cce.hp.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

b5b6a8bd

hpsa: Remove sendcmd, there are no instances in which we must poll for · 2d2b6275

Stephen M. Cameron authored Nov 12, 2009

command completion.  This means sendcmd_core() and pollcomplete()
can be removed as well.
Signed-off-by: Stephen M. Cameron <scameron@beardog.cce.hp.com>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Jens Axboe <jens.axboe@oracle.com>
Cc: Mike Miller <mikem@beardog.cce.hp.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

2d2b6275

hpsa: Flush cache with interrupts still enabled. It's not · 4cd2e88b

Stephen M. Cameron authored Nov 12, 2009

necessary to disable interrupts prior to flushing the cache
on driver unload.  Also, don't dma from the stack.
Signed-off-by: Stephen M. Cameron <scameron@beardog.cce.hp.com>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Jens Axboe <jens.axboe@oracle.com>
Cc: Mike Miller <mikem@beardog.cce.hp.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

4cd2e88b

hpsa: Retry driver initiated commands on unit attention. · 3cdb5ab9

Stephen M. Cameron authored Nov 12, 2009

There are a some commands initiated by the driver which
are neither ioctls nor normal i/o.  If any of these commands
completes with UNIT ATTENTION, they should be retried.
Signed-off-by: Stephen M. Cameron <scameron@beardog.cce.hp.com>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Jens Axboe <jens.axboe@oracle.com>
Cc: Mike Miller <mikem@beardog.cce.hp.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

3cdb5ab9

hpsa: decode unit attention condition and mark commands with DID_SOFT_ERROR · 1803265e

Stephen M. Cameron authored Nov 12, 2009

to make the mid-layer retry them.
Signed-off-by: Stephen M. Cameron <scameron@beardog.cce.hp.com>
Signed-off-by: Mike Miller <mikem@beardog.cce.hp.com>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Jens Axboe <jens.axboe@oracle.com>
Cc: Mike Miller <mikem@beardog.cce.hp.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

1803265e

hpsa: Make hpsa_sdev_attrs static · 7eddc5f4

Stephen M. Cameron authored Nov 12, 2009

Signed-off-by: Stephen M. Cameron <scameron@beardog.cce.hp.com>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Jens Axboe <jens.axboe@oracle.com>
Cc: Mike Miller <mikem@beardog.cce.hp.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

7eddc5f4

Allow device rescan to be triggered via sysfs. · e3a8d586

Stephen M. Cameron authored Nov 12, 2009

Signed-off-by: Stephen M. Cameron <scameron@beardog.cce.hp.com>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Jens Axboe <jens.axboe@oracle.com>
Cc: Mike Miller <mikem@beardog.cce.hp.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

e3a8d586

Add thread to allow controllers to register for rescan for new devices · 011771ec

Stephen M. Cameron authored Nov 12, 2009

(borrowed code from cciss.)
Signed-off-by: Stephen M. Cameron <scameron@beardog.cce.hp.com>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Jens Axboe <jens.axboe@oracle.com>
Cc: Mike Miller <mikem@beardog.cce.hp.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

011771ec

hpsa: Factor out some pci_unmap code. There are a few places · b76cd2f3

Stephen M. Cameron authored Nov 12, 2009

where the same, or nearly the same code is used to pci_unmap
data buffers of driver initiated commands.  Factor these out
into a separate function.
Signed-off-by: Stephen M. Cameron <scameron@beardog.cce.hp.com>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Jens Axboe <jens.axboe@oracle.com>
Cc: Mike Miller <mikem@beardog.cce.hp.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

b76cd2f3

hpsa: Factor out command submission sequence. There · 7486e98a

Stephen M. Cameron authored Nov 12, 2009

are a few places where the same sequence of statements
occurs to submit and wait for the completion of a command.
Factor these out into a separate function.
Signed-off-by: Stephen M. Cameron <scameron@beardog.cce.hp.com>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Jens Axboe <jens.axboe@oracle.com>
Cc: Mike Miller <mikem@beardog.cce.hp.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

7486e98a

Use shost_priv instead of accessing host->hostdata[0] directly. · 1e1bb2a4

Stephen M. Cameron authored Nov 12, 2009

Signed-off-by: Stephen M. Cameron <scameron@beardog.cce.hp.com>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Jens Axboe <jens.axboe@oracle.com>
Cc: Mike Miller <mikem@beardog.cce.hp.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

1e1bb2a4

hpsa: Allocate the correct amount of extra space for the scsi host · 3fdc0c94

Stephen M. Cameron authored Nov 12, 2009

Signed-off-by: Stephen M. Cameron <scameron@beardog.cce.hp.com>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Jens Axboe <jens.axboe@oracle.com>
Cc: Mike Miller <mikem@beardog.cce.hp.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

3fdc0c94

13 Oct, 2009 1 commit

Fix use of unallocated memory for MSA2xxx enclosure device data. If you · 7aafb8f6

Stephen M. Cameron authored Oct 13, 2009

happened to have fewer physical devices reported by CCISS_REPORT_LUNS than
the total number of MSA2012 enclosures (unlikely), the data for some
enclosure(s) would get stored into, or cause other device data to be
stored into unallocated territory.
Signed-off-by: Stephen M. Cameron <scameron@beardog.cce.hp.com>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Jens Axboe <jens.axboe@oracle.com>
Cc: Mike Miller <mikem@beardog.cce.hp.com>
Cc: Stephen M. Cameron <scameron@beardog.cce.hp.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

7aafb8f6

09 Oct, 2009 1 commit

avoid helpful cleanup patches. · d9fe1f59

Andrew Morton authored Oct 09, 2009

Cc: "Stephen M. Cameron" <scameron@beardog.cce.hp.com>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Jens Axboe <jens.axboe@oracle.com>
Cc: Mike Miller <mikem@beardog.cce.hp.com>
Cc: Stephen M. Cameron <scameron@beardog.cce.hp.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

d9fe1f59

10 Oct, 2009 1 commit

Fix hpsa_allow_any test for vendor ID. · dd93d089

Stephen M. Cameron authored Oct 10, 2009

Signed-off-by: Stephen M. Cameron <scameron@beardog.cce.hp.com>
Cc: Mike Miller <mikem@beardog.cce.hp.com>
Cc: Jens Axboe <jens.axboe@oracle.com>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

dd93d089

09 Nov, 2009 1 commit

Add hpsa driver for HP Smart Array controllers. · 16530091

Stephen M. Cameron authored Nov 09, 2009

This driver supports a subset of HP Smart Array Controllers.
It is a SCSI alternative to the cciss driver.
Signed-off-by: Stephen M. Cameron <scameron@beardog.cce.hp.com>
Signed-off-by: Mike Miller <mikem@beardog.cce.hp.com>
Cc: Jens Axboe <jens.axboe@oracle.com>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

16530091

03 Nov, 2009 1 commit

At the point where cmnd is initialized, it is tested for NULL, so it · fd62e82a

Julia Lawall authored Nov 03, 2009

doesn't have to be tested again here.

A simplified version of the semantic match that detects this problem is as
follows (http://coccinelle.lip6.fr/):

// <smpl>
@match exists@
expression x, E;
identifier fld;
@@

* x->fld
  ... when != \(x = E\|&x\)
* x == NULL
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

fd62e82a

14 Oct, 2009 1 commit

Besides keeping the line short, the second setting of the MR_DMA_MODE bit · b6ca89fd

Roel Kluin authored Oct 14, 2009

was removed.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

b6ca89fd

29 Sep, 2009 1 commit

The field stat->stat should be compared to SAM_GOOD, not SAM_STAT_GOOD, as · 0886e399

Julia Lawall authored Sep 30, 2009

done elsewhere in the same function.  Both constants have the same value.
Signed-off-by: Julia Lawall <julia@diku.dk>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

0886e399

19 Sep, 2009 1 commit

value cannot logically be less than START and greater than BUFFERSIZE. · 39b82a09

Roel Kluin authored Sep 19, 2009

#define EXTENDED_SENSE_START  18

// vi include/scsi/scsi_cmnd.h +105
#define SCSI_SENSE_BUFFERSIZE 	96

[akpm@linux-foundation.org: fix warning]
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Cc: Willem Riede <osst@riede.org>
Cc: James E.J. Bottomley <James.Bottomley@HansenPartnership.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

39b82a09

09 Nov, 2009 1 commit

kmalloc() may fail, so test whether it succeeded. · 7d4c46bb

Roel Kluin authored Nov 09, 2009

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Wei Yongjun <yjwei@cn.fujitsu.com>
Cc: Mike Christie <michaelc@cs.wisc.edu>
Cc: Boaz Harrosh <bharrosh@panasas.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

7d4c46bb

25 Sep, 2009 1 commit

unmap ccb_phys as well when scsi_add_host() fails · d773f2f3

Roel Kluin authored Sep 25, 2009

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Cc: Achim Leubner <achim_leubner@adaptec.com>
Cc: James E.J. Bottomley <James.Bottomley@HansenPartnership.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

d773f2f3

20 Aug, 2009 1 commit

Fix scsi_devinfo.c kernel-doc function names to match actual function · 4ce6cee2

Randy Dunlap authored Aug 21, 2009

names.
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

4ce6cee2

04 Aug, 2009 2 commits

Check whether index is within bounds before testing the element. · cb191a96

Roel Kluin authored Aug 04, 2009

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Cc: Willem Riede <osst@riede.org>
Cc: James E.J. Bottomley <James.Bottomley@HansenPartnership.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

cb191a96

Check whether index is within bounds before testing the element. · 79c1c870

Roel Kluin authored Aug 04, 2009

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Cc: James Smart <James.Smart@Emulex.Com>
Cc: Joe Eykholt <jeykholt@cisco.com>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

79c1c870

29 Jul, 2009 1 commit

This allows i == MAX_INT_PARAM, which is out of range for ints[] · 9d200ea3

Roel Kluin authored Jul 29, 2009

Found with Parfait, http://research.sun.com/projects/parfait/Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Cc: Dario Ballabio <ballabio_dario@emc.com>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

9d200ea3

25 Sep, 2009 1 commit

This allows i == MAXHA, which is out of range · 41a0cad8

Roel Kluin authored Sep 25, 2009

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

41a0cad8

29 Jul, 2009 1 commit

Allows i == MAX_INT_PARAM, which is out of range. · 55523e56

Roel Kluin authored Jul 29, 2009

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Cc: Michael Neuffer <mike@i-Connect.Net>
Cc: Dario Ballabio <ballabio_dario@emc.com>
Cc: James E.J. Bottomley <James.Bottomley@HansenPartnership.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

55523e56

25 Sep, 2009 1 commit

Allows i == IM_MAX_HOSTS, which is out of range. · 255635df

Roel Kluin authored Sep 25, 2009

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Cc: Michael Lang <langa2@kph.uni-mainz.de>
Cc: James E.J. Bottomley <James.Bottomley@HansenPartnership.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

255635df

09 Nov, 2009 1 commit

In fnic_abort_cmd() and fnic_device_reset() assign `rport' earlier to make · 61d85d9f

Roel Kluin authored Nov 09, 2009

FNIC_SCSI_DBG() calls cleaner.

In fnic_clean_pending_aborts() `rport' is not used.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
Acked-by: Abhijeet Joglekar <abjoglek@cisco.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

61d85d9f

11 Aug, 2009 1 commit

Add the __init and __exit macros to the module_init / module_exit · 37caab86

Peter Huewe authored Aug 11, 2009

functions from drivers/scsi/ibmvscsi/ibmvstgt.c
Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
Acked-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: James Bottomley <James.Bottomley@SteelEye.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

37caab86

06 Oct, 2009 1 commit

do_div() takes a u64. The mips build warns: · 4c338c20

Andrew Morton authored Oct 06, 2009

In file included from include/trace/ftrace.h:635,
                 from include/trace/define_trace.h:61,
                 from include/trace/events/lockdep.h:96,
                 from kernel/lockdep.c:52:
include/trace/events/lockdep.h: In function `ftrace_raw_event_lock_acquired':
include/trace/events/lockdep.h:71: warning: comparison of distinct pointer types lacks a cast

from the check in include/asm-generic/div64.h:do_div().

Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

4c338c20

16 Oct, 2009 1 commit

dmar_ir_support() references dmar_tbl which is annotated with · 752ffa18

Stephen Boyd authored Oct 17, 2009

__initdata. The only caller of dmar_ir_support() is
intr_remapping_supported() also annotated with __init.

WARNING: drivers/pci/built-in.o(.text+0xa110): Section mismatch in
reference from the function dmar_ir_support() to the variable
.init.data:dmar_tbl
The function dmar_ir_support() references
the variable __initdata dmar_tbl.
This is often because dmar_ir_support lacks a __initdata
annotation or the annotation of dmar_tbl is wrong.
Signed-off-by: Stephen Boyd <bebarino@gmail.com>
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: David Woodhouse <David.Woodhouse@intel.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

752ffa18