1. 17 Oct, 2008 16 commits
  2. 16 Oct, 2008 15 commits
  3. 14 Oct, 2008 1 commit
  4. 11 Oct, 2008 1 commit
    • Paul Walmsley's avatar
      i2c-omap: fix I2C timeouts due to recursive omap_i2c_{un,}idle() · 663715fc
      Paul Walmsley authored
      omap_i2c_unidle() and omap_i2c_idle() are called recursively during
      omap_i2c_probe().  This is evidently unexpected and will wipe
      out the I2C interrupt enable register the second time that
      omap_i2c_idle() is called consecutively.  Any I2C transactions
      following a probe of a bus with at least one device on it will then
      time out.
      
      Fix by moving omap_i2c_idle() further up in omap_i2c_probe().  Ensure
      the I2C controller is marked as idle before the probe starts.  Also
      attempt to catch future reappearances of this bug early in development
      by warning in omap_i2c_{un,}idle() when they are called recursively.
      
      Problem reported by David Brownell <david-b@pacbell.net>.
      
      Tested on 3430SDP and 2430SDP.
      Signed-off-by: default avatarPaul Walmsley <paul@pwsan.com>
      Cc: David Brownell <david-b@pacbell.net>
      Cc: Richard Woodruff <r-woodruff2@ti.com>
      Acked-by; Steve Sakoman <steve@sakoman.com>
      Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
      663715fc
  5. 10 Oct, 2008 7 commits
    • Sanjeev Premi's avatar
      Enable CONFIG_GPIO_TWL4030=y · 3c013448
      Sanjeev Premi authored
      Without this option, kernel builds would fail, with
      errors similar to:
      
      hsmmc.c:50: undefined reference to `twl4030_get_gpio_datain'
      hsmmc.c:82: undefined reference to `twl4030_free_gpio'
      hsmmc.c:63: undefined reference to `twl4030_request_gpio'
      hsmmc.c:67: undefined reference to `twl4030_set_gpio_debounce'
      Signed-off-by: default avatarSanjeev Premi <premi@ti.com>
      Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
      3c013448
    • David Brownell's avatar
      twl4030-pwrirq simplification, cleanup · 62c21db8
      David Brownell authored
      I can't test the pwrbutton stuff, but rtc and musb behave...
      
      With one issue:  the usb transceiver glue misbehaves on
      startup if the device is connected.  (Again.)  I looked at
      this a bit, and I think the issue is probably caused by
      not actually using key USB registers ... IRQ trigger
      mode state transitions are at best a fragile proxy for the
      real state.
      
      (This is similar to the GPIO patch I just sent, but simpler
      except for the impact on the few drivers thinking oddly
      about IRQs.  Those patches cover the key SIH modules, and
      a similar one affects the PIH in twl4030-core.)
      
      - Dave
      
      ================================
      Streamline the "power irq" code, and some of the mechanisms
      it uses:
      
       - Support IRQ masking, not just unmasking; simpler code.
       - Use the standard handle_edge_irq() handler for these edge IRQs.
       - Use generic_handle_irq() instead of a manual expansion thereof.
       - Provide a missing spinlock for the shared data.
      
      In short, use more of the standard genirq code ... more correctly.
      
      Also, update the drivers using the "power IRQ" accordingly:
      
       - Don't request IRQF_DISABLED if the handler makes I2C calls;
         and defend against lockdep forcing it on us.
      
       - Let the irq_chip handle IRQ mask/unmask; it handles mutual
         exclusion between drivers, among other things.
      
       - (Unrelated) remove useless MODULE_ALIAS in pwrbutton.
      
      The USB transceiver driver still places some dodgey games with IRQ
      enable/disable, and IRQ trigger flags.  At least some of them seem
      like they'd be simplified by using USB transceiver registers ...
      notably, startup code, which doesn't seem to check state before
      it enters an irq-driven mode.
      
      For the moment, these drivers still (wrongly) try to configure IRQ
      trigger modes themselves ... again, that's something that an irq_chip
      handles (but not yet, for this one).
      
      NOTE:  tested (MUSB and RTC only) along with the init/retry hack
      to make twl4030-pwrirq work around the i2c-omap timeout problems.
      62c21db8
    • Tony Lindgren's avatar
      Minor cosmetic clean-up for LDP for mainline · d0558a7c
      Tony Lindgren authored
      Minor cosmetic clean-up for LDP for mainline
      Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
      d0558a7c
    • Daniel Stone's avatar
      FB: OMAP: DISPC: Allow multiple external IRQ handlers · 71a0a8f8
      Daniel Stone authored
      Previously, the only external (to dispc.c) IRQ handler was RFBI's
      frame done handler.  dispc's IRQ framework was very dumb: you could only
      have one handler, and the semantics of {request,free}_irq were odd, to
      say the least.
      
      The new framework allows multiple consumers to register arbitrary IRQ
      masks.
      Signed-off-by: default avatarDaniel Stone <daniel.stone@nokia.com>
      Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
      71a0a8f8
    • Siarhei Siamashka's avatar
      FB: OMAP: Blizzard: Properly disable zoom when necessary · 73422a65
      Siarhei Siamashka authored
      The problem is related to the following notice in the documentation:
      "Once a destructive window with up-scaling is created, it can only be
      disabled by creating a background window.". With the current omapfb
      driver code, if you try to do a partial screen update (show menu or
      dialog) after a scaled screen update (video overlay), scaling setting
      are not reset properly and you see this "magnifying glass" effect if a
      part of new update overlaps previously scaled area.
      Signed-off-by: default avatarSiarhei Siamashka <siarhei.siamashka@nokia.com>
      Signed-off-by: default avatarDaniel Stone <daniel.stone@nokia.com>
      Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
      73422a65
    • Daniel Stone's avatar
      Input: Touchscreen: Make TSC2005 depend on SPI · 6e595fc8
      Daniel Stone authored
      Make Kconfig reflect reality.
      Signed-off-by: default avatarDaniel Stone <daniel.stone@nokia.com>
      Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
      6e595fc8
    • Hiroshi DOYU's avatar
      ARM: OMAP: fix uninitialized warning · bb64148c
      Hiroshi DOYU authored
      warning: 'rev_name' may be used uninitialized in this function
      Signed-off-by: default avatarHiroshi DOYU <Hiroshi.DOYU@nokia.com>
      Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
      bb64148c