1. 03 Nov, 2009 1 commit
  2. 16 Oct, 2009 2 commits
    • Andrew Morton's avatar
      ERROR: code indent should use tabs where possible · 9429b460
      Andrew Morton authored
      #44: FILE: drivers/hwmon/w83627ehf.c:8:
      +                        Daniel J Blueman <daniel.blueman@gmail.com>$
      
      WARNING: line over 80 characters
      #88: FILE: drivers/hwmon/w83627ehf.c:306:
      +			     4->variable thermal cruise (also called SmartFan III) */
      
      WARNING: line over 80 characters
      #111: FILE: drivers/hwmon/w83627ehf.c:544:
      +						W83627EHF_REG_FAN_START_OUTPUT[i]);
      
      WARNING: line over 80 characters
      #113: FILE: drivers/hwmon/w83627ehf.c:546:
      +						W83627EHF_REG_FAN_STOP_OUTPUT[i]);
      
      total: 1 errors, 3 warnings, 153 lines checked
      
      ./patches/hwmon-w83627ehf-updates.patch has style problems, please review.  If any of these errors
      are false positives report them to the maintainer, see
      CHECKPATCH in MAINTAINERS.
      
      Please run checkpatch prior to sending patches
      
      Cc: Daniel J Blueman <daniel.blueman@gmail.com>
      Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      9429b460
    • Daniel J Blueman's avatar
      Add control of fan minimum turn-on output levels, decoupling it from the · 78eef0e1
      Daniel J Blueman authored
      fan turn-off output level.  Add control of rate of change of fan output
      level.  These in turn allow lower turn-off rotor speed and smoother
      transitions for better thermal and acoustic control authority.  Add
      support for constant fan speed and proportional-response operations modes.
      Signed-off-by: default avatarDaniel J Blueman <daniel.blueman@gmail.com>
      Cc: Jean Delvare <khali@linux-fr.org>
      Cc: David Hubbard <david.c.hubbard@gmail.com>
      Cc: Hans de Goede <hdegoede@redhat.com>
      Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      78eef0e1
  3. 09 Nov, 2009 1 commit
  4. 06 Oct, 2009 1 commit
  5. 09 Nov, 2009 1 commit
  6. 12 Nov, 2009 2 commits
    • Andrew Morton's avatar
      may as well depukify it a bit while we're there. · 7bc82a6b
      Andrew Morton authored
      
      
      WARNING: plain inline is preferred over __inline__
      #22: FILE: lib/crc32.c:47:
      +static __inline__ u32
      
      ERROR: space prohibited after that open square bracket '['
      #26: FILE: lib/crc32.c:51:
      +#  define DO_CRC(x) crc = tab[ (crc ^ (x)) & 255 ] ^ (crc>>8)
      
      ERROR: space prohibited before that close square bracket ']'
      #26: FILE: lib/crc32.c:51:
      +#  define DO_CRC(x) crc = tab[ (crc ^ (x)) & 255 ] ^ (crc>>8)
      
      ERROR: Macros with complex values should be enclosed in parenthesis
      #26: FILE: lib/crc32.c:51:
      +#  define DO_CRC(x) crc = tab[ (crc ^ (x)) & 255 ] ^ (crc>>8)
      
      ERROR: space prohibited after that open square bracket '['
      #28: FILE: lib/crc32.c:53:
      +#  define DO_CRC(x) crc = tab[ ((crc >> 24) ^ (x)) & 255] ^ (crc<<8)
      
      ERROR: Macros with complex values should be enclosed in parenthesis
      #28: FILE: lib/crc32.c:53:
      +#  define DO_CRC(x) crc = tab[ ((crc >> 24) ^ (x)) & 255] ^ (crc<<8)
      
      ERROR: spaces required around that '=' (ctx:WxV)
      #30: FILE: lib/crc32.c:55:
      +	const u32 *b =(u32 *)buf;
       	             ^
      
      ERROR: space required before the open parenthesis '('
      #34: FILE: lib/crc32.c:59:
      +	if(unlikely(((long)b)&3 && len)) {
      
      ERROR: space required before the open parenthesis '('
      #53: FILE: lib/crc32.c:78:
      +	if(len) {
      
      total: 8 errors, 1 warnings, 145 lines checked
      
      ./patches/crc32-minor-optimizations-and-cleanup.patch has style problems, please review.  If any of these errors
      are false positives report them to the maintainer, see
      CHECKPATCH in MAINTAINERS.
      
      Please run checkpatch prior to sending patches
      
      Cc: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
      Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      7bc82a6b
    • Joakim Tjernlund's avatar
      Move common crc body to new function crc32_body() cleaup and micro · dd4137bb
      Joakim Tjernlund authored
      optimize crc32_body for speed and less size.
      Signed-off-by: default avatarJoakim Tjernlund <Joakim.Tjernlund@transmode.se>
      Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      dd4137bb
  7. 16 Oct, 2009 1 commit
  8. 28 Oct, 2009 1 commit
    • Hidetoshi Seto's avatar
      In case if the statement and the conditional are in one line, the line · 6805b1c7
      Hidetoshi Seto authored
      appears in the report doubly.
      
      And items of this check have no blank line before the next item.
      
      This patch fixes these trivial problems, to improve readability of the
      report.
      
      [sample.c]
        > if (cond1
        >        && cond2
        >        && cond3) func_foo();
        >
        > if (cond4) func_bar();
      
      Before:
        > ERROR: trailing statements should be on next line
        > #1: FILE: sample.c:1:
        > +if (cond1
        > [...]
        > +       && cond3) func_foo();
        > ERROR: trailing statements should be on next line
        > #5: FILE: sample.c:5:
        > +if (cond4) func_bar();
        > +if (cond4) func_bar();
        > total: 2 errors, 0 warnings, 5 lines checked
      
      After:
        > ERROR: trailing statements should be on next line
        > #1: FILE: sample.c:1:
        > +if (cond1
        > [...]
        > +       && cond3) func_foo();
        >
        > ERROR: trailing statements should be on next line
        > #5: FILE: sample.c:5:
        > +if (cond4) func_bar();
        >
        > total: 2 errors, 0 warnings, 5 lines checked
      Signed-off-by: default avatarHidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
      Cc: Andy Whitcroft <apw@canonical.com>
      Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      6805b1c7
  9. 09 Nov, 2009 1 commit
  10. 25 Sep, 2009 1 commit
  11. 12 Nov, 2009 1 commit
  12. 11 Nov, 2009 1 commit
  13. 10 Nov, 2009 1 commit
  14. 15 Oct, 2009 1 commit
  15. 09 Oct, 2009 1 commit
  16. 04 Nov, 2009 2 commits
    • Andrew Morton's avatar
      ERROR: code indent should use tabs where possible · 022bea6b
      Andrew Morton authored
      #28: FILE: arch/arm/mach-msm/include/mach/mmc.h:12:
      +        struct sdio_cis cis;$
      
      ERROR: code indent should use tabs where possible
      #29: FILE: arch/arm/mach-msm/include/mach/mmc.h:13:
      +        struct sdio_cccr cccr;$
      
      ERROR: code indent should use tabs where possible
      #30: FILE: arch/arm/mach-msm/include/mach/mmc.h:14:
      +        struct sdio_embedded_func *funcs;$
      
      ERROR: code indent should use tabs where possible
      #31: FILE: arch/arm/mach-msm/include/mach/mmc.h:15:
      +        int num_funcs;$
      
      WARNING: line over 80 characters
      #39: FILE: arch/arm/mach-msm/include/mach/mmc.h:23:
      +	int (*register_status_notify)(void (*callback)(int card_present, void *dev_id), void *dev_id);
      
      total: 4 errors, 1 warnings, 50 lines checked
      
      ./patches/msm_sdccc-add-missing-include-fix-compilation.patch has style problems, please review.  If any of these errors
      are false positives report them to the maintainer, see
      CHECKPATCH in MAINTAINERS.
      
      Please run checkpatch prior to sending patches
      
      Cc: Pavel Machek <pavel@ucw.cz>
      Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      022bea6b
    • Pavel Machek's avatar
      Add missing include for msm_sdcc compilation, and remove pwrsink · ebad1a45
      Pavel Machek authored
      support that is not mainline, yet.
      Signed-off-by: default avatarPavel Machek <pavel@ucw.cz>
      Cc <linux-mmc@vger.kernel.org>
      Cc: Russell King <rmk@arm.linux.org.uk>
      Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      ebad1a45
  17. 03 Nov, 2009 1 commit
  18. 16 Oct, 2009 1 commit
  19. 14 Oct, 2009 1 commit
  20. 29 Sep, 2009 2 commits
  21. 14 Oct, 2009 1 commit
  22. 09 Nov, 2009 2 commits
  23. 10 Nov, 2009 1 commit
  24. 13 Oct, 2009 7 commits
  25. 09 Nov, 2009 1 commit
    • Joe Perches's avatar
      UUID/GUIDs are somewhat common in kernel source. · c988f0ff
      Joe Perches authored
      Standardize the printed style of UUID/GUIDs by using
      another extension to %p.
      
      %pUb:   01020304-0506-0708-090a-0b0c0d0e0f10
      %pUB:   01020304-0506-0708-090A-0B0C0D0E0F10 (upper case)
      %pUl:   04030201-0605-0807-090a-0b0c0d0e0f10
      %pUL:   04030201-0605-0807-090A-0B0C0D0E0F10 (upper case)
      
      %pU defaults to %pUb
      Signed-off-by: default avatarJoe Perches <joe@perches.com>
      Cc: Jeff Garzik <jgarzik@redhat.com>
      Cc: Tejun Heo <tj@kernel.org>
      Cc: Alex Elder <aelder@sgi.com>
      Cc: Christoph Hellwig <hch@lst.de>
      Cc: Artem Bityutskiy <dedekind@infradead.org>
      Cc: Adrian Hunter <adrian.hunter@nokia.com>
      Cc: Steven Whitehouse <swhiteho@redhat.com>
      Cc: Mauro Carvalho Chehab <mchehab@infradead.org>
      Cc: Matt Mackall <mpm@selenic.com>
      Cc: Neil Brown <neilb@suse.de>
      Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      c988f0ff
  26. 30 Oct, 2009 1 commit
  27. 28 Oct, 2009 2 commits
    • Joe Perches's avatar
      Fix email matching without name --n and --git-blame · b67d94a0
      Joe Perches authored
         Using --non and --git-blame caused maintainer signature
         matching to fail.  Fixed that by adding 3rd argument to
         sub format_email to control show/hide name portion of address
      Slurp -f file instead of reading line-by-line for K: pattern matching.
         Suggested by Wolfram Sang as more efficient
      Refactor git command execution
         Break into 2 functions, execute/analyze
         Share code between --git and --git-blame
         Don't warn multiple times when git isn't installed
      Improve stats reporting
         --git-min-percent and -- rolestats now count the total number of commits
         for either the period of --git-since or if using --git-blame the commits
         used by the current file and calculate commit % as
            # of commits signed / total commits * 100
      Code style cleaning
         Use consistent sub foo { my (args...) = @_;
      Signed-off-by: default avatarJoe Perches <joe@perches.com>
      Cc: Ben Hutchings <ben@decadent.org.uk>
      Cc: Greg KH <greg@kroah.com>
      Cc: Pavel Machek <pavel@ucw.cz>
      Cc: Wolfram Sang <w.sang@pengutronix.de>
      Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      b67d94a0
    • Joe Perches's avatar
      --roles shows the role of each email address, i.e. why it was selected. · e13e757d
      Joe Perches authored
      --rolestats selects --roles and adds git log/blame signers #'s and %
      
      Multiple roles are possible (supporter, maintainer, git-signer...)
      
      --roles or --rolestats is meant to help identify appropriate maintainers
      to notify and should not be used with "git send-email --cc-cmd"
      
      Example output:
      
      Existing:
      
      $ ./scripts/get_maintainer.pl -f arch/x86/kernel/acpi/boot.c
      Corentin Chary <corentincj@iksaif.net>
      Karol Kozimor <sziwan@users.sourceforge.net>
      Len Brown <len.brown@intel.com>
      Pavel Machek <pavel@ucw.cz>
      Rafael J. Wysocki <rjw@sisk.pl>
      Thomas Gleixner <tglx@linutronix.de>
      Ingo Molnar <mingo@redhat.com>
      H. Peter Anvin <hpa@zytor.com>
      x86@kernel.org
      Yinghai Lu <yhlu.kernel@gmail.com>
      Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
      acpi4asus-user@lists.sourceforge.net
      linux-pm@lists.linux-foundation.org
      linux-kernel@vger.kernel.org
      
      With --roles
      
      $ ./scripts/get_maintainer.pl --roles -f arch/x86/kernel/acpi/boot.c
      Corentin Chary <corentincj@iksaif.net> (maintainer:ASUS ACPI EXTRAS...)
      Karol Kozimor <sziwan@users.sourceforge.net> (maintainer:ASUS ACPI EXTRAS...)
      Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM,git-signer)
      Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
      Rafael J. Wysocki <rjw@sisk.pl> (supporter:SUSPEND TO RAM)
      Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE...)
      Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE...,git-signer)
      H. Peter Anvin <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...)
      x86@kernel.org (maintainer:X86 ARCHITECTURE...)
      Yinghai Lu <yhlu.kernel@gmail.com> (git-signer)
      Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> (git-signer)
      acpi4asus-user@lists.sourceforge.net (open list:ASUS ACPI EXTRAS...)
      linux-pm@lists.linux-foundation.org (open list:SUSPEND TO RAM)
      linux-kernel@vger.kernel.org (open list)
      
      With --rolestats
      
      $ ./scripts/get_maintainer.pl --rolestats -f arch/x86/kernel/acpi/boot.c
      Corentin Chary <corentincj@iksaif.net> (maintainer:ASUS ACPI EXTRAS...)
      Karol Kozimor <sziwan@users.sourceforge.net> (maintainer:ASUS ACPI EXTRAS...)
      Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM,git-signer:16/79=20%)
      Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
      Rafael J. Wysocki <rjw@sisk.pl> (supporter:SUSPEND TO RAM)
      Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE...)
      Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE...,git-signer:29/79=37%)
      H. Peter Anvin <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...)
      x86@kernel.org (maintainer:X86 ARCHITECTURE...)
      Yinghai Lu <yhlu.kernel@gmail.com> (git-signer:12/79=15%)
      Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> (git-signer:6/79=8%)
      acpi4asus-user@lists.sourceforge.net (open list:ASUS ACPI EXTRAS...)
      linux-pm@lists.linux-foundation.org (open list:SUSPEND TO RAM)
      linux-kernel@vger.kernel.org (open list)
      
      With --rolestats and --git-blame
      
      $ ./scripts/get_maintainer.pl --rolestats --git-blame -f arch/x86/kernel/acpi/boot.c
      Corentin Chary <corentincj@iksaif.net> (maintainer:ASUS ACPI EXTRAS...)
      Karol Kozimor <sziwan@users.sourceforge.net> (maintainer:ASUS ACPI EXTRAS...)
      Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM,git-signer:16/79=20%,commits:22/154=14%)
      Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
      Rafael J. Wysocki <rjw@sisk.pl> (supporter:SUSPEND TO RAM)
      Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE...)
      Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE...,git-signer:29/79=37%,commits:36/154=23%)
      H. Peter Anvin <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...)
      x86@kernel.org (maintainer:X86 ARCHITECTURE...)
      Yinghai Lu <yhlu.kernel@gmail.com> (git-signer:12/79=15%,commits:9/154=6%)
      Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> (git-signer:6/79=8%)
      Andi Kleen <ak@suse.de> (commits:11/154=7%)
      Andrew Morton <akpm@osdl.org> (commits:10/154=6%)
      acpi4asus-user@lists.sourceforge.net (open list:ASUS ACPI EXTRAS...)
      linux-pm@lists.linux-foundation.org (open list:SUSPEND TO RAM)
      linux-kernel@vger.kernel.org (open list)
      
      Other changes:
      
      Format git-signers email addresses a bit to reduce bad signatures
      Command line bad arguments emitted a verbose usage(), just show --help
      Version number bumped to .22
      
      Ben Hutchings had the idea and created a good deal of this implementation.
      Signed-off-by: default avatarJoe Perches <joe@perches.com>
      Signed-off-by: default avatarBen Hutchings <ben@decadent.org.uk>
      Cc: Greg KH <greg@kroah.com>
      Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      e13e757d
  28. 12 Oct, 2009 1 commit