Commits · dea3f665d6fa263a9870a54e9f8cfd146016f140 · linux / linux-davinci

20 Jun, 2008 40 commits

Jonathan Corbet authored May 16, 2008

Add lock_kernel() calls to adpt_open()
Signed-off-by: Jonathan Corbet <corbet@lwn.net>

dea3f665

videopix: BKL pushdown · 9aaf20cb

Jonathan Corbet authored May 16, 2008

Add explicit lock_kernel() calls to vfc_open().
Signed-off-by: Jonathan Corbet <corbet@lwn.net>

9aaf20cb

bpp: bkl pushdown · 5e9829ad

Jonathan Corbet authored May 16, 2008

Put explicit lock_kernel() calls into bpp_open().  It has locking, but I'm
not convinced it won't race with ioctl().
Signed-off-by: Jonathan Corbet <corbet@lwn.net>

5e9829ad

phantom: BKL pushdown · 4541b5ec

Jonathan Corbet authored May 16, 2008

Add explicit lock_kernel calls to phantom_open().
Signed-off-by: Jonathan Corbet <corbet@lwn.net>

4541b5ec

infiniband: more BKL pushdown · 057e7c7f

Jonathan Corbet authored May 16, 2008

Be extra-cautious and protect the remaining open() functions.
Signed-off-by: Jonathan Corbet <corbet@lwn.net>

057e7c7f

dsp56k: BKL pushdown · 65f37b79

Jonathan Corbet authored May 16, 2008

Put explicit lock_kernel calls into dsp56k_open().

[Stupid missing label error fixed]
Signed-off-by: Jonathan Corbet <corbet@lwn.net>

65f37b79

raw: BKL pushdown · c0bed680

Jonathan Corbet authored May 16, 2008

Put explicit lock_kernel() calls into raw_open(), even though the existing
locking looks adequate.
Signed-off-by: Jonathan Corbet <corbet@lwn.net>

c0bed680

tlckl: BKL pushdown · b8c71d7a

Jonathan Corbet authored May 16, 2008

Put explicit lock_kernel calls into tlclk_open()
Signed-off-by: Jonathan Corbet <corbet@lwn.net>

b8c71d7a

xilinx icap: BKL pushdown · f4943db1

Jonathan Corbet authored May 16, 2008

Add explicit lock_kernel() calls to hwicap_open() even though the existing
locking looks adequate.
Signed-off-by: Jonathan Corbet <corbet@lwn.net>

f4943db1

vcs: BKL pushdown · f97259e3

Jonathan Corbet authored May 16, 2008

Add explicit BKL to vcs_open().
Signed-off-by: Jonathan Corbet <corbet@lwn.net>

f97259e3

spidev: BKL pushdown · 609f9e92

Jonathan Corbet authored May 16, 2008

Add the BKL to spidev_open(), even though the existing locking looks
adequate.
Signed-off-by: Jonathan Corbet <corbet@lwn.net>

609f9e92

Add "no BKL needed" comments to several drivers · d21c95c5

Jonathan Corbet authored May 16, 2008

This documents the fact that somebody looked at the relevant open()
functions and concluded that, due to their trivial nature, no locking was
needed.
Signed-off-by: Jonathan Corbet <corbet@lwn.net>

d21c95c5

tty: cdev lock_kernel() pushdown · 39d95b9d
Jonathan Corbet authored May 16, 2008
```
Parts of the serial code actually BUG() if we don't do this.
```
39d95b9d
snsc: cdev lock_kernel() pushdown · c43ef174
Jonathan Corbet authored May 15, 2008
```
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
```
c43ef174
sound: cdev lock_kernel() pushdown · 78a3c3d7
Jonathan Corbet authored May 15, 2008
```
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
```
78a3c3d7
fbmem: cdev lock_kernel() pushdown · fc7f687a
Jonathan Corbet authored May 15, 2008
```
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
```
fc7f687a
dvb: cdev lock_kernel() pushdown · 5794e1b1
Jonathan Corbet authored May 15, 2008
```
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
```
5794e1b1

usbcore: cdev lock_kernel() pushdown · 20613f24

Jonathan Corbet authored May 15, 2008

usb_open() is protected by a down_read(&minor_rwsem), but I'm not sure I
trust it to protect everything including subsidiary open() functions.
Signed-off-by: Jonathan Corbet <corbet@lwn.net>

20613f24

isdn: cdev lock_kernel() pushdown · 1bcaa0bd
Jonathan Corbet authored May 15, 2008
```
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
```
1bcaa0bd
gdth: cdev lock_kernel() pushdown · 46787b48
Jonathan Corbet authored May 15, 2008
```
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
```
46787b48
st: cdev lock_kernel() pushdown · b3369c68
Jonathan Corbet authored May 15, 2008
```
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
```
b3369c68
aacraid: cdev lock_kernel() pushdown · d4514d1b
Jonathan Corbet authored May 15, 2008
```
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
```
d4514d1b
osst: cdev lock_kernel() pushdown. · 647d87bd
Jonathan Corbet authored May 15, 2008
```
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
```
647d87bd
sg: cdev lock_kernel() pushdown · eb09d3d4
Jonathan Corbet authored May 15, 2008
```
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
```
eb09d3d4

ide-tape: cdev lock_kernel() pushdown · 04f4ac9d

Jonathan Corbet authored May 15, 2008

->release() already has explicit lock_kernel() calls...
Signed-off-by: Jonathan Corbet <corbet@lwn.net>

04f4ac9d

phonedev: cdev lock_kernel() pushdown · 16750c2f

Jonathan Corbet authored May 15, 2008

phone_open() looks OK, but I don't trust the subsidiary drivers (and ixj in
particular).
Signed-off-by: Jonathan Corbet <corbet@lwn.net>

16750c2f

drm: cdev lock_kernel() pushdown · 70ffa16e
Jonathan Corbet authored May 15, 2008
```
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
```
70ffa16e
lp: cdev lock_kernel() pushdown · abedd296
Jonathan Corbet authored May 15, 2008
```
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
```
abedd296

mbcs: cdev lock_kernel() pushdown · 12ead6b0

Jonathan Corbet authored May 15, 2008

This driver would appear to have no internal locking at all.
Signed-off-by: Jonathan Corbet <corbet@lwn.net>

12ead6b0

viotape: cdev lock_kernel pushdown () · 2d863e92
Jonathan Corbet authored May 15, 2008
```
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
```
2d863e92

misc: cdev lock_kernel() pushdown · 309c4551

Jonathan Corbet authored May 15, 2008

misc_open() looks fine, but who knows what all of the misc drivers are
doing in their open() functions?
Signed-off-by: Jonathan Corbet <corbet@lwn.net>

309c4551

mem: cdev lock_kernel() pushdown · 1f439647

Jonathan Corbet authored May 15, 2008

It's really hard to tell if this is necessary - lots of weird
magic happens by way of map_devmem()
Signed-off-by: Jonathan Corbet <corbet@lwn.net>

1f439647

ipmi: cdev lock_kernel() pushdown · ecc38983
Jonathan Corbet authored May 15, 2008
```
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
```
ecc38983
UIO: cdev lock_kernel() pushdown · fbc8a81d
Jonathan Corbet authored May 15, 2008
```
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
```
fbc8a81d
Input: cdev lock_kernel() pushdown · 2edbf853
Jonathan Corbet authored May 15, 2008
```
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
```
2edbf853
HID: cdev lock_kernel() pushdown · 702e57d9
Jonathan Corbet authored May 15, 2008
```
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
```
702e57d9
UBI: cdev lock_kernel() pushdown · 72b67048
Jonathan Corbet authored May 15, 2008
```
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
```
72b67048
mtdchar: cdev lock_kernel() pushdown · 6071239e
Jonathan Corbet authored May 15, 2008
```
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
```
6071239e
paride: cdev lock_kernel() pushdown · ea2959a2
Jonathan Corbet authored May 15, 2008
```
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
```
ea2959a2
AoE: cdev lock_kernel() pushdown · 579174a5
Jonathan Corbet authored May 15, 2008
```
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
```
579174a5