Skip to content

L
linux-davinci
An error occurred fetching the project authors.
Switch branch/tag
  1. 04 Sep, 2008 3 commits
    • Gerrit Renker's avatar
      dccp tfrc: Perform early loss detection · d20ed95f
      Gerrit Renker authored 
      This enables the TFRC code to begin loss detection (as soon as the module
is loaded), using the latest updates from rfc3448bis-06, 6.3.1:

 * when the first data packet(s) are lost or marked, set
 * X_target = s/(2*R) => f(p) = s/(R * X_target) = 2,
 * corresponding to a loss rate of ~ 20.64%.

The handle_loss() function is now called right at the begin of rx_packet_recv()
and thus no longer protected against duplicates: hence a call to rx_duplicate()
has been added.  Such a call makes sense now, as the previous patch initialises
the first entry with a sequence number of GSR.
Signed-off-by: default avatarGerrit Renker <gerrit@erg.abdn.ac.uk>
      d20ed95f
    • Gerrit Renker's avatar
      dccp tfrc: Receiver history initialisation routine · 24b8d343
      Gerrit Renker authored 
      This patch 
 1) separates history allocation and initialisation, to facilitate early
    loss detection (implemented by a subsequent patch);

 2) removes duplication by using the existing tfrc_rx_hist_purge() if the
    allocation fails. This is now possible, since the initialisation routine
 3) zeroes out the entire history before using it. 
Signed-off-by: default avatarGerrit Renker <gerrit@erg.abdn.ac.uk>
      24b8d343
    • Gerrit Renker's avatar
      dccp ccid-3: Remove ugly RTT-sampling history lookup · 63b3a73b
      Gerrit Renker authored 
      This removes the RTT-sampling function tfrc_tx_hist_rtt(), since

 1. it suffered from complex passing of return values (the return value both
    indicated successful lookup while the value doubled as RTT sample);

 2. when for some odd reason the sample value equalled 0, this triggered a bug
    warning about "bogus Ack", due to the ambiguity of the return value;

 3. on a passive host which has not sent anything the TX history is empty and
    thus will lead to unwanted "bogus Ack" warnings such as
    ccid3_hc_tx_packet_recv: server(e7b7d518): DATAACK with bogus ACK-28197148
    ccid3_hc_tx_packet_recv: server(e7b7d518): DATAACK with bogus ACK-26641606.

The fix is to replace the implicit encoding by performing the steps manually.					       

Furthermore, the "bogus Ack" warning has been removed, since it can actually be
triggered due to several reasons (network reordering, old packet, (3) above),
hence it is not very useful.
Signed-off-by: default avatarGerrit Renker <gerrit@erg.abdn.ac.uk>
      63b3a73b
  3. 13 Jul, 2008 3 commits
    • Gerrit Renker's avatar
      dccp ccid-3: Fix a loss detection bug · b552c623
      Gerrit Renker authored 
      This fixes a bug in the logic of the TFRC loss detection:
 * new_loss_indicated() should not be called while a loss is pending;
 * but the code allows this;
 * thus, for two subsequent gaps in the sequence space, when loss_count
   has not yet reached NDUPACK=3, the loss_count is falsely reduced to 1.

To avoid further and similar problems, all loss handling and loss detection is
now done inside tfrc_rx_hist_handle_loss(), using an appropriate routine to
track new losses.

Further changes:
----------------
 * added a reminder that no RX history operations should be performed when
   rx_handle_loss() has identified a (new) loss, since the function takes
   care of packet reordering during loss detection;
 * made tfrc_rx_hist_loss_pending() bool (thanks to an earlier suggestion
   by Arnaldo);		 
 * removed unused functions.
Signed-off-by: default avatarGerrit Renker <gerrit@erg.abdn.ac.uk>
      b552c623
    • Gerrit Renker's avatar
      dccp: Upgrade NDP count from 3 to 6 bytes · 5b5d0e70
      Gerrit Renker authored 
      RFC 4340, 7.7 specifies up to 6 bytes for the NDP Count option, whereas the code
is currently limited to up to 3 bytes. This seems to be a relict of an earlier 
draft version and is brought up to date by the patch.
Signed-off-by: default avatarGerrit Renker <gerrit@erg.abdn.ac.uk>
      5b5d0e70
    • Gerrit Renker's avatar
      dccp ccid-3: Fix error in loss detection · 2013c7e3
      Gerrit Renker authored 
      The TFRC loss detection code used the wrong loss condition (RFC 4340, 7.7.1):
 * the difference between sequence numbers s1 and s2 instead of 
 * the number of packets missing between s1 and s2 (one less than the distance).

Since this condition appears in many places of the code, it has been put into a
separate function, dccp_loss_free().

Further changes:
----------------
 * tidied up incorrect typing (it was using `int' for u64/s64 types);
 * optimised conditional statements for common case of non-reordered packets;
 * rewrote comments/documentation to match the changes.
Signed-off-by: default avatarGerrit Renker <gerrit@erg.abdn.ac.uk>
      2013c7e3
  5. 28 Jan, 2008 13 commits
  7. 20 Jul, 2007 1 commit
    • Paul Mundt's avatar
      mm: Remove slab destructors from kmem_cache_create(). · 20c2df83
      Paul Mundt authored 
      Slab destructors were no longer supported after Christoph's
c59def9f change. They've been
BUGs for both slab and slub, and slob never supported them
either.

This rips out support for the dtor pointer from kmem_cache_create()
completely and fixes up every single callsite in the kernel (there were
about 224, not including the slab allocator definitions themselves,
or the documentation references).
Signed-off-by: default avatarPaul Mundt <lethal@linux-sh.org>
      20c2df83
  9. 11 Dec, 2006 1 commit
  11. 27 Aug, 2006 4 commits
  13. 30 Jun, 2006 1 commit
  15. 29 Aug, 2005 6 commits