An error occurred fetching the project authors.
- 01 Oct, 2008 7 commits
-
-
David Brownell authored
Provide detailed diagnostics in add_children() when DEBUG is defined ... and fix the non-DEBUG message to include minimal status, and not appear unless there was actually an error. Update the IRQ message; have it match what the GPIO subchip says, and as a precaution, make it only appear if the IRQs have been initialized. Signed-off-by: David Brownell <dbrownell@users.sourceforge.net> Added a few more diagnostics when platform_device_add() fails. Signed-off-by: Felipe Balbi <felipe.balbi@nokia.com> Signed-off-by: Tony Lindgren <tony@atomide.com>
-
David Brownell authored
Minor twl4030-core cleanups: alphabetize the creation of the new sub-function nodes; wrap an #if around the OMAP-only part (to get more general build testing when this goes upstream); remove reference to undocumented "twl3040" variant. Signed-off-by: David Brownell <dbrownell@users.sourceforge.net> Moved gpio before keypad driver due to alphabetic order. Signed-off-by: Felipe Balbi <felipe.balbi@nokia.com> Signed-off-by: Tony Lindgren <tony@atomide.com>
-
Felipe Balbi authored
Moving twl4030-madc to new style registration just like the other twl4030 children. Cc: Mikko Ylinen <mikko.k.ylinen@nokia.com> Signed-off-by: Felipe Balbi <felipe.balbi@nokia.com> Signed-off-by: Tony Lindgren <tony@atomide.com>
-
David Brownell authored
Make the twl4030 core create a platform device to which its GPIO code will bind, with platform_data used to configure board-specific behaviors and configuration. Update the twl4030 GPIO code: - Morph its gpio function code into a platform driver. - Move away from IRQ (and GPIO) numbers hard-wired in headers. - Hook up the twl4030 GPIO code to gpiolib. - Start phasing out the older TWL-specific calls ... currently those are used only by arch/arm/mach-omap2/hsmmc.c setup code. - Use a mutex for locking, not a binary semaphore. NOTE: more patches pending: (a) this doesn't use pdata->pullups to initialize (currently hsmmc code always sets GPIO-0 pullup even if the board has an external pullup); (b) there's a new gpio request/free hook forthcoming in 2.6.28, which this should use; (c) likewise there's a new gpio_to_irq() hook; (d) the irq_chip set_type() mechanism needs to be supported; (e) needs to move over to drivers/gpio; (f) upcoming threaded IRQ infrastructure should be used, when that merges. Signed-off-by: David Brownell <dbrownell@users.sourceforge.net> Signed-off-by: Felipe Balbi <felipe.balbi@nokia.com> Signed-off-by: Tony Lindgren <tony@atomide.com>
-
Felipe Balbi authored
use new style twl4030-core to register a platform_device for twl4030-usb. Signed-off-by: Felipe Balbi <felipe.balbi@nokia.com> Signed-off-by: Tony Lindgren <tony@atomide.com>
-
Felipe Balbi authored
let twl4030-core.c take care of twl4030_keypad registration. Signed-off-by: Felipe Balbi <felipe.balbi@nokia.com> Signed-off-by: Tony Lindgren <tony@atomide.com>
-
Felipe Balbi authored
Clean up add_children a bit before adding more children to twl4030-core.c Signed-off-by: Felipe Balbi <felipe.balbi@nokia.com> Signed-off-by: Tony Lindgren <tony@atomide.com>
-
- 25 Sep, 2008 1 commit
-
-
David Brownell authored
A bunch of little cleanups to twl4030-core. - Remove needless header inclusions, symbols, and forward declarations. - Make coding style more standard. And shrink the object size a bit. Signed-off-by: David Brownell <dbrownell@users.sourceforge.net> Signed-off-by: Tony Lindgren <tony@atomide.com>
-
- 23 Sep, 2008 1 commit
-
-
David Brownell authored
More updates preparing for upstream merge of twl4030 driver: Basic fixes - twl4030-core becomes a new-style I2C driver - declare and use platform_data structure for that core - stop hard-wiring the irq numbers - check functionality that's really used: I2C, not SMBus Cleanup: - remove needless "client string" - remove some fake "bool" types - include catalog part numbers (TPS659{5,3,2}0) - diagnostics should identify the driver! To use this, all boards with these chips will need to declare this chip when they declare their active I2C busses (done in a separate patch). NOTE: the TWL4030_IRQ_* symbols still need to vanish, along with other global resource assignments associated with these chips. Signed-off-by: David Brownell <dbrownell@users.sourceforge.net> Signed-off-by: Tony Lindgren <tony@atomide.com>
-
- 12 Sep, 2008 1 commit
-
-
David Brownell authored
Make the twl4030 RTC initialization follow the driver model better. The platform device is created (if needed) as part of twl4030 setup instead of as a board-specific thing, and fits properly into the driver model tree. The only minor glitch here is on boards using platform_data to pass MSECURE initialization hooks to the RTC driver. The right solution probably just removes that platform_data, and might even make Linux follow the principle of "least privilege" (at the hardware level!) instead of always holding this signal high. Pending better handling of MSECURE, this patch just does what the RTC init does, but earlier: MSECURE is always high, so the RTC time and calendar registers can be updated (and presumably a bunch of non-RTC privileged operations will be allowed too). Yet to be done: set up the IRQ resource; make the rtc driver use that IRQ resource; and properly issue wakeup alarms. Signed-off-by: David Brownell <dbrownell@users.sourceforge.net> Signed-off-by: Tony Lindgren <tony@atomide.com>
-
- 06 Aug, 2008 2 commits
-
-
Tony Lindgren authored
Looks like recent patches broke compile. Signed-off-by: Tony Lindgren <tony@atomide.com>
-
Paul Walmsley authored
Mark many functions in twl4030-core.c as __init. Signed-off-by: Paul Walmsley <paul@pwsan.com> Signed-off-by: Tony Lindgren <tony@atomide.com>
-
- 05 Aug, 2008 1 commit
-
-
Paul Walmsley authored
Several functions use old-style function documentation; convert those to use the current kerneldoc style. Thanks to Felipe Balbi <felipe.balbi@nokia.com> for catching an error. Signed-off-by: Paul Walmsley <paul@pwsan.com> Signed-off-by: Tony Lindgren <tony@atomide.com>
-
- 04 Aug, 2008 8 commits
-
-
Paul Walmsley authored
Mask/clear TWL module IMRs/ISRs by iterating through arrays rather than using a block of cut-and-pasted commands. Removes 1056 bytes of bloat. Signed-off-by: Paul Walmsley <paul@pwsan.com> Signed-off-by: Tony Lindgren <tony@atomide.com>
-
Paul Walmsley authored
twl_init_irq() uses a bunch of magic numbers as register indices; this has already led to several errors, fixed earlier in this patch series. Now use descriptive macros instead of magic numbers. This patch should not change kernel behavior. Signed-off-by: Paul Walmsley <paul@pwsan.com> Signed-off-by: Tony Lindgren <tony@atomide.com>
-
Paul Walmsley authored
twl_init_irq() prints error messages and returns if any interrupt mask register writes fail. Change this to generate a warning traceback and to continue execution rather than skipping TWL init. (These mask writes should not fail at all unless either the I2C bus or the TWL4030 is somehow wedged.) Signed-off-by: Paul Walmsley <paul@pwsan.com> Signed-off-by: Tony Lindgren <tony@atomide.com>
-
Paul Walmsley authored
TWL4030 interrupt status register bits can be cleared in one of two ways: either by reading from the register, or by writing a 1 to the appropriate bit(s) in the register. This behavior can be altered at any time by the <twlmodule>_SIH_CTRL.COR register bit ("clear-on-read"). The TWL4030 TRM is deeply confused as to whether COR=1 means that the registers are cleared on reads, or cleared on writes. Peter De Schrijver <peter.de-schrijver> confirms that COR=1 means that the registers are cleared on read. So, for each TWL4030 SIH, check the value of the *_SIH_CTRL.COR bit, and if it is 1, use reads to clear the ISRs; if it is 0, use writes. Also, use WARN_ON() to warn if the read/write failed, and don't skip the rest of the initialization on failure either. Thanks to Peter for his help with this patch. Signed-off-by: Paul Walmsley <paul@pwsan.com> Signed-off-by: Tony Lindgren <tony@atomide.com>
-
Paul Walmsley authored
twl_init_irq() does not clear MADC interrupt status registers upon init - fix. Signed-off-by: Paul Walmsley <paul@pwsan.com> Signed-off-by: Tony Lindgren <tony@atomide.com>
-
Paul Walmsley authored
The existing code to mask and clear BCI interrupts in twl_init_irq() is wrong. It uses the wrong register offsets, it does not mask all of the BCI IMR registers, and it does not clear all of the BCI ISR registers. Signed-off-by: Paul Walmsley <paul@pwsan.com> Signed-off-by: Tony Lindgren <tony@atomide.com>
-
Paul Walmsley authored
twl_init_irq() does not clear the TWL GPIO ISR registers, but the PIH ISR thinks that it has. This causes any previously-latched GPIO interrupts to be stuck on until twl4030-gpio.c initializes, often drowning the console in TWL4030 module irq 368 is disabled but can't be masked! messages. This seems to be a particular problem when booting on Beagle. Signed-off-by: Paul Walmsley <paul@pwsan.com> Signed-off-by: Tony Lindgren <tony@atomide.com>
-
Paul Walmsley authored
twl_irq_init() clears PWR interrupt status bits, then masks the interrupts off, then clears the PWR interrupt status bits again. The first clear seems unnecessary, so, remove it. Signed-off-by: Paul Walmsley <paul@pwsan.com> Signed-off-by: Tony Lindgren <tony@atomide.com>
-
- 23 Jun, 2008 1 commit
-
-
Felipe Balbi authored
When built as module, it helps udev to probe them. Signed-off-by: Felipe Balbi <felipe.balbi@nokia.com> Signed-off-by: Tony Lindgren <tony@atomide.com>
-
- 14 May, 2008 1 commit
-
-
Felipe Balbi authored
Small cleanup to beautify /proc/interrupts. Signed-off-by: Felipe Balbi <felipe.balbi@nokia.com> Signed-off-by: Tony Lindgren <tony@atomide.com>
-
- 06 May, 2008 1 commit
-
-
Steve Sakoman authored
Set twl4030 irq number based upon cpu type rather than requiring #define in board.h files Signed-off-by: Steve Sakoman <steve@sakoman.com> Signed-off-by: Tony Lindgren <tony@atomide.com>
-
- 23 Apr, 2008 1 commit
-
-
Tony Lindgren authored
If boards with different NR_IRQS are compiled together, tons of compiler warnings are emitted about redefining NR_IRQS. This patch fixes the problem by adding up NR_IRQS in a common place. Patch also removes quite a bit of now unnecessary code. Signed-off-by: Tony Lindgren <tony@atomide.com>
-
- 11 Apr, 2008 3 commits
-
-
Felipe Balbi authored
twl4030_i2c_write_u8 expects a u8 variable. Change ctrl to be u8 in power_companion_init(). Signed-off-by: Felipe Balbi <felipe.balbi@nokia.com> Signed-off-by: Tony Lindgren <tony@atomide.com>
-
Felipe Balbi authored
Get rid of some sparse warnings in twl4030 driver. Signed-off-by: Felipe Balbi <felipe.balbi@nokia.com> Signed-off-by: Tony Lindgren <tony@atomide.com>
-
Felipe Balbi authored
Misc cleanup patch. Signed-off-by: Felipe Balbi <felipe.balbi@nokia.com> Signed-off-by: Tony Lindgren <tony@atomide.com>
-
- 02 Apr, 2008 1 commit
-
-
Tony Lindgren authored
Change error to warning for twl4030 clock init Signed-off-by: Tony Lindgren <tony@atomide.com>
-
- 01 Apr, 2008 1 commit
-
-
Tony Lindgren authored
Without this patch twl4030 clock can get programmed to incorrect rate which can eventually hang twl4030 reads. Also minor formatting fixes. Signed-off-by: Tony Lindgren <tony@atomide.com>
-
- 31 Mar, 2008 2 commits
-
-
Tony Lindgren authored
This reverts commit 621bce23. This patch killed twl4030 interrupts. Signed-off-by: Tony Lindgren <tony@atomide.com>
-
Tony Lindgren authored
For some reason doing a twl4030 write-read cycle can hang the I2C bus on omap3430. And doing the write and read separately in twl4030_i2c_read() seems to fix the problem. Signed-off-by: Tony Lindgren <tony@atomide.com>
-
- 28 Mar, 2008 3 commits
-
-
Felipe Balbi authored
General cleanup in twl4030-core.c Signed-off-by: Felipe Balbi <felipe.balbi@nokia.com> Signed-off-by: Tony Lindgren <tony@atomide.com>
-
Felipe Balbi authored
Rename to use the name style. Signed-off-by: Felipe Balbi <felipe.balbi@nokia.com> Signed-off-by: Tony Lindgren <tony@atomide.com>
-
Felipe Balbi authored
Now that we have this directory we can use it. Signed-off-by: Felipe Balbi <felipe.balbi@nokia.com> Signed-off-by: Tony Lindgren <tony@atomide.com>
-
- 18 Dec, 2007 2 commits
-
-
Felipe Balbi authored
Avoids declaring local variables used only once in the function. This preserve a register allocation thus avoiding extra MOVs from happening. Signed-off-by: Felipe Balbi <felipe.lima@indt.org.br> Signed-off-by: Tony Lindgren <tony@atomide.com>
-
Felipe Balbi authored
Making code more compliant to CodingStyle, also remove unneeded goto clauses in twl_init_irq. goto's will generate extra branch instructions before exiting from the function; instead, exits earlier to avoid such branch instructions. Signed-off-by: Felipe Balbi <felipe.lima@indt.org.br> Signed-off-by: Tony Lindgren <tony@atomide.com>
-
- 23 Nov, 2007 1 commit
-
-
Felipe Balbi authored
pr_err definition was moved to include/linux/kernel.h it's unecessary keeping that in twl4030_core.c Signed-off-by: Felipe Balbi <felipe.lima@indt.org.br> Signed-off-by: Tony Lindgren <tony@atomide.com>
-
- 10 Aug, 2007 2 commits
-
-
Kevin Hilman authored
This is not used outside twl4030, make it static. Signed-off-by: Kevin Hilman <khilman@mvista.com> Signed-off-by: Tony Lindgren <tony@atomide.com>
-
Syed Mohammed, Khasim authored
Patch to cleanup few spellings in TWL4030 Core and export TWLGPIO APIs Signed-off-by: Syed Mohammed Khasim <x0khasim@ti.com> Signed-off-by: Tony Lindgren <tony@atomide.com>
-