1. 03 Apr, 2009 40 commits
    • Evgeniy Polyakov's avatar
      Staging: dst: kconfig update. · cac22275
      Evgeniy Polyakov authored
      On Wed, Jan 14, 2009 at 02:05:33AM +0300, Evgeniy Polyakov (zbr@ioremap.net) wrote:
      > --- /dev/null
      > +++ b/drivers/staging/dst/Kconfig
      > @@ -0,0 +1,71 @@
      > +config DST
      > +	tristate "Distributed storage"
      > +	depends on NET && CRYPTO && SYSFS
      > +	select CONNECTOR
      > +	select LIBCRC32C
      
      Above is not needed.
      Signed-off-by: default avatarEvgeniy Polyakov <zbr@ioremap.net>
      Cc: Randy Dunlap <randy.dunlap@oracle.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
      
      cac22275
    • Evgeniy Polyakov's avatar
      9539bec7
    • Greg Kroah-Hartman's avatar
      staging: dst: replace bus_id with dev_set_name · fdc4f2e9
      Greg Kroah-Hartman authored
      bus_id is going away, use the dev_set_name() function instead.
      
      Cc: Kay Sievers <kay.sievers@vrfy.org>
      Cc: Evgeniy Polyakov <zbr@ioremap.net>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
      fdc4f2e9
    • Evgeniy Polyakov's avatar
      Staging: dst: crypto processing. · 1c93d9cf
      Evgeniy Polyakov authored
      DST may fully encrypt the data channel in case of untrusted channel and implement
      strong checksum of the transferred data. It is possible to configure algorithms
      and crypto keys, they should match on both sides of the network channel.
      Crypto processing does not introduce noticeble performance overhead, since DST
      uses configurable pool of threads to perform crypto processing.
      
      This patch introduces crypto processing helpers and crypto engine initialization:
      glueing with the crypto layer, allocation and initialization of the crypto
      processing thread pool, allocation of the cached pages, which are used to temporary
      encrypt data into, since it is forbidden to encrypt data in-place, since pages
      are used by the higher layers.
      Signed-off-by: default avatarEvgeniy Polyakov <zbr@ioremap.net>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
      1c93d9cf
    • Evgeniy Polyakov's avatar
      Staging: dst: transactions. · a0fde6e0
      Evgeniy Polyakov authored
      DST uses transaction model, when each store has to be explicitly acked
      from the remote node to be considered as successfully written. There
      may be lots of in-flight transactions. When remote host does not ack
      the transaction it will be resent predefined number of times with specified
      timeouts between them. All those parameters are configurable. Transactions
      are marked as failed after all resends completed unsuccessfully, having
      long enough resend timeout and/or large number of resends allows not to
      return error to the higher (FS usually) layer in case of short network
      problems or remote node outages. In case of network RAID setup this means
      that storage will not degrade until transactions are marked as failed, and
      thus will not force checksum recalculation and data rebuild. In case of
      connection failure DST will try to reconnect to the remote node automatically.
      DST sends ping commands at idle time to detect if remote node is alive.
      
      Because of transactional model it is possible to use zero-copy sending
      without worry of data corruption (which in turn could be detected by the
      strong checksums though).
      
      Transactions are handled in this patch: allocation/freeing/completion,
      scanning for stall and to-be-resent transactions and overall management
      of the storing tree.
      Signed-off-by: default avatarEvgeniy Polyakov <zbr@ioremap.net>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
      a0fde6e0
    • Evgeniy Polyakov's avatar
      Staging: dst: thread pool. · 6694b31a
      Evgeniy Polyakov authored
      Kernel currently does not allow to queue work into some entity which
      will perform it in the process context and have simple way to extend
      number of worker and work with them not as separate objects, but with
      pool as a whole. So thread pool model was implemented in the DST.
      
      Thread pool abstraction allows to schedule a work to be performed
      on behalf of kernel thread. One does not operate with threads itself,
      instead user provides setup and cleanup callbacks for thread pool itself,
      and action and cleanup callbacks for each submitted work.
      
      Each worker has private data initialized at creation time and data,
      provided by user at scheduling time.
      
      When action is being performed, thread can not be used by other users,
      instead they will sleep until there is free thread to pick their work.
      
      Thread pool is used for crypto processing of incoming and outgoing IO
      requests to reduce the overall overhead.
      Signed-off-by: default avatarEvgeniy Polyakov <zbr@ioremap.net>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
      6694b31a
    • Evgeniy Polyakov's avatar
      Staging: dst: export node. · 03b55b9d
      Evgeniy Polyakov authored
      This patch introduces remote (export) node machinery: initialization
      address/port (and other socket parameters), export block device (can be
      another DST storage for example or local device like /dev/sda1), local
      IO processing engine (BIO state machines, receiving/submitting logic).
      Network management for the export node like accepting new client, scheduling
      its command processing thread, receiving/sending IO requests, all are placed
      here.
      Signed-off-by: default avatarEvgeniy Polyakov <zbr@ioremap.net>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
      03b55b9d
    • Evgeniy Polyakov's avatar
      Staging: dst: network state machine. · a2376185
      Evgeniy Polyakov authored
      Each DST device contains of two nodes: local and remote (called also as export node).
      This patch contains local node processing engine: network state storage,
      socket processing loops and state machine, socket polling machinery, reconnection
      logic, send/receive basic helpers, related IO commands and so on.
      Signed-off-by: default avatarEvgeniy Polyakov <zbr@ioremap.net>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
      a2376185
    • Evgeniy Polyakov's avatar
      Staging: dst: core files. · ce0d9d72
      Evgeniy Polyakov authored
      This patch contains DST core files, which introduce
      block layer, connector and sysfs registration glue and main headers.
      
      Connector is used for the configuration of the node (its type, address,
      device name and so on). Sysfs provides bits of information about running
      devices in the following format:
      
      +/*
      + * DST sysfs tree for device called 'storage':
      + *
      + * /sys/bus/dst/devices/storage/
      + * /sys/bus/dst/devices/storage/type : 192.168.4.80:1025
      + * /sys/bus/dst/devices/storage/size : 800
      + * /sys/bus/dst/devices/storage/name : storage
      + */
      
      DST header contains structure definitions and protocol command description.
      Signed-off-by: default avatarEvgeniy Polyakov <zbr@ioremap.net>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
      ce0d9d72
    • David Täht's avatar
    • David Täht's avatar
    • David Täht's avatar
      Staging: frontier: Updated documentation · b3bc12da
      David Täht authored
      Signed-off-by: default avatarDavid Täht <d@teklibre.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
      b3bc12da
    • David Täht's avatar
      Staging: frontier: removed now unused frontier_compat.h file · 7f84642b
      David Täht authored
      Signed-off-by: default avatarDavid Täht <d@teklibre.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
      
      index 00450e6..0000000
      7f84642b
    • David Täht's avatar
    • David Täht's avatar
    • Peter Teoh's avatar
      Staging: rt2870: Removal of kernel_thread() API · d44ca7af
      Peter Teoh authored
      Replacing the use of kernel_thread() with kthread_run().   But as
      kthread_run() returned a task structure, as compared with
      kernel_thread() returning a PID, it was found to be more efficient to
      store the task structure pointer as a field data instead of PID
      pointer.   On top of modifying the field to store task structure
      pointer, the initialization of the field (assigned to
      THREAD_PID_INIT_VALUE) was also found unnecessary - as no where it is
      found to be used.
      Signed-off-by: default avatarPeter Teoh <htmldeveloper@gmail.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
      d44ca7af
    • Josef Jiru's avatar
      Staging: rt2870: add Linksys WUSB600N device id · a955dc39
      Josef Jiru authored
      Updated usb device list to support Linksys WUSB600N wireless adapter
      Signed-off-by: default avatarJosef Jiru <josef.jiru@gmx.net>
      
      a955dc39
    • Mark Einon's avatar
      Staging: rt2860: Remove dependency on CFLAG RT2860 · bdc0a173
      Mark Einon authored
      Removed the CFLAG RT2860 from Makefile and dependency on it in the driver code.
      Signed-off-by: default avatarMark Einon <mark.einon@gmail.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
      bdc0a173
    • Mark Einon's avatar
      Staging: rt2860: Fix remaining build warnings · f72c4bf5
      Mark Einon authored
      Fixed remaining four build warnings in drivers/staging/rt2860/:
      
      drivers/staging/rt2860/common/mlme.c:900: warning: format ‘%d’ expects type ‘int’, but argument 2 has type ‘ULONG’
      drivers/staging/rt2860/common/rtmp_init.c:2049: warning: ‘Value’ may be used uninitialized in this function
      drivers/staging/rt2860/sta_ioctl.c:361: warning: ‘return’ with a value, in function returning void
      drivers/staging/rt2860/sta_ioctl.c:2468: warning: ‘return’ with a value, in function returning void
      Signed-off-by: default avatarMark Einon <mark.einon@gmail.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
      f72c4bf5
    • Adam McDaniel's avatar
      Staging: rt2860: Ported v1.7.1.1 changes into v1.8.0.0, becoming v1.8.1.1 · ed291e80
      Adam McDaniel authored
      Staging: rt2860: Ported v1.7.1.1 changes into v1.8.0.0, becoming v1.8.1.1
      
      When RaLink released rt2860 v1.7.0.0, it lacked proper support for both WEP
      and WPA/WPA2 encryption. Either was possible, but the module had to be
      compiled to support only one or the other, never both.
      
      Since the EeePC was the most common device with this hardware (and these
      users were complaining to RaLink that WPA/WPA2 encryption didn't work)
      RaLink released a fix as an "eeepc-specific" version of this driver, v1.7.1.1
      
      Unfortunately, when v1.8.0.0 was released, this WPA/WPA2 fix was never
      included.
      
      What complicates things further is that RaLink has no interest in
      continuing work on this Linux driver for their hardware.
      
      This commit ports the changes introduced in v1.7.1.1 into the v1.8.0.0
      release, upgrading the kernel's module to v1.8.1.1
      Signed-off-by: default avatarAdam McDaniel <adam@array.org>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
      ed291e80
    • Randy Dunlap's avatar
      Staging: rt2860: fix printk format warnings · f4b44e76
      Randy Dunlap authored
      Fix staging/rt28x0 printk format warnings:
      
      linux-next-20090209/drivers/staging/rt2860/common/spectrum.c:1599: warning: format '%d' expects type 'int', but argument 3 has type 'long unsigned int'
      linux-next-20090209/drivers/staging/rt2860/rt_linux.c:857: warning: format '%d' expects type 'int', but argument 3 has type 'long unsigned int'
      
      linux-next-20090209/drivers/staging/rt2870/common/spectrum.c:1598: warning: format '%d' expects type 'int', but argument 3 has type 'long unsigned int'
      linux-next-20090209/drivers/staging/rt2870/rt_linux.c:898: warning: format '%d' expects type 'int', but argument 3 has type 'long unsigned int'
      Signed-off-by: default avatarRandy Dunlap <randy.dunlap@oracle.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
      f4b44e76
    • Pekka Enberg's avatar
      Staging: rt2860: remove kernel version compatibility wrappers · 7f20a18d
      Pekka Enberg authored
      The driver is in mainline now so there's no point in keeping the
      kernel version compatibility wrappers around.
      Signed-off-by: default avatarPekka Enberg <penberg@cs.helsinki.fi>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
      7f20a18d
    • Julia Lawall's avatar
      Staging: rt2860,rt2870: Correct use of ! and & · 7034ca4d
      Julia Lawall authored
      IW_ENCODE_MODE is 0xF000 and thus !erq->flags & IW_ENCODE_MODE is always 0.
      I assume that !(erq->flags & IW_ENCODE_MODE) was intended.
      
      The semantic patch that makes this change is as follows:
      (http://www.emn.fr/x-info/coccinelle/)
      
      // <smpl>
      @@ expression E; constant C; @@
      (
        !E & !C
      |
      - !E & C
      + !(E & C)
      )
      // </smpl>
      Signed-off-by: default avatarJulia Lawall <julia@diku.dk>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
      
      7034ca4d
    • Greg Kroah-Hartman's avatar
      Staging: rtl8187se: fix \r\n line ends · 88adc104
      Greg Kroah-Hartman authored
      Andrew pointed out that I forgot to convert some files to unix format
      when adding them originally.  This patch runs dos2unix on the rtl8187se
      files that needed them.
      Reported-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
      88adc104
    • Roel Kluin's avatar
      Staging: rtl8187se: ! x & y problem in inactive code · 9c515551
      Roel Kluin authored
      Fix ! x & y problem in inactivated code
      Signed-off-by: default avatarRoel Kluin <roel.kluin@gmail.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
      9c515551
    • Herton Ronaldo Krzesinski's avatar
      Staging: rtl8187se: fix build warnings · b318a3a6
      Herton Ronaldo Krzesinski authored
      drivers/staging/rtl8187se/r8180_wx.c:1386: warning: initialization from incompatible pointer type
      drivers/staging/rtl8187se/r8180_wx.c:1388: warning: initialization from incompatible pointer type
      Signed-off-by: default avatarHerton Ronaldo Krzesinski <herton@mandriva.com.br>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
      b318a3a6
    • Randy Dunlap's avatar
      Staging: rtl8187se: fix printk format warnings · 4913affd
      Randy Dunlap authored
      Fix staging/rtl8187se printk format warnings:
      
      drivers/staging/rtl8187se/ieee80211/ieee80211_wx.c:845: warning: format '%d' expects type 'int', but argument 2 has type 'size_t'
      drivers/staging/rtl8187se/ieee80211/ieee80211_wx.c:852: warning: format '%d' expects type 'int', but argument 2 has type 'size_t'
      Signed-off-by: default avatarRandy Dunlap <randy.dunlap@oracle.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
      4913affd
    • Randy Dunlap's avatar
      Staging: Android: fix more printk formats · bdd345d8
      Randy Dunlap authored
      Fix more android ram_console printk format warnings:
      
      drivers/staging/android/ram_console.c:238: warning: format '%d' expects type 'int', but argument 3 has type 'size_t'
      drivers/staging/android/ram_console.c:238: warning: format '%d' expects type 'int', but argument 4 has type 'size_t'
      Signed-off-by: default avatarRandy Dunlap <randy.dunlap@oracle.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
      bdd345d8
    • Randy Dunlap's avatar
      Staging: android: ram_console: fix printk format warning · 7fce9399
      Randy Dunlap authored
      Fix android printk format warnings:
      
      linux-next-20090209/drivers/staging/android/ram_console.c:228: warning: format '%d' expects type 'int', but argument 3 has type 'size_t'
      linux-next-20090209/drivers/staging/android/ram_console.c:228: warning: format '%d' expects type 'int', but argument 4 has type 'size_t'
      linux-next-20090209/drivers/staging/android/ram_console.c:326: warning: format '%x' expects type 'unsigned int', but argument 2 has type 'size_t'
      linux-next-20090209/drivers/staging/android/ram_console.c:326: warning: format '%x' expects type 'unsigned int', but argument 3 has type 'size_t'
      Signed-off-by: default avatarRandy Dunlap <randy.dunlap@oracle.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
      7fce9399
    • Randy Dunlap's avatar
      Staging: android: binder: fix printk format warnings · 45eb7ae1
      Randy Dunlap authored
      Fix printk format warnings in android binder:
      
      drivers/staging/android/binder.c:2652: warning: format '%lx' expects type 'long unsigned int', but argument 7 has type 'pgprotval_t'
      drivers/staging/android/binder.c:2659: warning: format '%lx' expects type 'long unsigned int', but argument 7 has type 'pgprotval_t'
      drivers/staging/android/binder.c:2680: warning: format '%lx' expects type 'long unsigned int', but argument 7 has type 'pgprotval_t'
      Signed-off-by: default avatarRandy Dunlap <randy.dunlap@oracle.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
      45eb7ae1
    • Alexander Beregalov's avatar
      Staging: otus: remove old irqreturn_t definition · c8bfbd5d
      Alexander Beregalov authored
      See commit bedd30d9 (genirq: make irqreturn_t an enum)
      Signed-off-by: default avatarAlexander Beregalov <a.beregalov@gmail.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
      c8bfbd5d
    • Dragoslav Zaric's avatar
    • Dragoslav Zaric's avatar
      Staging: otus: ioctl.c: Fix Coding Style · aef911a5
      Dragoslav Zaric authored
      I run make on ioctl.c file and I got two warnings:
      drivers/staging/otus/ioctl.c: In function ¡usbdrv_wpa_ioctl¢:
      drivers/staging/otus/ioctl.c:2269: warning: ISO C90 forbids mixed declarations and code
      drivers/staging/otus/ioctl.c: In function ¡usbdrv_ioctl¢:
      drivers/staging/otus/ioctl.c:2448: warning: ISO C90 forbids mixed declarations and code
      
      From: Dragoslav Zaric <dragoslav.zaric.kd@gmail.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
      aef911a5
    • Randy Dunlap's avatar
      Staging: otus: fix mixed declarations · 0009e125
      Randy Dunlap authored
      Fix otus ISO C90 warnings:
      
      drivers/staging/otus/80211core/cmmsta.c:740: warning: ISO C90 forbids mixed declarations and code
      drivers/staging/otus/80211core/coid.c:219: warning: ISO C90 forbids mixed declarations and code
      drivers/staging/otus/80211core/coid.c:1437: warning: ISO C90 forbids mixed declarations and code
      drivers/staging/otus/hal/hprw.c:33: warning: ISO C90 forbids mixed declarations and code
      drivers/staging/otus/hal/hprw.c:53: warning: ISO C90 forbids mixed declarations and code
      drivers/staging/otus/hal/hprw.c:82: warning: ISO C90 forbids mixed declarations and code
      drivers/staging/otus/hal/hprw.c:163: warning: ISO C90 forbids mixed declarations and code
      drivers/staging/otus/hal/hprw.c:219: warning: ISO C90 forbids mixed declarations and code
      drivers/staging/otus/hal/hprw.c:831: warning: ISO C90 forbids mixed declarations and code
      drivers/staging/otus/hal/hprw.c:896: warning: ISO C90 forbids mixed declarations and code
      drivers/staging/otus/hal/hpmain.c:332: warning: ISO C90 forbids mixed declarations and code
      drivers/staging/otus/hal/hpmain.c:1329: warning: ISO C90 forbids mixed declarations and code
      drivers/staging/otus/hal/hpmain.c:1565: warning: ISO C90 forbids mixed declarations and code
      drivers/staging/otus/hal/hpmain.c:1606: warning: ISO C90 forbids mixed declarations and code
      drivers/staging/otus/hal/hpmain.c:1923: warning: ISO C90 forbids mixed declarations and code
      drivers/staging/otus/hal/hpmain.c:1997: warning: ISO C90 forbids mixed declarations and code
      drivers/staging/otus/hal/hpmain.c:2264: warning: ISO C90 forbids mixed declarations and code
      drivers/staging/otus/hal/hpmain.c:2296: warning: ISO C90 forbids mixed declarations and code
      drivers/staging/otus/hal/hpmain.c:2330: warning: ISO C90 forbids mixed declarations and code
      drivers/staging/otus/hal/hpmain.c:2350: warning: ISO C90 forbids mixed declarations and code
      drivers/staging/otus/hal/hpmain.c:2387: warning: ISO C90 forbids mixed declarations and code
      drivers/staging/otus/hal/hpmain.c:2425: warning: ISO C90 forbids mixed declarations and code
      drivers/staging/otus/hal/hpmain.c:4223: warning: ISO C90 forbids mixed declarations and code
      drivers/staging/otus/hal/hpmain.c:4283: warning: ISO C90 forbids mixed declarations and code
      drivers/staging/otus/hal/hpmain.c:4314: warning: ISO C90 forbids mixed declarations and code
      drivers/staging/otus/hal/hpmain.c:4380: warning: ISO C90 forbids mixed declarations and code
      drivers/staging/otus/hal/hpmain.c:4425: warning: ISO C90 forbids mixed declarations and code
      drivers/staging/otus/hal/hpmain.c:4531: warning: ISO C90 forbids mixed declarations and code
      drivers/staging/otus/hal/hpmain.c:4539: warning: ISO C90 forbids mixed declarations and code
      drivers/staging/otus/hal/hpusb.c:69: warning: ISO C90 forbids mixed declarations and code
      drivers/staging/otus/hal/hpusb.c:334: warning: ISO C90 forbids mixed declarations and code
      drivers/staging/otus/hal/hpusb.c:580: warning: ISO C90 forbids mixed declarations and code
      drivers/staging/otus/hal/hpreg.c:1774: warning: ISO C90 forbids mixed declarations and code
      drivers/staging/otus/hal/hpreg.c:2478: warning: ISO C90 forbids mixed declarations and code
      drivers/staging/otus/hal/hpani.c:61: warning: ISO C90 forbids mixed declarations and code
      drivers/staging/otus/hal/hpani.c:80: warning: ISO C90 forbids mixed declarations and code
      drivers/staging/otus/hal/hpani.c:145: warning: ISO C90 forbids mixed declarations and code
      drivers/staging/otus/hal/hpani.c:352: warning: ISO C90 forbids mixed declarations and code
      drivers/staging/otus/hal/hpani.c:393: warning: ISO C90 forbids mixed declarations and code
      drivers/staging/otus/hal/hpani.c:472: warning: ISO C90 forbids mixed declarations and code
      drivers/staging/otus/hal/hpani.c:517: warning: ISO C90 forbids mixed declarations and code
      drivers/staging/otus/hal/hpani.c:592: warning: ISO C90 forbids mixed declarations and code
      drivers/staging/otus/hal/hpani.c:633: warning: ISO C90 forbids mixed declarations and code
      Signed-off-by: default avatarRandy Dunlap <randy.dunlap@oracle.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
      0009e125
    • Julia Lawall's avatar
      Staging: otus: use USB API functions rather than constants · d0fe1911
      Julia Lawall authored
      This set of patches introduces calls to the following set of functions:
      
      usb_endpoint_dir_in(epd)
      usb_endpoint_dir_out(epd)
      usb_endpoint_is_bulk_in(epd)
      usb_endpoint_is_bulk_out(epd)
      usb_endpoint_is_int_in(epd)
      usb_endpoint_is_int_out(epd)
      usb_endpoint_num(epd)
      usb_endpoint_type(epd)
      usb_endpoint_xfer_bulk(epd)
      usb_endpoint_xfer_control(epd)
      usb_endpoint_xfer_int(epd)
      usb_endpoint_xfer_isoc(epd)
      
      In some cases, introducing one of these functions is not possible, and it
      just replaces an explicit integer value by one of the following constants:
      
      USB_ENDPOINT_XFER_BULK
      USB_ENDPOINT_XFER_CONTROL
      USB_ENDPOINT_XFER_INT
      USB_ENDPOINT_XFER_ISOC
      
      An extract of the semantic patch that makes these changes is as follows:
      (http://www.emn.fr/x-info/coccinelle/)
      
      // <smpl>
      @r1@ struct usb_endpoint_descriptor *epd; @@
      
      - ((epd->bmAttributes & \(USB_ENDPOINT_XFERTYPE_MASK\|3\)) ==
      - \(USB_ENDPOINT_XFER_CONTROL\|0\))
      + usb_endpoint_xfer_control(epd)
      
      @r5@ struct usb_endpoint_descriptor *epd; @@
      
      - ((epd->bEndpointAddress & \(USB_ENDPOINT_DIR_MASK\|0x80\)) ==
      -  \(USB_DIR_IN\|0x80\))
      + usb_endpoint_dir_in(epd)
      
      @inc@
      @@
      
      #include <linux/usb.h>
      
      @depends on !inc && (r1||r5)@
      @@
      
      + #include <linux/usb.h>
        #include <linux/usb/...>
      // </smpl>
      Signed-off-by: default avatarJulia Lawall <julia@diku.dk>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
      d0fe1911
    • Roel Kluin's avatar
      Staging: otus: logical/bit and confusion · 1472dc9b
      Roel Kluin authored
      fix logical/bit and confusion
      Signed-off-by: default avatarRoel Kluin <roel.kluin@gmail.com>
      Cc: <lrodriguez@atheros.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
      1472dc9b
    • Randy Dunlap's avatar
      Staging: mimio: depends on INPUT · 5e6a9adb
      Randy Dunlap authored
      mimio driver uses input_* functions so it needs to depend on INPUT.
      
      mimio.c:(.text+0x2526c9): undefined reference to `input_unregister_device'
      mimio.c:(.text+0x2526da): undefined reference to `input_close_device'
      mimio.c:(.text+0x252725): undefined reference to `input_free_device'
      mimio.c:(.text+0x2528f1): undefined reference to `input_event'
      mimio.c:(.text+0x252904): undefined reference to `input_event'
      mimio.c:(.text+0x252921): undefined reference to `input_event'
      mimio.c:(.text+0x252b3e): undefined reference to `input_event'
      mimio.c:(.text+0x252b51): undefined reference to `input_event'
      drivers/built-in.o:mimio.c:(.text+0x252bbd): more undefined references to `input_event' follow
      mimio.c:(.text+0x252e42): undefined reference to `input_allocate_device'
      mimio.c:(.text+0x2530ef): undefined reference to `input_register_device'
      Signed-off-by: default avatarRandy Dunlap <randy.dunlap@oracle.com>
      Cc: mwilder@cs.nmsu.edu
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
      5e6a9adb
    • Randy Dunlap's avatar
      Staging: altera: fix printk format warnings · a5c281cb
      Randy Dunlap authored
      Fix printk format warnings in altera pcie chdma:
      
      drivers/staging/altpciechdma/altpciechdma.c:429: warning: format '%08x' expects type 'unsigned int', but argument 3 has type 'dma_addr_t'
      drivers/staging/altpciechdma/altpciechdma.c:433: warning: format '%08x' expects type 'unsigned int', but argument 3 has type 'dma_addr_t'
      drivers/staging/altpciechdma/altpciechdma.c:449: warning: format '%08x' expects type 'unsigned int', but argument 3 has type 'dma_addr_t'
      drivers/staging/altpciechdma/altpciechdma.c:450: warning: format '%08x' expects type 'unsigned int', but argument 3 has type 'dma_addr_t'
      Signed-off-by: default avatarRandy Dunlap <randy.dunlap@oracle.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
      a5c281cb
    • Eric Sesterhenn's avatar
      Staging: et131x: list usage cleanup · c9a312f1
      Eric Sesterhenn authored
      Trivial cleanup, list_del(); list_add_tail() is equivalent
      to list_move_tail(). Semantic patch for coccinelle can be
      found at www.cccmz.de/~snakebyte/list_move_tail.spatch
      Signed-off-by: default avatarEric Sesterhenn <snakebyte@gmx.de>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
      c9a312f1
    • Wei Yongjun's avatar
      Staging: usbip: kmem_cache_alloc/memset -> kmem_cache_zalloc · e68f2849
      Wei Yongjun authored
      Used kmem_cache_zalloc instead of kmem_cache_alloc/memset.
      Signed-off-by: default avatarWei Yongjun <yjwei@cn.fujitsu.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
      e68f2849