- 19 Dec, 2008 11 commits
-
-
Anton Vorontsov authored
No need to call ucc_geth_memclean() so many times, just check for errors in ucc_geth_open(), and call ucc_geth_stop() in case of errors. The ucc_geth_stop() may be called anytime and will do the right thing. Signed-off-by:
Anton Vorontsov <avorontsov@ru.mvista.com> Signed-off-by:
David S. Miller <davem@davemloft.net>
-
Anton Vorontsov authored
open() routine calls stop() in case of errors, the function will try to free the requested IRQ. But we don't know if it was actually requested, so the code might issue bogus free_irq(0, dev) call. Fix this by rearranging the code so that now request_irq() is the last call in the open() routine, and move free_irq() into the close(). Signed-off-by:
-
Anton Vorontsov authored
The timeout handling code is currently broken in several ways: - It calls stop() (which frees all the memory and IRQ), and then calls startup() (which won't re-request IRQ, neither it will re-init the Fast UCC structure). - It calls these routines from the softirq context, which is wrong, since stop() calls free_irq() (which might sleep) and startup() allocates things with GFP_KERNEL. - It won't soft-reset the PHY. We need the PHY reset for at least MPC8360E-MDS boards with Marvell 88E1111 PHY, the PHY won't recover from timeouts w/o the reset. So the patch fixes these problems by implementing the workqueue for the timeout handling, and there we fully re-open the device via close() and open() calls. The close/open paths do the right things, and I can see that the driver actually survive the timeouts. Signed-off-by:
-
Anton Vorontsov authored
Currently the routines wait for the various bits w/o an assumption that bits may never get set. When timeouts happen I see that these bits never get set and so the routines hang the kernel. With this patch we'll wait the graceful stop for 100 ms, and then will simply exit. There is nothing* we can do about that, but it's OK since we'll do full reset later. * Well, actually, there is also not-graceful variant for the TX stop, but specs says that we never should use it. Signed-off-by:
-
Matt Mackall authored
The original message was unhelpful and extremely alarming to our poor users, despite its charm. Make it less frightening. Signed-off-by:
Matt Mackall <mpm@selenic.com> Signed-off-by:
-
Jesper Dangaard Brouer authored
Optimize the lightly loaded case, by only synchronizing discards stats when qlen > 10 indicate potential for drops. Notice Robert Olsson might disagree with this patch. Signed-off-by:
Jesper Dangaard Brouer <hawk@comx.dk> Signed-off-by:
-
Jesper Dangaard Brouer authored
Discard packet counter debug statements that can be turned on at runtime by users to assist debugging of the driver code. Signed-off-by:
-
Jesper Dangaard Brouer authored
Implementing discard counters for the NIU driver turned out to be more complicated than first assumed. The discard counters for the NIU neptune chip are only 16-bit (even though this is a 64-bit chip). These 16-bit counters can overflow quickly, especially considering this is a 10Gbit/s ethernet card. The overflow indication bit is, unfortunatly, not usable as the counter value does not wrap, but remains at max value 0xFFFF. Resulting in lost counts until the counter is reset. The read and reset scheme also poses a problem. Both in theory and in practice counters can be lost in between reading nr64() and clearing the counter nw64(). For this reason, the number of counter clearings nw64() is limited/reduced. On the fast-path the counters are only syncronized once it exceeds 0x7FFF. When read by userspace, its syncronized fully. Signed-off-by:
-
Baruch Siach authored
A major source of overhead in the enc28j60 driver is the SPI transfers. Each SPI transfer entails two kernel thread context switches. One major source of SPI transfers is the enc28j60_set_bank() functions which runs before every register access. This patch reduces the number of SPI transfers that enc28j60_set_bank() performs in two ways: 1. removes unnecessary bank switch for the registers that are present in all banks 2. when switching from banks 0 or 3 to banks 1 or 2 (i.e. only one bit changes) enc28j60_set_bank() does only one SPI transfer instead of two According to my tests these changes reduce the number of SPI transfers in about 25%. Signed-off-by:
Baruch Siach <baruch@tkos.co.il> Signed-off-by:
-
Wang Chen authored
| commit 3d29b0c3 | Author: John W. Linville <linville@tuxdriver.com> | Date: Fri Oct 31 14:13:12 2008 -0400 | | netdevice zd1201: Convert directly reference of netdev->priv to netdev_priv() | | We have some reasons to kill netdev->priv: | 1. netdev->priv is equal to netdev_priv(). | 2. netdev_priv() wraps the calculation of netdev->priv's offset, obviously | netdev_priv() is more flexible than netdev->priv. | But we cann't kill netdev->priv, because so many drivers reference to it | directly. | | OK, becasue Dave S. Miller said, "every direct netdev->priv usage is a bug", | and I want to kill netdev->priv later, I decided to convert all the direct | reference of netdev->priv first. | | (Original patch posted by Wang Chen <wangchen@cn.fujitsu.com> w/ above | changelog but using dev->ml_priv. That doesn't seem appropriate | to me for this driver, so I've revamped it to use netdev_priv() | instead. -- JWL) This commit changed the allocation of netdev, but didn't change the free method of it. This causes "zd" be used after the memory, which is pointed by "zd", being freed by free_netdev(). Signed-off-by:
Wang Chen <wangchen@cn.fujitsu.com> Signed-off-by:
-
David S. Miller authored
This reverts commit e061b165. Signed-off-by:
-
- 18 Dec, 2008 16 commits
-
-
David S. Miller authored
This reverts commit 70355602. As pointed out by Mark McLoughlin IP_PKTINFO cmsg data is one post-queueing user, so this optimization is not valid right now. Signed-off-by:
-
Holger Eitzenberger authored
Signed-off-by:
Holger Eitzenberger <holger@eitzenberger.org> Signed-off-by:
-
Holger Eitzenberger authored
I also removed some of the unneeded braces in the if condition to improve readability and a little bit of reformatting. Signed-off-by:
-
Holger Eitzenberger authored
Signed-off-by:
-
Holger Eitzenberger authored
They are all defined before used, it's therefore ok to remove them. Signed-off-by:
-
Holger Eitzenberger authored
Signed-off-by:
-
Holger Eitzenberger authored
Also remove the pointless comment at the top. Signed-off-by:
-
Holger Eitzenberger authored
It helps in maintaining the various partner information values from the LACPDU. It also removes the pointless comment at the top. Signed-off-by:
-
Holger Eitzenberger authored
It generally helps to handle those values in various places, using it might make the code more readable and gives room for other improvements. The IEEE standard talks about them as "parameter values". Signed-off-by:
-
Holger Eitzenberger authored
The previous code was just a funny way of assigning both values (they are both of type u8). Signed-off-by:
-
Andy Fleming authored
gfar_poll would declare polling done once the rx queue was empty, but the tx queue could still have packets left. Stolen mostly from the e1000 driver. Signed-off-by:
Andy Fleming <afleming@freescale.com> Signed-off-by:
-
Dai Haruki authored
No clean up function is executed in the interrupt context by this patch. Signed-off-by:
Dai Haruki <dai.haruki@freescale.com> Acked-by:
-
Dai Haruki authored
Interface name (ex. eth0) is used as the prefix for the interrupt name, with _rx, _tx, and _er appended to distinguish multiple interrupts on the same interface. Signed-off-by:
-
Dai Haruki authored
Scatter Gather support in gianfar driver to handle fragmented frames on the transmit side. Signed-off-by:
Poonam Aggrwal <poonam.aggrwal@freescale.com> Signed-off-by:
-
Andy Fleming authored
The patch which fixed gianfar so it drops packets when it runs out of memory left in the code which frees the skb when it drops packets. Change the code so that we only free the skb if the new skb was successfully created. Signed-off-by:
-
Arnaldo Carvalho de Melo authored
And thus when we try to use 'ss -danemi' on these sockets that have no ccid blocks (data collected using systemtap after I fixed the problem): dccp_diag_get_info sk=0xffff8801220a3100, dp->dccps_hc_rx_ccid=0x0000000000000000, dp->dccps_hc_tx_ccid=0x0000000000000000 We get an OOPS: mica.ghostprotocols.net login: BUG: unable to handle kernel NULL pointer dereferenc0 IP: [<ffffffffa0136082>] dccp_diag_get_info+0x82/0xc0 [dccp_diag] PGD 12106f067 PUD 122488067 PMD 0 Oops: 0000 [#1] PREEMPT Fix is trivial, and 'ss -d' is working again: [root@mica ~]# ss -danemi State Recv-Q Send-Q Local Address:Port Peer Address:Port LISTEN 0 0 *:5001 *:* ino:7288 sk:220a3100ffff8801 mem:(r0,w0,f0,t0) cwnd:0 ssthresh:0 [root@mica ~]# Signed-off-by:
Arnaldo Carvalho de Melo <acme@redhat.com> Signed-off-by:
-
- 17 Dec, 2008 11 commits
-
-
Rémi Denis-Courmont authored
This implements the Nokia vendor-specific communication device class function to exchange Phonet messages over USB. This function is already found in the "PC suite" USB profile of (non-Linux) Nokia handsets. Signed-off-by:
Rémi Denis-Courmont <remi.denis-courmont@nokia.com> Signed-off-by:
-
Rémi Denis-Courmont authored
Signed-off-by:
-
Rémi Denis-Courmont authored
GPRS TX flow control won't need to lock the underlying socket anymore. Signed-off-by:
-
Rémi Denis-Courmont authored
A separate xmit lock class supports GPRS over a Phonet pipe over a TUN device (type ARPHRD_NONE). Signed-off-by:
-
Rémi Denis-Courmont authored
Also leave some room for more 802.11 types. Signed-off-by:
-
Oliver Hartkopp authored
Signed-off-by:
Oliver Hartkopp <oliver@hartkopp.net> Signed-off-by:
-
Cyrill Gorcunov authored
Use idr technique instead of own implemented cardmaps. It saves us a number of lines and gives an ability to use library functions. Signed-off-by:
Cyrill Gorcunov <gorcunov@openvz.org> Signed-off-by:
-
David S. Miller authored
These are now defined in linux/mii.h and the bnx2x driver defines different values which are shared with hardware data structures. So add a "BNX2X_" prefix to these macro names. Based upon a report from Stephen Rothwell. Signed-off-by: -
David S. Miller authored
They are provided generically by linux/mii.h now. Signed-off-by: -
Michael Chan authored
And fix the 5716S pci_device_id entry to point to the proper string. Signed-off-by:
Michael Chan <mchan@broadcom.com> Signed-off-by:
-
Michael Chan authored
Change MSI-X vector names to "ethx-%d". Signed-off-by:
Benjamin Li <benli@broadcom.com> Signed-off-by:
-
- 16 Dec, 2008 2 commits
-
-
Julia Lawall authored
In each case, if the NULL test is necessary, then the dereference should be moved below the NULL test. The semantic patch that makes this change is as follows: (http://www.emn.fr/x-info/coccinelle/) // <smpl> @@ type T; expression E; identifier i,fld; statement S; @@ - T i = E->fld; + T i; ... when != E when != i if (E == NULL) S + i = E->fld; // </smpl> Signed-off-by:
Julia Lawall <julia@diku.dk> Signed-off-by:
-
Andy Fleming authored
genphy_setup_forced hasn't actually reset the PHY for a long time, but a comment to that effect remained in the code, so code continued to act as if it *had* reset the PHY, and called the necessary fixup functions to respond to a PHY reset. With no reset, those functions are no longer needed, so we remove them. Signed-off-by:
-
