- 11 Apr, 2006 40 commits
-
-
NeilBrown authored
We're returning -1 in a few places in the NFSv4<->POSIX acl translation code where we could return a reasonable error. Also allows some minor simplification elsewhere. Signed-off-by:
J. Bruce Fields <bfields@citi.umich.edu> Signed-off-by:
Neil Brown <neilb@suse.de> Signed-off-by:
Andrew Morton <akpm@osdl.org> Signed-off-by:
Linus Torvalds <torvalds@osdl.org>
-
NeilBrown authored
this fixes coverity id #3. Coverity detected dead code, since the == -1 comparison only returns 0 or 1 to error. Therefore the if ( error < 0 ) statement was always false. Seems that this was an if( error = nfs4... ) statement some time ago, which got broken during cleanup. Signed-off-by:
Eric Sesterhenn <snakebyte@gmx.de> Signed-off-by:
-
Adrian Bunk authored
Signed-off-by:
Adrian Bunk <bunk@stusta.de> Cc: Marc Eshel <eshel@almaden.ibm.com> Cc: Andy Adamson <andros@citi.umich.edu> Cc: J. Bruce Fields <bfields@citi.umich.edu> Cc: Neil Brown <neilb@suse.de> Signed-off-by:
-
NeilBrown authored
Use the fl_lmops field to identify which locks are ours, instead of trying to look them up in our private hash. This is safer and more efficient. Earlier versions of this patch used a lock flag instead, but Trond pointed out that adding a new flag for each lock manager wasn't going to scale well, and suggested this approach instead; a separate patch converts lockd to using fl_lmops in the same way. In the NFSv4 case this looks like a bit of a hack, since the NFSv4 server isn't currently actually defining a lock_manager_operations struct, so we end up defining one *just* to serve as a cookie to identify our locks. But it works, and we actually do expect to start using the lock_manager_operations at some point anyway. Signed-off-by:
Marc Eshel <eshel@almaden.ibm.com> Signed-off-by:
Andy Adamson <andros@citi.umich.edu> Signed-off-by:
-
NeilBrown authored
NFSd makes sure there is enough space to hold the maximum possible reply before accepting a request. The units for this maximum is (4byte) words. However in three places, particularly for read request, the number given is a number of bytes. This means too much space is reserved which is slightly wasteful. This is the sort of patch that could uncover a deeper bug, and it is not critical, so it would be best for it to spend a while in -mm before going in to mainline. (akpm: target 2.6.17-rc2, 2.6.16.3 (approx)) Discovered-by:
"Eivind Sarto" <ivan@kasenna.com> Signed-off-by:
-
Adrian Bunk authored
CRC_CCITT is an internal helper function that should be select'ed. Signed-off-by:
Tilman Schmidt <tilman@imap.cc> Signed-off-by:
-
Adrian Bunk authored
Fix a memory leak spotted by the Coverity checker if (!try_module_get(owner)). Signed-off-by:
-
Adrian Bunk authored
- make the needlessly global gigaset_get_cs_by_tty() static - remove the unused EXPORT_SYMBOL_GPL(gigaset_debugdrivers) Signed-off-by:
-
Tilman Schmidt authored
With Hansjoerg Lipp <hjlipp@web.de> Replace some atomic_t variables in the Gigaset drivers by non-atomic ones, using spinlocks instead to assure atomicity, as proposed in discussions on the linux-kernel mailing list. Signed-off-by:
Hansjoerg Lipp <hjlipp@web.de> Signed-off-by:
-
Tilman Schmidt authored
With Hansjoerg Lipp <hjlipp@web.de> Add a README file for the Siemens Gigaset drivers to the Documentation/isdn directory. Signed-off-by:
-
Tilman Schmidt authored
With Hansjoerg Lipp <hjlipp@web.de> Remove four unnecessary forward function declarations and an obsolete E-mail address from the Siemens Gigaset drivers. Signed-off-by:
-
Tilman Schmidt authored
With Hansjoerg Lipp <hjlipp@web.de> Remove the private version of __skb_put() from the Siemens Gigaset drivers. Signed-off-by:
-
Tilman Schmidt authored
With Hansjoerg Lipp <hjlipp@web.de> Convert the semaphores used by the Gigaset drivers to mutexes. Signed-off-by:
-
Tilman Schmidt authored
With Hansjoerg Lipp <hjlipp@web.de> Eliminate the from_user argument from a debugging function, thus easing the job of sparse. Signed-off-by:
-
Tilman Schmidt authored
With Hansjoerg Lipp <hjlipp@web.de> Uninline a function which was slightly too big to warrant inlining. Signed-off-by:
-
Tilman Schmidt authored
With Hansjoerg Lipp <hjlipp@web.de> Remove the IFNULL debugging macros from the Gigaset drivers. Signed-off-by:
-
Tilman Schmidt authored
With Hansjoerg Lipp <hjlipp@web.de> Correct the way the Gigaset drivers create their sysfs entries. Signed-off-by:
-
Tilman Schmidt authored
With Hansjoerg Lipp <hjlipp@web.de> Improve error reporting of the Gigaset drivers, by using the dev_err/dev_warn/dev_info macros from device.h instead of err/warn/info from usb.h whereever possible. Also rename the private dbg macro to gig_dbg in order to avoid confusion with the macro of the same name in usb.h. Signed-off-by:
-
Tilman Schmidt authored
With Hansjoerg Lipp <hjlipp@web.de> Correct timer usage in the Gigaset drivers to take advantage of the existing setup_timer() function, and use milliseconds as unit. Signed-off-by:
-
Tilman Schmidt authored
With Hansjoerg Lipp <hjlipp@web.de> Remove the restriction to build the Gigaset drivers as modules only. Signed-off-by:
-
Tilman Schmidt authored
With Hansjoerg Lipp <hjlipp@web.de> Source code formatting cleanups for the Siemens Gigaset drivers, such as line length, comments, removal of unused declarations, and typo corrections. It does not introduce any functional changes. Signed-off-by:
-
Miklos Szeredi authored
The previous patch removed limiting the number of outstanding requests. This patch adds a much simpler limiting, that is also compatible with file locking operations. A task may have at most one synchronous request allocated. So these requests need not be otherwise limited. However the number of background requests (release, forget, asynchronous reads, interrupted requests) can grow indefinitely. This can be used by a malicous user to cause FUSE to allocate arbitrary amounts of unswappable kernel memory, denying service. For this reason add a limit for the number of background requests, and block allocations of new requests until the number goes bellow the limit. Also use this mechanism to block all requests until the INIT reply is received. Signed-off-by:
Miklos Szeredi <miklos@szeredi.hu> Signed-off-by:
-
Miklos Szeredi authored
FUSE allocated most requests from a fixed size pool filled at mount time. However in some cases (release/forget) non-pool requests were used. File locking operations aren't well served by the request pool, since they may block indefinetly thus exhausting the pool. This patch removes the request pool and always allocates requests on demand. Signed-off-by:
-
Miklos Szeredi authored
Return consistent error values for the case when the opened device file has no mount associated yet. Signed-off-by:
-
Miklos Szeredi authored
Remove the global spinlock in favor of a per-mount one. This patch is basically find & replace. The difficult part has already been done by the previous patch. Signed-off-by:
-
Miklos Szeredi authored
This is in preparation for removing the global spinlock in favor of a per-mount one. The only critical part is the interaction between fuse_dev_release() and fuse_fill_super(): fuse_dev_release() must see the assignment to file->private_data, otherwise it will leak the reference to fuse_conn. This is ensured by the fput() operation, which will synchronize the assignment with other CPU's that may do a final fput() soon after this. Also redundant locking is removed from fuse_fill_super(), where exclusion is already ensured by the BKL held for this function by the VFS. Signed-off-by:
-
Jeff Dike authored
I don't like duplicating the connected and list_empty tests in fuse_dev_readv, but this seemed cleaner than adding the f_flags test to request_wait. Signed-off-by:
Jeff Dike <jdike@addtoit.com> Signed-off-by:
-
Jeff Dike authored
This adds asynchronous notification to FUSE - a FUSE server can request O_ASYNC on a /dev/fuse file descriptor and receive SIGIO when there is input available. One subtlety - fuse_dev_fasync, which is called when O_ASYNC is requested, does no locking, unlink the other methods. I think it's unnecessary, as the fuse_conn.fasync list is manipulated only by fasync_helper and kill_fasync, which provide their own locking. It would also be wrong to use the fuse_lock, as it's a spin lock and fasync_helper can sleep. My one concern with this is the fuse_conn going away underneath fuse_dev_fasync - sys_fcntl takes a reference on the file struct, so this seems not to be a problem. Signed-off-by:
-
Miklos Szeredi authored
fuse_dev_poll() returned an error value instead of a poll mask. Luckily (or unluckily) -ENODEV does contain the POLLERR bit. There's also a race if filesystem is unmounted between fuse_get_conn() and spin_lock(), in which case this event will be missed by poll(). Signed-off-by:
-
Miklos Szeredi authored
During heavy parallel filesystem activity it was possible to Oops the kernel. The reason is that read_cache_pages() could skip pages which have already been inserted into the cache by another task. Occasionally this may result in zero pages actually being sent, while fuse_send_readpages() relies on at least one page being in the request. So check this corner case and just free the request instead of trying to send it. Reported and tested by Konstantin Isakov. Signed-off-by:
-
Alessandro Zummo authored
Clean up kconfig entry for the rtc-vr41xx. Signed-off-by:
Alessandro Zummo <a.zummo@towertech.it> Cc: Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp> Signed-off-by:
-
Yoichi Yuasa authored
This patch updates VR4100 series RTC driver. * This driver supports new RTC subsystem. * Simple set time/read time test worked fine. Signed-off-by:
Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp> Signed-off-by:
-
Alessandro Zummo authored
- convert printks to dev_xxx - remove messages in excess Signed-off-by:
-
Alessandro Zummo authored
Move registration error message from drivers to core. Signed-off-by:
-
Alessandro Zummo authored
Fix sysfs show() return code Signed-off-by:
-
Alessandro Zummo authored
Move the "24hr: yes" proc output from drivers to rtc proc code. This is required because the time value in the proc output is always in 24hr mode regardless of the driver. Signed-off-by:
-
Alessandro Zummo authored
- fix whitespace - remove some debugging in excess Signed-off-by:
-
Alessandro Zummo authored
Fix sysfs show() return code Signed-off-by:
-
Alessandro Zummo authored
- removed a duplicate error message - bumped driver version - removed some debugging messages in excess - refined the formatting - adjusted copyright notice Signed-off-by:
-
Kumar Gala authored
* Always enable the oscillator when we set the time * If the oscillator is disable when we probe the RTC report back a warning to the user * Added sysfs attribute to represent the state of the oscillator Signed-off-by:
Kumar Gala <galak@kernel.crashing.org> Signed-off-by:
-
