Skip to content

L
linux-davinci
Switch branch/tag
  1. 02 Mar, 2010 5 commits
    • Jean Delvare's avatar
      i2c: Add SMBus alert support · b5527a77
      Jean Delvare authored 
      SMBus alert support. The SMBus alert protocol allows several SMBus
slave devices to share a single interrupt pin on the SMBus master,
while still allowing the master to know which slave triggered the
interrupt.

This is based on preliminary work by David Brownell. The key
difference between David's implementation and mine is that his was
part of i2c-core, while mine is split into a separate, standalone
module named i2c-smbus. The i2c-smbus module is meant to include
support for all SMBus extensions to the I2C protocol in the future.

The benefit of this approach is a zero cost for I2C bus segments which
do not need SMBus alert support. Where David's implementation
increased the size of struct i2c_adapter by 7% (40 bytes on i386),
mine doesn't touch it. Where David's implementation added over 150
lines of code to i2c-core (+10%), mine doesn't touch it. The only
change that touches all the users of the i2c subsystem is a new
callback in struct i2c_driver (common to both implementations.) I seem
to remember Trent was worried about the footprint of David'd
implementation, hopefully mine addresses the issue.
Signed-off-by: default avatarJean Delvare <khali@linux-fr.org>
Acked-by: default avatarJonathan Cameron <jic23@cam.ac.uk>
Cc: David Brownell <dbrownell@users.sourceforge.net>
Cc: Trent Piepho <tpiepho@freescale.com>
      b5527a77
    • Jean Delvare's avatar
      i2c-parport: Give powered devices some time to settle · 6d376fcc
      Jean Delvare authored 
      When the i2c-parport adapter is reponsible for powering devices, it
would seem reasonable to give them some time to settle before trying
to access them.
Signed-off-by: default avatarJean Delvare <khali@linux-fr.org>
      6d376fcc
    • Jean Delvare's avatar
      i2c-tiny-usb: Fix a comment on bus frequency · c05d4902
      Jean Delvare authored 
      The description of the delay parameter is incomplete, it suggests that
there is a direct relation between the delay value and the bus
frequency. In fact, due to additional delays in the i2c bitbanging
code, the i2c clock is always much slower.
Signed-off-by: default avatarJean Delvare <khali@linux-fr.org>
Cc: Till Harbaum <Till@Harbaum.org>
      c05d4902
    • Seth Heasley's avatar
      i2c-i801: Add Intel Cougar Point device IDs · 39376434
      Seth Heasley authored 
      Add the Intel Cougar Point (PCH) SMBus controller device IDs.
Signed-off-by: default avatarSeth Heasley <seth.heasley@intel.com>
Signed-off-by: default avatarJean Delvare <khali@linux-fr.org>
      39376434
    • Márton Németh's avatar
      i2c: Make PCI device ids constant · 4111ecd2
      Márton Németh authored 
      The id_table field of the struct pci_driver is constant in <linux/pci.h>
so it is worth to make initialization data also constant.

The semantic match that finds this kind of pattern is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@r@
disable decl_init,const_decl_init;
identifier I1, I2, x;
@@
	struct I1 {
	  ...
	  const struct I2 *x;
	  ...
	};
@s@
identifier r.I1, y;
identifier r.x, E;
@@
	struct I1 y = {
	  .x = E,
	};
@c@
identifier r.I2;
identifier s.E;
@@
	const struct I2 E[] = ... ;
@depends on !c@
identifier r.I2;
identifier s.E;
@@
+	const
	struct I2 E[] = ...;
// </smpl>
Signed-off-by: default avatarMárton Németh <nm127@freemail.hu>
Cc: Julia Lawall <julia@diku.dk>
Signed-off-by: default avatarJean Delvare <khali@linux-fr.org>
      4111ecd2
  3. 01 Mar, 2010 35 commits