Skip to content

L
linux-davinci
Switch branch/tag
  1. 09 Feb, 2009 2 commits
    • David S. Miller's avatar
      sparc64: Fix probe_kernel_{read,write}(). · aeb39876
      David S. Miller authored 
      This is based upon a report from Chris Torek and his initial patch.
From Chris's report:

--------------------
This came up in testing kgdb, using the built-in tests -- turn
on CONFIG_KGDB_TESTS, then

    echo V1 > /sys/module/kgdbts/parameters/kgdbts

-- but it would affect using kgdb if you were debugging and looking
at bad pointers.
--------------------

When we get a copy_{from,to}_user() request and the %asi is set to
something other than ASI_AIUS (which is userspace) then we branch off
to a routine called memcpy_user_stub().  It just does a straight
memcpy since we are copying from kernel to kernel in this case.

The logic was that since source and destination are both kernel
pointers we don't need to have exception checks.

But for what probe_kernel_{read,write}() is trying to do, we have to
have the checks, otherwise things like kgdb bad kernel pointer
accesses don't do the right thing.
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      aeb39876
    • David S. Miller's avatar
      sparc64: Kill .fixup section bloat. · 40bdac7d
      David S. Miller authored 
      This is an implementation of a suggestion made by Chris Torek:
--------------------
Something else I noticed in passing: the EX and EX_LD/EX_ST macros
scattered throughout the various .S files make a fair bit of .fixup
code, all of which does the same thing.  At the cost of one symbol
in copy_in_user.S, you could just have one common two-instruction
retl-and-mov-1 fixup that they all share.
--------------------

The following is with a defconfig build:

   text	   data	    bss	    dec	    hex	filename
3972767	 344024	 584449	4901240	 4ac978	vmlinux.orig
3968887	 344024	 584449	4897360	 4aba50	vmlinux
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      40bdac7d
  3. 06 Feb, 2009 1 commit
  5. 04 Feb, 2009 37 commits