- 27 Feb, 2009 40 commits
-
-
Matt Carlson authored
Any software requesting NVRAM data as it exists on NVRAM is necessarily requesting that the results be returned as a bytestream. A bytestream data read in from the device can also be thought to be in big endian format. Therefore, all the LE notations in the driver are mislabeled. This patch converts all LE notations to BE notations, carefully evaluating the surrounding code in the process. Signed-off-by:
Matt Carlson <mcarlson@broadcom.com> Signed-off-by:
Benjamin Li <benli@broadcom.com> Signed-off-by:
Michael Chan <mchan@broadcom.com> Signed-off-by:
David S. Miller <davem@davemloft.net>
-
Matt Carlson authored
This patch removes the blind byteswap of NVRAM data as it is read in. To preserve the logic at the call sites, this patch also inverts every call to tg3_nvram_read() and tg3_nvram_read_swab(). The call swap gets confusing within tg3_nvram_read_le() (LE is a misnomer), but the reader should be able to convince himself / herself that the resulting behavior is still unchanged. Signed-off-by:
-
Matt Carlson authored
This patch moves all NVRAM routines earlier in the source file to eliminate forward declarations. Signed-off-by:
-
Matt Carlson authored
tg3_vlan_rx_register() touches the hardware if netif_running() returns false. This patch fixes the problem. Signed-off-by:
-
Matt Carlson authored
The ethtool interface has acquired some new enumerations since the tg3 driver's tg3_set_settings() error checking code was written. The error checking code is no longer complete. This patch rewrites the error checking so that it is future-proofed. Signed-off-by:
-
Matt Carlson authored
The hardware's MTU is configured so that it will accept packets whose VLAN tag is left inline. This means that the hardware will also accept other packets larger than the desired MTU size. This patch checks for and discards packets that are larger than the requested MTU but are not VLAN tagged frames. Signed-off-by:
-
Matt Carlson authored
Commit 6833c043 introduced the phy auto-powerdown capability. While the APD feature only works for 5761 and 5784 asic revisions, the (harmless portion of the) code was applied to all 5705 and newer devices. However, the 5906 phy departs from the usual design. This commit was interfering with the 5906's ability to negotiate link against some switches. This patch corrects the problem. Signed-off-by:
-
Hannes Eder authored
Impact: Attribute functions with __acquires(...) resp. __releases(...). Fix this sparse warnings: net/wanrouter/wanproc.c:82:13: warning: context imbalance in 'r_start' - wrong count at exit net/wanrouter/wanproc.c:103:13: warning: context imbalance in 'r_stop' - unexpected unlock net/wanrouter/wanmain.c:765:13: warning: context imbalance in 'lock_adapter_irq' - wrong count at exit net/wanrouter/wanmain.c:771:13: warning: context imbalance in 'unlock_adapter_irq' - unexpected unlock Signed-off-by:
Hannes Eder <hannes@hanneseder.net> Signed-off-by:
-
Hannes Eder authored
Impact: Attribute function with __releases(...) Fix this sparse warning: net/ipv4/inet_fragment.c:276:35: warning: context imbalance in 'inet_frag_find' - unexpected unlock Signed-off-by:
-
Hannes Eder authored
Impact: Remove redundant variable declarations, resp. rename inner scope variable. Fix this sparse warnings: net/decnet/af_decnet.c:1252:40: warning: symbol 'skb' shadows an earlier one net/decnet/af_decnet.c:1223:24: originally declared here net/decnet/af_decnet.c:1582:29: warning: symbol 'val' shadows an earlier one net/decnet/af_decnet.c:1527:22: originally declared here net/decnet/dn_dev.c:687:21: warning: symbol 'err' shadows an earlier one net/decnet/dn_dev.c:670:13: originally declared here net/decnet/sysctl_net_decnet.c:182:21: warning: symbol 'len' shadows an earlier one net/decnet/sysctl_net_decnet.c:173:16: originally declared here Signed-off-by:
-
Hannes Eder authored
Impact: Attribute functions with __acquires(...) resp. __releases(...). Fix this sparse warnings: net/decnet/dn_dev.c:1324:13: warning: context imbalance in 'dn_dev_seq_start' - wrong count at exit net/decnet/dn_dev.c:1366:13: warning: context imbalance in 'dn_dev_seq_stop' - unexpected unlock Signed-off-by:
-
Hannes Eder authored
Impact: Include header file. Fix this sparse warning: net/core/sysctl_net_core.c:123:32: warning: symbol 'net_core_path' was not declared. Should it be static? Signed-off-by:
-
Hannes Eder authored
Impact: Use 'static const char[]' instead of 'static char[]', and since the data is const now it can be placed in __initconst. Fix this warning: net/appletalk/ddp.c: In function 'atalk_init': net/appletalk/ddp.c:1894: warning: format not a string literal and no format arguments Signed-off-by:
-
Hannes Eder authored
Impact: Trust in the comment and add '__force' to the cast. Fix this sparse warning: net/9p/trans_fd.c:420:34: warning: cast adds address space to expression (<asn:1>) Signed-off-by:
-
Hannes Eder authored
Impact: Attribute function with __acquires(...) resp. __releases(...). Fix this sparse warnings: net/802/tr.c:492:21: warning: context imbalance in 'rif_seq_start' - wrong count at exit net/802/tr.c:519:13: warning: context imbalance in 'rif_seq_stop' - unexpected unlock Signed-off-by:
-
Wei Yongjun authored
Remove some pointless conditionals before kfree_skb(). Signed-off-by:
Wei Yongjun <yjwei@cn.fujitsu.com> Signed-off-by:
-
Wei Yongjun authored
Remove some pointless conditionals before kfree_skb(). Signed-off-by:
-
Wei Yongjun authored
Remove some pointless conditionals before kfree_skb(). Signed-off-by:
-
Wei Yongjun authored
Remove some pointless conditionals before kfree_skb(). Signed-off-by:
-
Wei Yongjun authored
Remove some pointless conditionals before kfree_skb(). Signed-off-by:
-
Wei Yongjun authored
Remove some pointless conditionals before kfree_skb(). Signed-off-by:
-
Wei Yongjun authored
Remove some pointless conditionals before kfree_skb(). Signed-off-by:
-
Wei Yongjun authored
Remove some pointless conditionals before kfree_skb(). Signed-off-by:
-
Wei Yongjun authored
Remove some pointless conditionals before kfree_skb(). Signed-off-by:
-
Wei Yongjun authored
Remove some pointless conditionals before kfree_skb(). Signed-off-by:
-
Wei Yongjun authored
Remove some pointless conditionals before kfree_skb(). Signed-off-by:
-
Wei Yongjun authored
Remove some pointless conditionals before kfree_skb(). Signed-off-by:
-
Wei Yongjun authored
Remove some pointless conditionals before kfree_skb(). Signed-off-by:
Jan "Yenya" Kasprzak <kas@fi.muni.cz> Signed-off-by:
-
Wei Yongjun authored
Remove some pointless conditionals before kfree_skb(). Signed-off-by:
-
Wei Yongjun authored
Remove some pointless conditionals before kfree_skb(). Signed-off-by:
-
Wei Yongjun authored
Remove some pointless conditionals before kfree_skb(). Signed-off-by:
-
Wei Yongjun authored
Remove some pointless conditionals before kfree_skb(). Signed-off-by:
-
Wei Yongjun authored
Remove some pointless conditionals before kfree_skb(). Signed-off-by:
-
Paulius Zaleckas authored
There is really no need for function just doing simple kfree() Signed-off-by:
Paulius Zaleckas <paulius.zaleckas@teltonika.lt> Cc: Denis Joseph Barrow <D.Barow@option.com> Signed-off-by:
-
Paulius Zaleckas authored
No need to reclaim the same USB interface beeing probed. Releasing interface does nothing also. This is already in for a long time in off-kernel hso driver and no regresions were noticed for this change. Signed-off-by:
-
Paulius Zaleckas authored
Local variable dev = ppp->dev Signed-off-by:
-
-
Greg Ungerer authored
Remove the ColdFire CPU specific setup from here. The ColdFire CPU platform code now sets up all this. Signed-off-by:
Greg Ungerer <gerg@uclinux.org> Signed-off-by:
-
Greg Ungerer authored
m68knommu: add FEC platform support to ColdFire CPU's setup code Move the per-CPU FEC driver setup code into the actual platform setup code for each ColdFire CPU varient. Signed-off-by:
-
Eric Sesterhenn authored
Trivial cleanup, list_del(); list_add_tail() is equivalent to list_move_tail(). Semantic patch for coccinelle can be found at www.cccmz.de/~snakebyte/list_move_tail.spatch Signed-off-by:
Eric Sesterhenn <snakebyte@gmx.de> Acked-by:
Karsten Keil <kkeil@novell.com> Signed-off-by:
-
