1. 18 Dec, 2008 1 commit
    • Arnaldo Carvalho de Melo's avatar
      dccp_diag: LISTEN sockets don't have CCIDs · a693722a
      Arnaldo Carvalho de Melo authored
      And thus when we try to use 'ss -danemi' on these sockets that have no
      ccid blocks (data collected using systemtap after I fixed the problem):
      
      dccp_diag_get_info sk=0xffff8801220a3100, dp->dccps_hc_rx_ccid=0x0000000000000000, dp->dccps_hc_tx_ccid=0x0000000000000000
      
      We get an OOPS:
      
      mica.ghostprotocols.net login: BUG: unable to handle kernel NULL pointer
      dereferenc0
      IP: [<ffffffffa0136082>] dccp_diag_get_info+0x82/0xc0 [dccp_diag]
      PGD 12106f067 PUD 122488067 PMD 0
      Oops: 0000 [#1] PREEMPT
      
      Fix is trivial, and 'ss -d' is working again:
      
      [root@mica ~]# ss -danemi
      State   Recv-Q Send-Q   Local Address:Port   Peer Address:Port 
      LISTEN  0      0                    *:5001              *:*
      ino:7288 sk:220a3100ffff8801
      	 mem:(r0,w0,f0,t0) cwnd:0 ssthresh:0
      [root@mica ~]# 
      Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      a693722a
  2. 17 Dec, 2008 11 commits
  3. 16 Dec, 2008 28 commits