1. 10 Dec, 2008 12 commits
  2. 09 Dec, 2008 24 commits
  3. 08 Dec, 2008 4 commits
    • Bartlomiej Zolnierkiewicz's avatar
      ide: build-fix for CONFIG_BLK_DEV_IDEDMA_PMAC=n · 53846574
      Bartlomiej Zolnierkiewicz authored
      IDE pmac host driver build fails with CONFIG_BLK_DEV_IDEDMA_PMAC=n
      as reported by Kamalesh:
      
      > drivers/ide/pmac.c: In function 'pmac_ide_set_pio_mode':
      > drivers/ide/pmac.c:527: error: implicit declaration of function 'kauai_lookup_timing'
      > drivers/ide/pmac.c:527: error: 'shasta_pio_timings' undeclared (first use in this function)
      > drivers/ide/pmac.c:527: error: (Each undeclared identifier is reported only once
      > drivers/ide/pmac.c:527: error: for each function it appears in.)
      > drivers/ide/pmac.c:534: error: 'kauai_pio_timings' undeclared (first use in this function)
      > drivers/ide/pmac.c: In function 'pmac_ide_do_resume':
      > drivers/ide/pmac.c:914: error: 'IDE_WAKEUP_DELAY' undeclared (first use in this function)
      > drivers/ide/pmac.c: At top level:
      > drivers/ide/pmac.c:1007: error: 'pmac_ide_init_dma' undeclared here (not in a function)
      > drivers/ide/pmac.c: In function 'pmac_ide_setup_device':
      > drivers/ide/pmac.c:1107: error: 'IDE_WAKEUP_DELAY' undeclared (first use in this function)
      > drivers/ide/pmac.c: In function 'pmac_ide_macio_attach':
      > drivers/ide/pmac.c:1209: error: 'pmac_ide_hwif_t' has no member named 'dma_regs'
      > drivers/ide/pmac.c:1210: error: 'pmac_ide_hwif_t' has no member named 'dma_regs'
      > make[2]: *** [drivers/ide/pmac.o] Error 1
      
      Fix it by removing the superfluous config option.
      Reported-and-tested-by: default avatarKamalesh Babulal <kamalesh@linux.vnet.ibm.com>
      Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
      Cc: Sergei Shtylyov <sshtylyov@ru.mvista.com>
      Cc: Stephen Rothwell <sfr@canb.auug.org.au>
      Signed-off-by: default avatarBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
      53846574
    • Bartlomiej Zolnierkiewicz's avatar
      Revert "ide: respect current DMA setting during resume" · 1a659880
      Bartlomiej Zolnierkiewicz authored
      This reverts commit e9eb8388 since
      it could break resume (thanks to Paul Collins for the report).
      
      I'll look into sorting this out properly for 2.6.29
      but for 2.6.28 it is the best to just revert my patch.
      Reported-by: default avatarPaul Collins <paul@burly.ondioline.org>
      Cc: rjw@sisk.pl
      Signed-off-by: default avatarBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
      1a659880
    • Ingo Molnar's avatar
      x86: fix default_spin_lock_flags() prototype · 087052b0
      Ingo Molnar authored
      these warnings:
      
        arch/x86/kernel/paravirt-spinlocks.c: In function ‘default_spin_lock_flags’:
        arch/x86/kernel/paravirt-spinlocks.c:12: warning: passing argument 1 of ‘__raw_spin_lock’ from incompatible pointer type
        arch/x86/kernel/paravirt-spinlocks.c: At top level:
        arch/x86/kernel/paravirt-spinlocks.c:11: warning: ‘default_spin_lock_flags’ defined but not used
      
      showed that the prototype of default_spin_lock_flags() was confused about
      what type spinlocks have.
      
      the proper type on UP is raw_spinlock_t.
      Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
      087052b0
    • Joerg Roedel's avatar
      AMD IOMMU: __unmap_single: check for bad_dma_address instead of 0 · b8d9905d
      Joerg Roedel authored
      Impact: minor fix
      Signed-off-by: default avatarJoerg Roedel <joerg.roedel@amd.com>
      b8d9905d