1. 22 May, 2007 4 commits
    • Darrick J. Wong's avatar
      [SCSI] aic94xx: asd_clear_nexus should fail if the cleared task does not complete · 8fdcf86a
      Darrick J. Wong authored
      Every so often, the driver will call asd_clear_nexus to clean out a task.
      It is supposed to be the case that the CLEAR NEXUS does not go on the done
      list until after the task itself has been put on the done list, but for
      some reason this doesn't always happen.  Thus, the
      wait_for_completion_timeout call times out, and we return success.  This
      makes libsas free the task even though the task hasn't completed, leading
      to a BUG_ON message from aic94xx_hwi.c around line 341.  We should return
      failure from asd_clear_nexus so that libsas tries again; at a bare minimum
      it shouldn't be freeing active tasks.  I _think_ this will fix one of
      the SCB timeout crash problems (though I've not been able to reproduce
      it lately...)
      Signed-off-by: default avatarDarrick J. Wong <djwong@us.ibm.com>
      Signed-off-by: default avatarJames Bottomley <James.Bottomley@SteelEye.com>
      8fdcf86a
    • James Bottomley's avatar
      [SCSI] aic7xxx: fix aicasm build failure with gcc-3.4.6 · f45ffaec
      James Bottomley authored
      On Tue, 2007-05-22 at 06:51 -0500, Bob Tracy wrote:
      > Second try: originally reported this back on April 17th.  2.6.X
      > kernel builds started failing after I upgraded my compiler from
      > gcc-3.3.X to gcc-3.4.6:
      >
      > make -C drivers/scsi/aic7xxx/aicasm
      > (...)
      > gcc -I/usr/include -I. aicasm.c aicasm_symbol.c aicasm_gram.c aicasm_macro_gram.c aicasm_scan.c aicasm_macro_scan.c -o aicasm -ldb
      > aicasm_gram.y:1948: error: conflicting types for 'yyerror'
      > aicasm_gram.tab.c:3004: error: previous implicit declaration of 'yyerror' was here
      > aicasm_macro_gram.y:162: error: conflicting types for 'mmerror'
      > aicasm_macro_gram.tab.c:1196: error: previous implicit declaration of 'mmerror' was here
      
      Fix is to add a prototype for yyerror and mmerror to the relevant files.
      Signed-off-by: default avatarJames Bottomley <James.Bottomley@SteelEye.com>
      f45ffaec
    • Salyzyn, Mark's avatar
      [SCSI] aacraid: apply commit config for reset_devices flag · 1208bab5
      Salyzyn, Mark authored
      Under some conditions associated with the unclean transition to kdump,
      the aacraid adapters will view the array as foreign and not export it to
      prevent access and data manipulation. The solution is to submit a commit
      configuration to export the devices since this is a expected behavior
      when transitioning to a kdump kernel.
      
      This patch adds the aacraid.reset_devices flag and when either this or
      the global reset_devices flag is set, ensures that a commit config is
      issued and extends the startup_timeout if it is set less than 5 minutes.
      Signed-off-by: default avatarMark Salyzyn <aacraid@adaptec.com>
      Signed-off-by: default avatarJames Bottomley <James.Bottomley@SteelEye.com>
      1208bab5
    • Alan Stern's avatar
      [SCSI] sd: fix refcounting regression in suspend/resume routines · 09ff92fe
      Alan Stern authored
      This patch (as909) fixes a couple of refcounting errors in the sd
      driver's suspend and resume methods.
      Signed-off-by: default avatarAlan Stern <stern@rowland.harvard.edu>
      Signed-off-by: default avatarJames Bottomley <James.Bottomley@SteelEye.com>
      09ff92fe
  2. 16 May, 2007 25 commits
  3. 15 May, 2007 11 commits