Skip to content

L
linux-davinci
Switch branch/tag
  1. 04 Aug, 2009 2 commits
  3. 03 Aug, 2009 1 commit
  5. 18 Jul, 2009 1 commit
  7. 24 Aug, 2009 2 commits
  9. 20 Aug, 2009 1 commit
  11. 24 Aug, 2009 1 commit
  13. 18 Jul, 2009 1 commit
  15. 01 Jul, 2009 1 commit
  17. 23 Jun, 2009 1 commit
  19. 09 Sep, 2009 1 commit
  21. 05 Sep, 2009 1 commit
  23. 27 Aug, 2009 1 commit
    • Anton Vorontsov's avatar
      RTC core won't allow wakeup alarms to be set if RTC devices' parent (i.e. · 49b1be8e
      Anton Vorontsov authored 
      i2c_client or spi_device) isn't wakeup capable.

For I2C devices there is I2C_CLIENT_WAKE flag exists that we can pass via
board info, and if set, I2C core will initialize wakeup capability.  For
SPI devices there is no such flag at all.

I believe that it's not platform code responsibility to allow or disallow
wakeups, instead, drivers themselves should set the capability if a device
can trigger wakeups.

That's what drivers/base/power/sysfs.c says:

 * It is the responsibility of device drivers to enable (or disable)
 * wakeup signaling as part of changing device power states, respecting
 * the policy choices provided through the driver model.

I2C and SPI RTC devices send wakeup events via interrupt lines, so we
should set the wakeup capability if IRQ is routed.

Ideally we should also check irq for wakeup capability before setting
device's capability, i.e.

	if (can_irq_wake(irq))
		device_set_wakeup_capable(&client->dev, 1);

But there is no can_irq_wake() call exist, and it is not that trivial to
implement it for all interrupts controllers and complex/cascaded setups.

drivers/base/power/sysfs.c also covers these cases:

 * Devices may not be able to generate wakeup events from all power
 * states.  Also, the events may be ignored in some configurations;
 * for example, they might need help from other devices that aren't
 * active

So there is no guarantee that wakeup will actually work, and so I think
there is no point in being pedantic wrt checking IRQ wakeup capability.
Signed-off-by: default avatarAnton Vorontsov <avorontsov@ru.mvista.com>
Cc: David Brownell <dbrownell@users.sourceforge.net>
Cc: Ben Dooks <ben-linux@fluff.org>
Cc: Jean Delvare <khali@linux-fr.org>
Cc: Alessandro Zummo <a.zummo@towertech.it>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      49b1be8e
  25. 02 Sep, 2009 1 commit
  27. 04 Aug, 2009 1 commit
  29. 03 Aug, 2009 1 commit
  31. 18 Aug, 2009 1 commit
  33. 29 Jun, 2009 1 commit
  35. 24 Aug, 2009 3 commits
  37. 29 Jun, 2009 1 commit
  39. 26 Jun, 2009 1 commit
  41. 24 Aug, 2009 1 commit
  43. 14 Jul, 2009 1 commit
  45. 26 Jun, 2009 2 commits
  47. 25 Jul, 2009 1 commit
  49. 21 Jul, 2009 1 commit
  51. 12 Sep, 2009 1 commit
  53. 02 Sep, 2009 5 commits
  55. 14 Aug, 2009 4 commits