1. 16 Oct, 2007 5 commits
    • Jens Axboe's avatar
      splice: fix double kunmap() in vmsplice copy path · 6866bef4
      Jens Axboe authored
      The out label should not include the unmap, the only way to jump
      there already has unmapped the source.
      
      00002000
             f7c21a00 00000000 00000000 c0489036 00018e32 00000002 00000000
      00001000
      Call Trace:
       [<c0487dd9>] pipe_to_user+0xca/0xd3
       [<c0488233>] __splice_from_pipe+0x53/0x1bd
       [<c0454947>] ------------[ cut here ]------------
      filemap_fault+0x221/0x380
       [<c0487d0f>] pipe_to_user+0x0/0xd3
       [<c0489036>] sys_vmsplice+0x3b7/0x422
       [<c045ec3f>] kernel BUG at mm/highmem.c:206!
      handle_mm_fault+0x4d5/0x8eb
       [<c041ed5b>] kmap_atomic+0x1c/0x20
       [<c045d33d>] unmap_vmas+0x3d1/0x584
       [<c045f717>] free_pgtables+0x90/0xa0
       [<c041d84b>] pgd_dtor+0x0/0x1
       [<c044d665>] audit_syscall_exit+0x2aa/0x2c6
       [<c0407817>] do_syscall_trace+0x124/0x169
       [<c0404df2>] syscall_call+0x7/0xb
       =======================
      Code: 2d 00 d0 5b 00 25 00 00 e0 ff 29 invalid opcode: 0000 [#1]
      c2 89 d0 c1 e8 0c 8b 14 85 a0 6c 7c c0 4a 85 d2 89 14 85 a0 6c 7c c0 74 07
      31 c9 4a 75 15 eb 04 <0f> 0b eb fe 31 c9 81 3d 78 38 6d c0 78 38 6d c0 0f
      95 c1 b0 01
      EIP: [<c045bbc3>] kunmap_high+0x51/0x8e SS:ESP 0068:f5960df0
      SMP
      Modules linked in: netconsole autofs4 hidp nfs lockd nfs_acl rfcomm l2cap
      bluetooth sunrpc ipv6 ib_iser rdma_cm ib_cm iw_cmib_sa ib_mad ib_core
      ib_addr iscsi_tcp libiscsi scsi_transport_iscsi dm_mirror dm_multipath
      dm_mod video output sbs batteryac parport_pc lp parport sg i2c_piix4
      i2c_core floppy cfi_probe gen_probe scb2_flash mtd chipreg tg3 e1000 button
      ide_cd serio_raw cdrom aic7xxx scsi_transport_spi sd_mod scsi_mod ext3 jbd
      ehci_hcd ohci_hcd uhci_hcd
      CPU:    3
      EIP:    0060:[<c045bbc3>]    Not tainted VLI
      EFLAGS: 00010246   (2.6.23 #1)
      EIP is at kunmap_high+0x51/0x8e
      Signed-off-by: default avatarJens Axboe <jens.axboe@oracle.com>
      6866bef4
    • Alan D. Brunelle's avatar
      Some IO scheduler cleanup in Documentation/block · 23c76983
      Alan D. Brunelle authored
      as-iosched.txt:
        o  Changed IO scheduler selection text to a reference to the
           switching-sched.txt file.
      
        o  Fixed typo: 'for up time...' -> 'for up to...'
      
        o  Added short description of the est_time file.
      
      deadline-iosched.txt:
        o  Changed IO scheduler selection text to a reference to the
           switching-sched.txt file.
      
        o  Removed references to non-existent seek-cost and stream_unit.
      
        o  Fixed typo: 'write_starved' -> 'writes_starved'
      
      switching-sched.txt:
        o  Added in boot-time argument to set the default IO scheduler. (From
           as-iosched.txt)
      
        o  Added in sysfs mount instructions. (From deadline-iosched.txt)
      Signed-off-by: default avatarAlan D. Brunelle <Alan.Brunelle@hp.com>
      Signed-off-by: default avatarJens Axboe <jens.axboe@oracle.com>
      23c76983
    • Rob Landley's avatar
      Update Jens Axboe's email in Documentation/* · 26bbb29a
      Rob Landley authored
      Jens Axboe's old email address bounces.
      Signed-off-by: default avatarRob Landley <rob@landley.net>
      Signed-off-by: default avatarJens Axboe <jens.axboe@oracle.com>
      26bbb29a
    • Jeff Garzik's avatar
      drivers/block/cpqarray,cciss: kill unused var · 87ad9001
      Jeff Garzik authored
      The recent bio work and subsequent fixups created unused variables.
      Signed-off-by: default avatarJeff Garzik <jgarzik@redhat.com>
      Signed-off-by: default avatarJens Axboe <jens.axboe@oracle.com>
      87ad9001
    • Arjan van de Ven's avatar
      bsg: mark struct file_operations const · 7344be05
      Arjan van de Ven authored
      struct file_operations is generally const (to avoid false sharing and get compile time errors on accidental writing to this shared structure); bsg recently added one of these without the const keyword. Patch below marks it const....
      Signed-off-by: default avatarArjan van de Ven <arjan@linux.intel.com>
      Signed-off-by: default avatarJens Axboe <jens.axboe@oracle.com>
      7344be05
  2. 15 Oct, 2007 35 commits