1. 24 Aug, 2009 1 commit
  2. 20 Aug, 2009 1 commit
  3. 04 Aug, 2009 2 commits
  4. 29 Jul, 2009 4 commits
  5. 17 Jul, 2009 1 commit
  6. 11 Aug, 2009 1 commit
  7. 02 Oct, 2008 2 commits
    • Harvey Harrison's avatar
      It would be easy to get rid of the typedefs too, but I kept this · 92821ff1
      Harvey Harrison authored
      minimal.
      
      Noticed by sparse:
      drivers/scsi/gdth.c:2395:31: warning: incorrect type in assignment (different base types)
      drivers/scsi/gdth.c:2395:31:    expected unsigned int [unsigned] [assigned] [usertype] last_block_no
      drivers/scsi/gdth.c:2395:31:    got restricted __be32 [usertype] <noident>
      drivers/scsi/gdth.c:2396:27: warning: incorrect type in assignment (different base types)
      drivers/scsi/gdth.c:2396:27:    expected unsigned int [unsigned] [assigned] [usertype] block_length
      drivers/scsi/gdth.c:2396:27:    got restricted __be32 [usertype] <noident>
      drivers/scsi/gdth.c:2406:33: warning: incorrect type in assignment (different base types)
      drivers/scsi/gdth.c:2406:33:    expected unsigned long long [unsigned] [usertype] last_block_no
      drivers/scsi/gdth.c:2406:33:    got restricted __be64 [usertype] <noident>
      drivers/scsi/gdth.c:2407:33: warning: incorrect type in assignment (different base types)
      drivers/scsi/gdth.c:2407:33:    expected unsigned int [unsigned] [usertype] block_length
      drivers/scsi/gdth.c:2407:33:    got restricted __be32 [usertype] <noident>
      Signed-off-by: default avatarHarvey Harrison <harvey.harrison@gmail.com>
      Cc: Boaz Harrosh <bharrosh@panasas.com>
      Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
      Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      92821ff1
    • Harvey Harrison's avatar
      Remove two now unnecessary local vars. · d9d28518
      Harvey Harrison authored
      Signed-off-by: default avatarHarvey Harrison <harvey.harrison@gmail.com>
      Cc: Boaz Harrosh <bharrosh@panasas.com>
      Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
      Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      d9d28518
  8. 13 May, 2008 1 commit
  9. 02 Sep, 2009 1 commit
  10. 12 Aug, 2009 1 commit
    • Andrew Morton's avatar
      WARNING: line over 80 characters · 53990e05
      Andrew Morton authored
      #29: FILE: include/linux/wait.h:80:
      +extern void __init_waitqueue_head(wait_queue_head_t *q, struct lock_class_key *);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      #56: FILE: kernel/wait.c:20:
      +EXPORT_SYMBOL(__init_waitqueue_head);
      
      total: 0 errors, 2 warnings, 31 lines checked
      
      ./patches/waitqueues-give-waitqueue-spinlocks-their-own-lockdep-classes.patch has style problems, please review.  If any of these errors
      are false positives report them to the maintainer, see
      CHECKPATCH in MAINTAINERS.
      
      Please run checkpatch prior to sending patches
      
      Cc: David Howells <dhowells@redhat.com>
      Cc: Ingo Molnar <mingo@elte.hu>
      Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
      Cc: Peter Zijlstra <peterz@infradead.org>
      Cc: Takashi Iwai <tiwai@suse.de>
      Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      53990e05
  11. 04 Aug, 2009 1 commit
  12. 24 Jul, 2009 1 commit
  13. 25 Aug, 2009 1 commit
  14. 04 Aug, 2009 1 commit
  15. 13 Jul, 2009 1 commit
  16. 07 Aug, 2009 1 commit
  17. 24 Aug, 2009 1 commit
  18. 05 Jun, 2009 1 commit
  19. 20 Feb, 2009 1 commit
  20. 05 Sep, 2009 2 commits
    • Jason Gunthorpe's avatar
      tpm_show_pubek is utterly and completely wrong, all the offsets into the · bdcca38c
      Jason Gunthorpe authored
      binary blob are wrong, the output is garbage.  Do it again.
      
      Before:
      Algorithm: 00 0C 00 00
      Encscheme: 08 00
      Sigscheme: 00 00
      Parameters: 00 00 00 00 01 00 AF 6B 30 9B 0D B3
      Modulus length: -1266846667
      Modulus:
      68 45 8D CA A5 EF A8 8A DD 0F D7 84 8E 8D 1F 40
      22 92 09 CF 12 C8 9F 6E 55 57 6A 2C A8 0B 5E 45
      C7 5E 3D 56 DA 64 E6 E1 F7 8C DD 41 92 28 2E 06
      41 02 3E 11 7D B2 C5 46 38 E5 8C 60 D2 96 EE 0C
      D6 3D F8 99 E3 02 3A 32 7A 02 C8 31 29 98 28 B9
      1B EF 30 A1 A0 45 A0 C0 05 0E C5 96 95 FD 91 47
      0A 35 E0 69 B0 8B 49 BD B9 F6 5D 25 21 25 79 1B
      20 0D C3 C7 1F 87 5E 5F 41 4B DE 32 DF 55 F3 BD
      7F CA D8 7D 3A B4 D5 0A EF CF 8E 72 20 52 15 FA
      FB C6 C0 2E C2 AB C6 07 D0 9D 96 6B 2E 30 F7 54
      C4 A5 CD 9B 13 54 A0 D1 71 66 91 97 06 12 B5 2D
      B2 33 62 FB 56 62 64 A8 AA E9 F2 F4 03 C3 F4 49
      2A 09 0D 7D 75 99 6C F0 47 1E 7D D5 A5 CA CE EF
      45 B2 DA 88 93 B4 EE EB FB B0 A6 A4 19 C4 B8 0D
      04 46 AE BD C5 2E 30 84 49 57 25 34 78 E6 ED C4
      50 AF 3B F6 86 43 54 0A D9 DB 54 9C 06 B3 50 7F
      
      After:
      Algorithm: 00 00 00 01
      Encscheme: 00 03
      Sigscheme: 00 01
      Parameters: 00 00 08 00 00 00 00 02 00 00 00 00
      Modulus length: 256
      Modulus:
      AF 6B 30 9B 0D B3 B4 7D 74 35 68 45 8D CA A5 EF
      A8 8A DD 0F D7 84 8E 8D 1F 40 22 92 09 CF 12 C8
      9F 6E 55 57 6A 2C A8 0B 5E 45 C7 5E 3D 56 DA 64
      E6 E1 F7 8C DD 41 92 28 2E 06 41 02 3E 11 7D B2
      C5 46 38 E5 8C 60 D2 96 EE 0C D6 3D F8 99 E3 02
      3A 32 7A 02 C8 31 29 98 28 B9 1B EF 30 A1 A0 45
      A0 C0 05 0E C5 96 95 FD 91 47 0A 35 E0 69 B0 8B
      49 BD B9 F6 5D 25 21 25 79 1B 20 0D C3 C7 1F 87
      5E 5F 41 4B DE 32 DF 55 F3 BD 7F CA D8 7D 3A B4
      D5 0A EF CF 8E 72 20 52 15 FA FB C6 C0 2E C2 AB
      C6 07 D0 9D 96 6B 2E 30 F7 54 C4 A5 CD 9B 13 54
      A0 D1 71 66 91 97 06 12 B5 2D B2 33 62 FB 56 62
      64 A8 AA E9 F2 F4 03 C3 F4 49 2A 09 0D 7D 75 99
      6C F0 47 1E 7D D5 A5 CA CE EF 45 B2 DA 88 93 B4
      EE EB FB B0 A6 A4 19 C4 B8 0D 04 46 AE BD C5 2E
      30 84 49 57 25 34 78 E6 ED C4 50 AF 3B F6 86 43
      
      I've checked this decoded output in two different ways.
      
      Tested on a winbond WPCT200
      Signed-off-by: default avatarJason Gunthorpe <jgunthorpe@obsidianresearch.com>
      Cc: Debora Velarde <debora@linux.vnet.ibm.com>
      Cc: Rajiv Andrade <srajiv@linux.vnet.ibm.com>
      Cc: Marcel Selhorst <m.selhorst@sirrix.com>
      Cc: James Morris <jmorris@namei.org>
      Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      bdcca38c
    • Jason Gunthorpe's avatar
      Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com> · 852c4ae8
      Jason Gunthorpe authored
      Cc: Debora Velarde <debora@linux.vnet.ibm.com>
      Cc: Rajiv Andrade <srajiv@linux.vnet.ibm.com>
      Cc: Marcel Selhorst <m.selhorst@sirrix.com>
      Cc: James Morris <jmorris@namei.org>
      Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      852c4ae8
  21. 03 Sep, 2009 1 commit
    • Jason Gunthorpe's avatar
      I'm testing the tpm_tis low level driver with a winbond WPCT200: · 5a4fe9c2
      Jason Gunthorpe authored
      $ cat caps
      Manufacturer: 0x57454300
      TCG version: 1.2
      Firmware version: 2.16
      
      and noted that tpm_pcr_read for the pcrs sysfile file does not function. 
      tpm_tis_recv returned with an error because the expected reply size was
      set to 14 (the request size) and the chip returned 30 bytes.
      
      The TCG spec says the reply size is supposed to be 30 bytes.
      
      The length input to transmit_cmd is the size of the reply, not of the
      request.  It should be 30 for READ_PCR.
      
      With this change my chip reports all 23 pcrs.
      
      Also, the BUILD_BUG_ON() is just wrong - it's testing a value which isn't
      a compile-time constant.  Simply remove that assertion.
      Signed-off-by: default avatarJason Gunthorpe <jgunthorpe@obsidianresearch.com>
      Cc: Debora Velarde <debora@linux.vnet.ibm.com>
      Cc: Rajiv Andrade <srajiv@linux.vnet.ibm.com>
      Cc: Marcel Selhorst <m.selhorst@sirrix.com>
      Cc: James Morris <jmorris@namei.org>
      Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      5a4fe9c2
  22. 13 Jul, 2009 1 commit
  23. 24 Aug, 2009 3 commits
  24. 12 Aug, 2009 1 commit
    • Andrew Morton's avatar
      ERROR: code indent should use tabs where possible · 6761544e
      Andrew Morton authored
      #20: FILE: drivers/net/zorro8390.c:124:
      +        return -ENODEV;$
      
      total: 1 errors, 0 warnings, 9 lines checked
      
      ./patches/zorro8390-fix-read-buffer-overflow-in-zorro8390_init_one.patch has style problems, please review.  If any of these errors
      are false positives report them to the maintainer, see
      CHECKPATCH in MAINTAINERS.
      
      Please run checkpatch prior to sending patches
      
      Cc: Roel Kluin <roel.kluin@gmail.com>
      Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      6761544e
  25. 24 Aug, 2009 2 commits
  26. 17 Aug, 2009 1 commit
  27. 06 Aug, 2009 1 commit
    • Randy Dunlap's avatar
      Fix netjet driver link errors when ISDN_I4L is not enabled: · 88f34576
      Randy Dunlap authored
      drivers/built-in.o: In function `mode_tiger':
      netjet.c:(.text+0x325dc8): undefined reference to `isdnhdlc_rcv_init'
      netjet.c:(.text+0x325dd5): undefined reference to `isdnhdlc_out_init'
      drivers/built-in.o: In function `fill_dma':
      netjet.c:(.text+0x325fb6): undefined reference to `isdnhdlc_encode'
      drivers/built-in.o: In function `read_dma':
      netjet.c:(.text+0x32631a): undefined reference to `isdnhdlc_decode'
      drivers/built-in.o: In function `nj_irq':
      netjet.c:(.text+0x326e01): undefined reference to `isdnhdlc_encode'
      
      or move isdnhdlc.c to some other sub-dir..
      Signed-off-by: default avatarRandy Dunlap <randy.dunlap@oracle.com>
      Cc: Karsten Keil <isdn@linux-pingi.de>
      Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      88f34576
  28. 04 Aug, 2009 1 commit
  29. 24 Aug, 2009 1 commit
  30. 20 Aug, 2009 2 commits
    • Sudhakar Rajashekhara's avatar
      Implement memory accessor interface in the MTD layer which enables the · 148a179a
      Sudhakar Rajashekhara authored
      kernel to access flash data.
      
      This patch adds two new members to the mtd_partition structure, a function
      handler which will be called during setup of the partition and an argument
      to be passed to this setup function.
      
      Example:
      +static struct mtd_partition spi_flash_partitions[] = {
      +       [0] = {
      +               .name       = "U-Boot",
      +               .offset     = 0,
      +               .size       = SZ_256K,
      +               .mask_flags = MTD_WRITEABLE,
      +       },
      +       [1] = {
      +               .name       = "U-Boot Environment",
      +               .offset     = MTDPART_OFS_NXTBLK,
      +               .size       = SZ_64K,
      +               .mask_flags = MTD_WRITEABLE,
      +       },
      +       [2] = {
      +               .name       = "Linux",
      +               .offset     = MTDPART_OFS_NXTBLK,
      +               .size       = SZ_7M,
      +               .mask_flags = 0,
      +       },
      +       [3] = {
      +               .name       = "MAC Address",
      +               .offset     = MTDPART_OFS_NXTBLK,
      +               .size       = SZ_64K,
      +               .mask_flags = 0,
      +               .setup      = davinci_get_mac_addr,
      +               .context    = (void *)0,
      +       },
      +};
      
      The davinci_get_mac_addr function reads the MAC address from
      offset ZERO of last MTD partition.
      Signed-off-by: default avatarSudhakar Rajashekhara <sudhakar.raj@ti.com>
      Cc: David Brownell <david-b@pacbell.net>
      Cc: David Woodhouse <dwmw2@infradead.org>
      Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      148a179a
    • Hiroshi Ito's avatar
      linux v2.6.31-rc6 can not detect NEC uPD29F064115. · f132d577
      Hiroshi Ito authored
      uPD29F064115 is a 16 bit device.
      datasheet:
        http://www.cn.necel.com/memory/cn/download/M16062EJ2V0DS00.pdf
      
      A problem and fix is described in the following commit, which in the main
      kernel tree, uPD29F064115 needs same fix.
      
      commit ca6f12c6
      Author: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
      Date:   Wed Jul 16 00:09:15 2008 +0900
      
          [MTD] jedec_probe: Fix SST 16-bit chip detection
      
          The unlock_addr rework in kernel 2.6.25 breaks 16-bit SST chips.  SST
          39LF160 and SST 39VF1601 are both 16-bit only chip (do not have BYTE#
          pin) and new uaddr value is not correct for them.  Add
          MTD_UADDR_0xAAAA_0x5555 for those chips.  Tested with SST 39VF1601
          chip.
      Signed-off-by: default avatarAtsushi Nemoto <anemo@mba.ocn.ne.jp>
      Signed-off-by: default avatarDavid Woodhouse <David.Woodhouse@intel.com>
      Signed-off-by: default avatarHiroshi Ito <ito@mlb.co.jp>
      Cc: David Woodhouse <dwmw2@infradead.org>
      Cc: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
      Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      f132d577