1. 21 Mar, 2009 21 commits
  2. 20 Mar, 2009 17 commits
  3. 19 Mar, 2009 2 commits
    • Tilman Schmidt's avatar
      bas_gigaset: correctly allocate USB interrupt transfer buffer · 170ebf85
      Tilman Schmidt authored
      Every USB transfer buffer has to be allocated individually by kmalloc.
      
      Impact: bugfix, no functional change
      Signed-off-by: default avatarTilman Schmidt <tilman@imap.cc>
      Tested-by: default avatarKolja Waschk <kawk@users.sourceforge.net>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      170ebf85
    • Steve Glendinning's avatar
      smsc911x: reset last known duplex and carrier on open · 44c1d6f9
      Steve Glendinning authored
      smsc911x_phy_adjust_link is called periodically by the phy layer (as
      it's run in polling mode), and it only updates the hardware when it sees
      a change in duplex or carrier.  This patch clears the last known values
      every time the interface is brought up, instead of only when the module
      is loaded.
      
      Without this patch the adjust_link function never updates the hardware
      after an ifconfig down; ifconfig up.  On a full duplex link this causes
      the tx error counter to increment, even though packets are correctly
      transmitted, as the default MAC_CR register setting is for half duplex.
      
      The tx errors are "no carrier" errors, which should be ignored in
      full-duplex mode.  When MAC_CR is set to "full duplex" mode they are
      correctly ignored by the hardware.
      
      Note that even with this patch the tx error counter can increment if
      packets are transmitted between "ifconfig up" and the first phy poll
      interval.  An improved solution would use the phy interrupt with phylib,
      but I haven't managed to make this work 100% robustly yet.
      Signed-off-by: default avatarSteve Glendinning <steve.glendinning@smsc.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      44c1d6f9