An error occurred fetching the project authors.
  1. 11 Mar, 2009 1 commit
  2. 06 Mar, 2009 1 commit
    • Cyrill Gorcunov's avatar
      x86: linkage.h - guard assembler specifics by __ASSEMBLY__ · 7ab15247
      Cyrill Gorcunov authored
      Stephen Rothwell reported:
      
      |Today's linux-next build (x86_64 allmodconfig) produced this warning:
      |
      |In file included from drivers/char/epca.c:49:
      |drivers/char/digiFep1.h:7:1: warning: "GLOBAL" redefined
      |In file included from include/linux/linkage.h:5,
      |                 from include/linux/kernel.h:11,
      |                 from arch/x86/include/asm/system.h:10,
      |                 from arch/x86/include/asm/processor.h:17,
      |                 from include/linux/prefetch.h:14,
      |                 from include/linux/list.h:6,
      |                 from include/linux/module.h:9,
      |                 from drivers/char/epca.c:29:
      |arch/x86/include/asm/linkage.h:55:1: warning: this is the location of the previous definition
      |
      |Probably introduced by commit 95695547
      |("x86: asm linkage - introduce GLOBAL macro") from the x86 tree.
      
      Any assembler specific snippets being placed in headers
      are to be protected by __ASSEMBLY__. Fixed.
      
      Also move __ALIGN definition under the same protection as well.
      Reported-by: default avatarStephen Rothwell <sfr@canb.auug.org.au>
      Signed-off-by: default avatarCyrill Gorcunov <gorcunov@openvz.org>
      LKML-Reference: <20090306160833.GB7420@localhost>
      Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
      7ab15247
  3. 19 Feb, 2009 2 commits
  4. 11 Feb, 2009 2 commits
  5. 23 Nov, 2008 1 commit
    • Cyrill Gorcunov's avatar
      x86: introduce ENTRY(KPROBE_ENTRY)_X86 assembly helpers to catch unbalanced declaration v3 · 3b6c52b5
      Cyrill Gorcunov authored
      Impact: make ENTRY()/END() macros more capable
      
      It's usefull to catch unbalanced or messed or mixed declarations of ENTRY and
      KPROBES. These macros would help a bit.
      
      For example the following code would compile without problems
      
              ENTRY_X86(mcount)
                      retq
              END_X86(mcount)
      
      But if you forget and mess the following form
      
              ENTRY_X86(mcount)
                      retq
              END(mcount)
      
              ENTRY_X86(ftrace_caller)
      
      The assembler will issue the following message:
      Error: ENTRY_X86/KPROBE_X86 unbalanced,missed,mixed
      
      Actually the checking is performed at every _X86 macro
      so maybe it's good idea to put ENTRY_KPROBE_FINAL_X86
      at the end of .S file to be sure you didn't miss anything.
      Signed-off-by: default avatarCyrill Gorcunov <gorcunov@gmail.com>
      Cc: Alexander van Heukelum <heukelum@mailshack.com>
      Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
      3b6c52b5
  6. 23 Oct, 2008 2 commits
  7. 22 Jul, 2008 1 commit
    • Vegard Nossum's avatar
      x86: consolidate header guards · 77ef50a5
      Vegard Nossum authored
      This patch is the result of an automatic script that consolidates the
      format of all the headers in include/asm-x86/.
      
      The format:
      
      1. No leading underscore. Names with leading underscores are reserved.
      2. Pathname components are separated by two underscores. So we can
         distinguish between mm_types.h and mm/types.h.
      3. Everything except letters and numbers are turned into single
         underscores.
      Signed-off-by: default avatarVegard Nossum <vegard.nossum@gmail.com>
      77ef50a5
  8. 17 Apr, 2008 1 commit
  9. 11 Apr, 2008 2 commits
    • Linus Torvalds's avatar
      Add commentary about the new "asmlinkage_protect()" macro · d10d89ec
      Linus Torvalds authored
      It's really a pretty ugly thing to need, and some day it will hopefully
      be obviated by teaching gcc about the magic calling conventions for the
      low-level system call code, but in the meantime we can at least add big
      honking comments about why we need these insane and strange macros.
      
      I took my comments from my version of the macro, but I ended up deciding
      to just pick Roland's version of the actual code instead (with his
      prettier syntax that uses vararg macros).  Thus the previous two commits
      that actually implement it.
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      d10d89ec
    • Roland McGrath's avatar
      asmlinkage_protect replaces prevent_tail_call · 54a01510
      Roland McGrath authored
      The prevent_tail_call() macro works around the problem of the compiler
      clobbering argument words on the stack, which for asmlinkage functions
      is the caller's (user's) struct pt_regs.  The tail/sibling-call
      optimization is not the only way that the compiler can decide to use
      stack argument words as scratch space, which we have to prevent.
      Other optimizations can do it too.
      
      Until we have new compiler support to make "asmlinkage" binding on the
      compiler's own use of the stack argument frame, we have work around all
      the manifestations of this issue that crop up.
      
      More cases seem to be prevented by also keeping the incoming argument
      variables live at the end of the function.  This makes their original
      stack slots attractive places to leave those variables, so the compiler
      tends not clobber them for something else.  It's still no guarantee, but
      it handles some observed cases that prevent_tail_call() did not.
      Signed-off-by: default avatarRoland McGrath <roland@redhat.com>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      54a01510
  10. 30 Jan, 2008 2 commits
  11. 11 Oct, 2007 1 commit