Commits · 55a5d291fd6235edaab2dad974b236adf2ffbeae · linux / linux-davinci

02 Feb, 2008 40 commits

ide-tape: remove IDETAPE_DEBUG_BUGS · 55a5d291

Borislav Petkov authored Feb 02, 2008

Signed-off-by: Borislav Petkov <bbpetkov@yahoo.de>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>

55a5d291

ide-tape: remove IDETAPE_DEBUG_INFO · f79f93a2

Borislav Petkov authored Feb 02, 2008

The device capabilities are probed for during device initialization so this
info is available through proc/ioctl() und it is redundant here.
Signed-off-by: Borislav Petkov <bbpetkov@yahoo.de>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>

f79f93a2

ide-tape: dump gcw fields on error in idetape_identify_device() · 16422de3
Bartlomiej Zolnierkiewicz authored Feb 02, 2008
```
Cc: Borislav Petkov <bbpetkov@yahoo.de>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
```
16422de3

ide-tape: remove struct idetape_mode_parameter_header_t · 47314fa4

Borislav Petkov authored Feb 02, 2008

Bart:
- remove 'capabilities->speed' chunk
- re-add brackets to block_descrp assignment
Signed-off-by: Borislav Petkov <bbpetkov@yahoo.de>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>

47314fa4

ide-tape: remove struct idetape_request_sense_result_t · 1b5db434

Borislav Petkov authored Feb 02, 2008

Bart:
- remove unnecessary comment change
- remove two needless "!!"
Signed-off-by: Borislav Petkov <bbpetkov@yahoo.de>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>

1b5db434

ide-tape: remove dead code · c7ea8a1b

Borislav Petkov authored Feb 02, 2008

Signed-off-by: Borislav Petkov <bbpetkov@yahoo.de>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>

c7ea8a1b

ide-tape: move historical changelog to Documentation/ide/ChangeLog.ide-tape.1995-2002 · 5ce78af4

Borislav Petkov authored Feb 02, 2008

Also, cleanup whitespace and update comments.

Bart:
- remove reference to drivers/block/ide.c
- move driver documentation to Documentation/ide/ide-tape.txt
Signed-off-by: Borislav Petkov <bbpetkov@yahoo.de>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>

5ce78af4

ide-cs: use ide_std_init_ports() · dcb425f5

Bartlomiej Zolnierkiewicz authored Feb 02, 2008

No reason to use ide_init_hwif_ports() in ide-cs (as a nice side-effect
this makes ide-cs work on archs that don't define IDE_ARCH_OBSOLETE_INIT).
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>

dcb425f5

ide: move check_dma_crc() to ide-dma.c · 578cfa0d

Bartlomiej Zolnierkiewicz authored Feb 02, 2008

* Move check_dma_crc() to ide-dma.c and add inline version for
  CONFIG_BLK_DEV_IDEDMA=n case.

* Rename check_dma_crc() to ide_check_dma_crc().
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>

578cfa0d

ide: remove ide_auto_reduce_xfer() · 296921a4

Bartlomiej Zolnierkiewicz authored Feb 02, 2008

While at it:

* Remove needless '!drive->crc_count' check.
Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>

296921a4

ide: move drive->crc_count check out from check_dma_crc() · 99ffbe0e
Bartlomiej Zolnierkiewicz authored Feb 02, 2008
```
Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
```
99ffbe0e

ide: remove ide_ata66_check() · af10f773

Bartlomiej Zolnierkiewicz authored Feb 02, 2008

Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>

af10f773

ide: remove set_transfer() · 5efe7c54

Bartlomiej Zolnierkiewicz authored Feb 02, 2008

Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>

5efe7c54

ide: unexport SELECT_DRIVE() · fa017176

Bartlomiej Zolnierkiewicz authored Feb 02, 2008

Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>

fa017176

ide-scsi: remove needless SELECT_DRIVE() call · 98d2a7aa

Bartlomiej Zolnierkiewicz authored Feb 02, 2008

SELECT_DRIVE() is called by IDE core code in start_request() before device
driver's ->do_request method. In ide-scsi case ->do_request is implemented
by idescsi_do_request() which is also the only user of idescsi_issue_pc().
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>

98d2a7aa

ide: use __ide_set_handler() in ide_execute_command() · 629f944b

Bartlomiej Zolnierkiewicz authored Feb 02, 2008

* Use __ide_set_handler() in ide_execute_command().

While at it:

* Fix whitespace damage in ide_execute_command().
Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>

629f944b

ide: remove SATA_*_REG macros · 835457de

Bartlomiej Zolnierkiewicz authored Feb 02, 2008

* siimage.c: use hwif->sata_scr[SATA_{ERROR,STATUS}_OFFSET] instead of
  SATA_{ERROR,STATUS}_REG macros.

* Remove no longer needed SATA_*_REG macros.

While at it:

* Remove needless SATA Status register read from sil_sata_reset_poll().
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>

835457de

ide: remove ->nice0 and ->nice2 fields from ide_drive_t · 92b83c8f

Bartlomiej Zolnierkiewicz authored Feb 02, 2008

* ->nice0 and ->nice2 ide_drive_t fields are always zero so remove them.

* IDE_NICE_0 and IDE_NICE_2 defines from <linux/hdreg.h> are no longer
  used by any kernel code so cover them with #ifndef/#endif __KERNEL__.
Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>

92b83c8f

ide: convert ->straight8 field in ide_hwif_t to bit flag · b034304a
Bartlomiej Zolnierkiewicz authored Feb 02, 2008
```
Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
```
b034304a

ide: remove unused ->auto_poll field from ide_hwif_t · b60acab1

Bartlomiej Zolnierkiewicz authored Feb 02, 2008

Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>

b60acab1

ide-probe: remove needless Status register reads · 57b55275

Bartlomiej Zolnierkiewicz authored Feb 02, 2008

* Cache value read from the Status register in 'stat' variable in do_probe()
  and enable_nest(), then remove remove needless Status register reads.

While at it:

* Add proper KERN_* levels to printk() calls.
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>

57b55275

ide-cris: use ide_execute_command() · b187dfee

Bartlomiej Zolnierkiewicz authored Feb 02, 2008

Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>

b187dfee

trm290: use ide_execute_command() · c78d7172

Bartlomiej Zolnierkiewicz authored Feb 02, 2008

Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>

c78d7172

ide-scsi: use ide_execute_command() · 2d6027f0

Bartlomiej Zolnierkiewicz authored Feb 02, 2008

Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>

2d6027f0

ide-tape: use ide_execute_command() · c1c9dbc8

Bartlomiej Zolnierkiewicz authored Feb 02, 2008

Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>

c1c9dbc8

ide: move create_proc_ide_drives() call to ide_device_add_all() · d9270a3f

Bartlomiej Zolnierkiewicz authored Feb 02, 2008

* Un-static create_proc_ide_drives() and call it from ide_device_add_all().

While at it:
* Rename create_proc_ide_drives() to ide_proc_port_register_devices().
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>

d9270a3f

ide: move hwif->present check out from ide_proc_register_port() · 327617e1

Bartlomiej Zolnierkiewicz authored Feb 02, 2008

Move hwif->present check out from ide_proc_register_port() to
ide_device_add_all().

There should be no functionality changes caused by this patch.
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>

327617e1

ide: factor out devices setup from ide_acpi_init() · eafd88a3

Bartlomiej Zolnierkiewicz authored Feb 02, 2008

* Factor out devices setup from ide_acpi_init() to
  ide_acpi_port_init_devices().

* Call ide_acpi_port_init_devices() in ide_device_add_all().

While at it:
* Remove no longer needed 'drive' field from struct ide_acpi_drive_link.

There should be no functionality changes caused by this patch.
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>

eafd88a3

ide-acpi: remove dead code from do_drive_get_GTF() · 070ecb84

Bartlomiej Zolnierkiewicz authored Feb 02, 2008

These pointers are always setup in ide_acpi_init().
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>

070ecb84

ide-acpi: remove needless exports · 4484d803
Bartlomiej Zolnierkiewicz authored Feb 02, 2008
```
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
```
4484d803

ide: move ide_acpi_init() call to ide_device_add_all() · decdc3f0

Bartlomiej Zolnierkiewicz authored Feb 02, 2008

There should be no functionality changes caused by this patch.
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>

decdc3f0

ide: factor out devices setup from init_irq() · d5bc6592

Bartlomiej Zolnierkiewicz authored Feb 02, 2008

* Factor out devices setup from init_irq() to ide_port_setup_devices().

While at it:
* Do devices setup after printing port information.
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>

d5bc6592

ide: factor out adding drive to hwgroup from init_irq() · 0947e0dc

Bartlomiej Zolnierkiewicz authored Feb 02, 2008

Factor out adding drive to hwgroup from init_irq() to
ide_add_drive_to_hwgroup().

There should be no functionality changes caused by this patch.
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>

0947e0dc

ide: move hwif->rqsize init from ide_init_queue() to init_irq() · 8a0e7e14

Bartlomiej Zolnierkiewicz authored Feb 02, 2008

Move hwif->rqsize init from ide_init_queue() to init_irq().

There should be no functionality changes caused by this patch.
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>

8a0e7e14

ide: merge init_gendisk() into hwif_register_devices() · c5d70cc7

Bartlomiej Zolnierkiewicz authored Feb 02, 2008

There should be no functionality changes caused by this patch.
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>

c5d70cc7

ide: call init_gendisk() after ide_acpi_init() · 346d4996

Bartlomiej Zolnierkiewicz authored Feb 02, 2008

There should be no functionality changes caused by this patch.
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>

346d4996

ide: move blk_register_region() call out from init_gendisk() · 3a4e7c96

Bartlomiej Zolnierkiewicz authored Feb 02, 2008

Move blk_register_region() call out from init_gendisk() to hwif_init().

There should be no functionality changes caused by this patch.
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>

3a4e7c96

ide: skip not present devices in init_gendisk() · 5c2854e6

Bartlomiej Zolnierkiewicz authored Feb 02, 2008

No need to initialize drive->gendev and waste memory on IDE settings
for not present devices.
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>

5c2854e6

ide: remove incorrect init_gendisk() comment · 521fd1e8
Bartlomiej Zolnierkiewicz authored Feb 02, 2008
```
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
```
521fd1e8

ide: add ->port_init_devs method to ide_hwif_t · 1f2cf8b0

Bartlomiej Zolnierkiewicz authored Feb 02, 2008

* Add ->port_init_devs method to ide_hwif_t for a host specific
  initialization of devices on a port.  Call the new method from
  ide_port_init_devices().

* Convert ht6560b, qd65xx and opti621 host drivers to use the new
  ->port_init_devs method.

There should be no functionality changes caused by this patch.
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>

1f2cf8b0