1. 21 Jul, 2005 1 commit
    • Rusty Russell's avatar
      [NETFILTER]: ip_conntrack_expect_related must not free expectation · 4acdbdbe
      Rusty Russell authored
      If a connection tracking helper tells us to expect a connection, and
      we're already expecting that connection, we simply free the one they
      gave us and return success.
      
      The problem is that NAT helpers (eg. FTP) have to allocate the
      expectation first (to see what port is available) then rewrite the
      packet.  If that rewrite fails, they try to remove the expectation,
      but it was freed in ip_conntrack_expect_related.
      
      This is one example of a larger problem: having registered the
      expectation, the pointer is no longer ours to use.  Reference counting
      is needed for ctnetlink anyway, so introduce it now.
      
      To have a single "put" path, we need to grab the reference to the
      connection on creation, rather than open-coding it in the caller.
      Signed-off-by: default avatarRusty Russell <rusty@rustcorp.com.au>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      4acdbdbe
  2. 20 Jul, 2005 1 commit
  3. 19 Jul, 2005 16 commits
  4. 18 Jul, 2005 9 commits
  5. 15 Jul, 2005 3 commits
  6. 14 Jul, 2005 10 commits