An error occurred fetching the project authors.
  1. 14 Aug, 2009 1 commit
    • Reinette Chatre's avatar
      iwlwifi: re-introduce per device debugging · 3d816c77
      Reinette Chatre authored
      Commit "iwlwifi: make debug level more user friendly" cleaned up the
      debug level handling. In doing so it created a single global debug
      level for all devices. Some setups do consits of more that one iwlwifi
      device and in these setups there is a requirement that debug levels
      should be unique per device.
      
      We now re-introduce the per device debugging while maintaining the
      cleanup effort of the previous patch.
      
      The maintain the global debug level and now introduce a per-device debug
      level that will be used if it (the per-device debug level) is set. The
      per-device debug level can be controlled via the debug_level sysfs file
      while the global debug level is controlled by the debug module parameter.
      Signed-off-by: default avatarReinette Chatre <reinette.chatre@intel.com>
      Acked-by: default avatarTomas Winkler <tomas.winkler@intel.com>
      Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
      3d816c77
  2. 04 Aug, 2009 2 commits
  3. 29 Jul, 2009 1 commit
  4. 27 Jul, 2009 5 commits
  5. 24 Jul, 2009 4 commits
    • Reinette Chatre's avatar
      iwlwifi: make debug level more user friendly · a562a9dd
      Reinette Chatre authored
      * Deprecate the "debug50" module parameter used to obtain
        5000 series and up debugging. Replace it with "debug" module
        parameter to match with original driver and be consistent
        between them. The "debug50" module parameter can still be used,
        except that the module parameter is not writable in keeping
        with its previous state. We currently just mark it as "deprecated"
        and do not have it in the feature-removal-schedule. Some more
        cleanup of module parameters needs to be done and can then be
        entered together.
      
      * Only make "debug" module parameters visible if the driver
        is compiled with CONFIG_IWLWIFI_DEBUG. This will eliminate
        a lot of confusion where users think they have set debug flags
        but yet cannot see any debug output.
      
      * Make module parameters writable. This eliminates the need for the
        "debug_level" sysfs file, which can now also be deprecated and
        added to feature-removal-schedule. This file is in significant
        use though with many iwlwifi documents and text referring users
        to it. We can thus not take its removal lightly and keep it around.
      
      With iwlcore shared between iwlagn and iwl3945 we really do not need
      debug module parameters for each but can instead have one debug
      module parameter for the iwlcore module. The same issue is here as
      with the sysfs file - a lot of iwlwifi documentation and text (like
      bug reports) rely on iwlagn and iwl3945 having this module parameter,
      so changing this to a module parameter of iwlcore will have significant
      impact and we do not do this for that reason.
      
      One consequence of this patch is that if a user is running a system
      with both 3945 and later hardware then the setting of the one module
      parameter will affect the value of the other. The likelihood of this
      seems low - and even if this setup is present it does not seem like an
      issue for both modules to run with the same debug level.
      Signed-off-by: default avatarReinette Chatre <reinette.chatre@intel.com>
      Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
      a562a9dd
    • Wey-Yi Guy's avatar
      iwlwifi: uCode Alive notification with timeout · 34a66de6
      Wey-Yi Guy authored
      Wait for REPLY_ALIVE notification from init and runtime uCode.
      based on the type of REPLY_ALIVE, different status bit will be set to
      wake up the queue:
      STATUS_INIT_UCODE_ALIVE for init uCode
      STATUS_RT_UCODE_ALIVE for runtime uCode.
      
      If timeout, attempt to download the failing uCode image again. This can
      only be done for the init ucode images of all iwlagn devices and the
      runtime ucode image of the 5000 series and up. If there is a problem
      with the 4965 runtime ucode coming up we restart the interface and thus
      trigger a new download of the init ucode also.
      Signed-off-by: default avatarWey-Yi Guy <wey-yi.w.guy@intel.com>
      Signed-off-by: default avatarReinette Chatre <reinette.chatre@intel.com>
      Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
      34a66de6
    • Jay Sternberg's avatar
      iwlwifi: Handle new firmware file with ucode build number in header · cc0f555d
      Jay Sternberg authored
      Adding new API version to account for change to ucode file format.  New
      header includes the build number of the ucode.  This build number is the
      SVN revision thus allowing for exact correlation to the code that
      generated it.
      
      The header adds the build number so that older ucode images can also be
      enhanced to include the build in the future.
      
      some cleanup in iwl_read_ucode needed to ensure old header not used and
      reduce unnecessary references through pointer with the data is already
      in heap variable.
      Signed-off-by: default avatarJay Sternberg <jay.e.sternberg@intel.com>
      Signed-off-by: default avatarReinette Chatre <reinette.chatre@intel.com>
      Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
      cc0f555d
    • Reinette Chatre's avatar
      iwlagn: fix minimum number of queues setting · 01a7e084
      Reinette Chatre authored
      We need to provide a reasonable minimum that will result in a
      working setup if used. Set minimum to be 10 to provide for
      4 standard TX queues + 1 command queue + 2 (unused) HCCA queues +
      4 HT queues (one per AC).
      
      We allow the user to change the number of queues used via a module
      parameter and use this minimum value to check if it is valid. Without
      this patch a user can select a value for the number of queues that
      will result in a failing setup.
      Signed-off-by: default avatarReinette Chatre <reinette.chatre@intel.com>
      Reviewed-by: default avatarTomas Winkler <tomas.winkler@intel.com>
      Acked-by: default avatarTomas Winkler <tomas.winkler@intel.com>
      Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
      01a7e084
  6. 10 Jul, 2009 2 commits
  7. 10 Jun, 2009 1 commit
  8. 04 Jun, 2009 1 commit
  9. 22 May, 2009 6 commits
  10. 20 May, 2009 2 commits
  11. 11 May, 2009 2 commits
  12. 22 Apr, 2009 3 commits
  13. 21 Apr, 2009 1 commit
    • Reinette Chatre's avatar
      iwlwifi: DMA fixes · df833b1d
      Reinette Chatre authored
      A few issues wrt DMA were uncovered when using the driver with swiotlb.
      - driver should not use memory after it has been mapped
      - iwl3945's RX queue management cannot use all of iwlagn because
        the size of the RX buffer is different. Revert back to using
        iwl3945 specific routines that map/unmap memory.
      - no need to "dma_syn_single_range_for_cpu" followed by pci_unmap_single,
        we can just call pci_unmap_single initially
      - only map the memory area that will be used by device. this is especially
        relevant to the mapping of iwl_cmd. we should not map the entire
        structure because the meta data at the beginning of structure contains
        the address to be used later for unmapping. If the address to be used for
        unmapping is stored in mapped data it creates a problem.
      - ensure that _if_ memory needs to be modified after it is mapped that we
        call _sync_single_for_cpu first, and then release it back to device with
        _sync_single_for_device
      - we mapped the wrong length of data for host commands, with mapped length
        differing with length provided to device, fix that.
      
      Thanks to Jason Andryuk <jandryuk@gmail.com> for significant bisecting
      help to find these issues.
      
      This fixes http://www.intellinuxwireless.org/bugzilla/show_bug.cgi?id=1964Signed-off-by: default avatarReinette Chatre <reinette.chatre@intel.com>
      Tested-by: default avatarJason Andryuk <jandryuk@gmail.com>
      Tested-by: default avatarBen Gamari <bgamari@gmail.com>
      Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
      df833b1d
  14. 28 Mar, 2009 1 commit
    • Johannes Berg's avatar
      mac80211/iwlwifi: move virtual A-MDPU queue bookkeeping to iwlwifi · e4e72fb4
      Johannes Berg authored
      This patch removes all the virtual A-MPDU-queue bookkeeping from
      mac80211. Curiously, iwlwifi already does its own bookkeeping, so
      it doesn't require much changes except where it needs to handle
      starting and stopping the queues in mac80211.
      
      To handle the queue stop/wake properly, we rewrite the software
      queue number for aggregation frames and internally to iwlwifi keep
      track of the queues that map into the same AC queue, and only talk
      to mac80211 about the AC queue. The implementation requires calling
      two new functions, iwl_stop_queue and iwl_wake_queue instead of the
      mac80211 counterparts.
      Signed-off-by: default avatarJohannes Berg <johannes@sipsolutions.net>
      Cc: Reinette Chattre <reinette.chatre@intel.com>
      Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
      e4e72fb4
  15. 16 Mar, 2009 2 commits
  16. 27 Feb, 2009 1 commit
    • Reinette Chatre's avatar
      iwlwifi: Fix and rework Kconfig file · 80bc5393
      Reinette Chatre authored
      Fixes:
      - iwlwifi is an optional driver and should thus not default to 'y'.
      - 3945 now depends on IWLCORE.
      
      Rework:
      - There is not a case when IWLCORE should not be selected. At the same time
        the driver does not use IWLWIFI or IWLCORE. We can just merge the usage of
        these two. With IWLWIFI being the driver name we proceed to use just it and
        replace instances of IWLCORE with it. The module name does not change
        and is still iwlcore.
      - Both IWLAGN and IWL3945 are selecting FW_LOADER, we can thus just move
        this up to one select when IWLWIFI is selected.
      - IWL5000 now supports Intel Wireless Wifi 100, 6000, and 6050 series.
      - Now that 3945 depends on IWLWIFI we can also indicate its dependency on
        MAC80211_LEDS and LEDS_CLASS at this level.
      - IWLAGN_LEDS is not used by driver - remove it.
      - IWLAGN_SPECTRUM_MEASUREMENT actually depends on IWLWIFI as it forms part
        of iwlcore module. Move this config up in Kconfig to reflect that and also
        change name to IWLWIFI_SPECTRUM_MEASUREMENT.
      - CONFIG_IWLWIFI_RFKILL is used by iwlagn as well as iwl3945, add text to
        description that indicates this.
      - CONFIG_IWL3945_RFKILL does not exist - remove usage from driver.
      - Add "iwlagn" to end of description of IWLAGN to help people understand
        what iwlagn means in rest of Kconfig text.
      - Add "iwl3945" to end of description of IWL3945 to help people understand
        what iwlagn means in rest of Kconfig text.
      - Change IWLWIFI_DEBUGFS description to indicate that only iwlagn supports
        it (for now).
      Signed-off-by: default avatarReinette Chatre <reinette.chatre@intel.com>
      Reported-by: default avatarRandy Dunlap <randy.dunlap@oracle.com>
      Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
      80bc5393
  17. 09 Feb, 2009 2 commits
  18. 29 Jan, 2009 3 commits