Skip to content

L
linux-davinci
Switch branch/tag
  1. 14 Oct, 2009 1 commit
  3. 16 Oct, 2009 1 commit
  5. 09 Nov, 2009 1 commit
    • Anton Vorontsov's avatar
      RTC core won't allow wakeup alarms to be set if RTC devices' parent (i.e. · 0d0b9e35
      Anton Vorontsov authored 
      i2c_client or spi_device) isn't wakeup capable.

For I2C devices there is I2C_CLIENT_WAKE flag exists that we can pass via
board info, and if set, I2C core will initialize wakeup capability.  For
SPI devices there is no such flag at all.

I believe that it's not platform code responsibility to allow or disallow
wakeups, instead, drivers themselves should set the capability if a device
can trigger wakeups.

That's what drivers/base/power/sysfs.c says:

 * It is the responsibility of device drivers to enable (or disable)
 * wakeup signaling as part of changing device power states, respecting
 * the policy choices provided through the driver model.

I2C and SPI RTC devices send wakeup events via interrupt lines, so we
should set the wakeup capability if IRQ is routed.

Ideally we should also check irq for wakeup capability before setting
device's capability, i.e.

	if (can_irq_wake(irq))
		device_set_wakeup_capable(&client->dev, 1);

But there is no can_irq_wake() call exist, and it is not that trivial to
implement it for all interrupts controllers and complex/cascaded setups.

drivers/base/power/sysfs.c also covers these cases:

 * Devices may not be able to generate wakeup events from all power
 * states.  Also, the events may be ignored in some configurations;
 * for example, they might need help from other devices that aren't
 * active

So there is no guarantee that wakeup will actually work, and so I think
there is no point in being pedantic wrt checking IRQ wakeup capability.
Signed-off-by: default avatarAnton Vorontsov <avorontsov@ru.mvista.com>
Cc: David Brownell <dbrownell@users.sourceforge.net>
Cc: Ben Dooks <ben-linux@fluff.org>
Cc: Jean Delvare <khali@linux-fr.org>
Cc: Alessandro Zummo <a.zummo@towertech.it>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      0d0b9e35
  7. 10 Nov, 2009 1 commit
  9. 04 Nov, 2009 1 commit
  11. 16 Oct, 2009 2 commits
    • Atsushi Nemoto's avatar
      The to_platform_device macro itself uses container_of macro. Nested use · 94e2f167
      Atsushi Nemoto authored 
      of container_of macro causes following sparse warnings:

rtc-ds1553.c:259:3: warning: symbol '__mptr' shadows an earlier one
rtc-ds1553.c:259:3: originally declared here
Signed-off-by: default avatarAtsushi Nemoto <anemo@mba.ocn.ne.jp>
Cc: Alessandro Zummo <alessandro.zummo@towertech.it>
Cc: David Brownell <david-b@pacbell.net>
Cc: Andrew Sharp <andy.sharp@lsi.com>
Cc: Thomas Hommel <thomas.hommel@gefanuc.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      94e2f167
    • Atsushi Nemoto's avatar
      - Call dev_set_drvdata before rtc device creation. · 41684cba
      Atsushi Nemoto authored 
      - Use its own spinlock instead of rtc->irq_lock.  Because pdata->rtc
  must be initialized to use the irq_lock (pdata->rtc->irq_lock).  There
  is a small window which rtc methods can be called before pdata->rtc is
  initialized.

  And there is no need use the irq_lock to protect hardware registers.
  The driver's own spinlock shoule be enough.

- Check pdata->rtc before calling rtc_update_irq.

- Use alarm_irq_enable and remove ioctl routine.

- Use devres APIs and simplify error/remove path.

These fixes are ported from ds1553 driver and just compile-tested only.
Signed-off-by: default avatarAtsushi Nemoto <anemo@mba.ocn.ne.jp>
Cc: Alessandro Zummo <alessandro.zummo@towertech.it>
Cc: Thomas Hommel <thomas.hommel@gefanuc.com>
Cc: David Brownell <david-b@pacbell.net>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      41684cba
  13. 12 Oct, 2009 4 commits
  15. 30 Sep, 2009 1 commit
  17. 13 Oct, 2009 1 commit
  19. 06 Oct, 2009 10 commits
  21. 12 Nov, 2009 1 commit
  23. 10 Nov, 2009 2 commits
  25. 03 Nov, 2009 1 commit
  27. 14 Oct, 2009 1 commit
  29. 15 Oct, 2009 1 commit
  31. 10 Nov, 2009 2 commits
  33. 30 Sep, 2009 1 commit
    • Ben Nizette's avatar
      If len > BUFFER_LEN and !xfer->rx_buf we end up calculating the tx buffer · 122385cf
      Ben Nizette authored 
      address as

*tx_dma = xfer->tx_dma + xfer->len - BUFFER_SIZE;

which is constant; i.e.  we just send the last BUFFER_SIZE data over again
until we've reached the right number of bytes.

This patch gets around this by using the /requested/ length when
calculating addresses.

Note there's no way len != *plen when we calculate the rx buffer address
but conceptually we should be using *plen and I don't want someone to come
through later, see the calculations for rx and tx are different and "clean
up" back to what we had.
Signed-off-by: default avatarBen Nizette <bn@niasdigital.com>
Cc: Haavard Skinnemoen <hskinnemoen@atmel.com>
Cc: David Brownell <dbrownell@users.sourceforge.net>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      122385cf
  35. 03 Nov, 2009 1 commit
  37. 16 Oct, 2009 2 commits
    • Andrew Morton's avatar
      ERROR: code indent should use tabs where possible · 9429b460
      Andrew Morton authored 
      #44: FILE: drivers/hwmon/w83627ehf.c:8:
+                        Daniel J Blueman <daniel.blueman@gmail.com>$

WARNING: line over 80 characters
#88: FILE: drivers/hwmon/w83627ehf.c:306:
+			     4->variable thermal cruise (also called SmartFan III) */

WARNING: line over 80 characters
#111: FILE: drivers/hwmon/w83627ehf.c:544:
+						W83627EHF_REG_FAN_START_OUTPUT[i]);

WARNING: line over 80 characters
#113: FILE: drivers/hwmon/w83627ehf.c:546:
+						W83627EHF_REG_FAN_STOP_OUTPUT[i]);

total: 1 errors, 3 warnings, 153 lines checked

./patches/hwmon-w83627ehf-updates.patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Please run checkpatch prior to sending patches

Cc: Daniel J Blueman <daniel.blueman@gmail.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      9429b460
    • Daniel J Blueman's avatar
      Add control of fan minimum turn-on output levels, decoupling it from the · 78eef0e1
      Daniel J Blueman authored 
      fan turn-off output level.  Add control of rate of change of fan output
level.  These in turn allow lower turn-off rotor speed and smoother
transitions for better thermal and acoustic control authority.  Add
support for constant fan speed and proportional-response operations modes.
Signed-off-by: default avatarDaniel J Blueman <daniel.blueman@gmail.com>
Cc: Jean Delvare <khali@linux-fr.org>
Cc: David Hubbard <david.c.hubbard@gmail.com>
Cc: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      78eef0e1
  39. 09 Nov, 2009 1 commit
  41. 06 Oct, 2009 1 commit
  43. 09 Nov, 2009 1 commit
  45. 12 Nov, 2009 2 commits
    • Andrew Morton's avatar
      may as well depukify it a bit while we're there. · 7bc82a6b
      Andrew Morton authored 
      

WARNING: plain inline is preferred over __inline__
#22: FILE: lib/crc32.c:47:
+static __inline__ u32

ERROR: space prohibited after that open square bracket '['
#26: FILE: lib/crc32.c:51:
+#  define DO_CRC(x) crc = tab[ (crc ^ (x)) & 255 ] ^ (crc>>8)

ERROR: space prohibited before that close square bracket ']'
#26: FILE: lib/crc32.c:51:
+#  define DO_CRC(x) crc = tab[ (crc ^ (x)) & 255 ] ^ (crc>>8)

ERROR: Macros with complex values should be enclosed in parenthesis
#26: FILE: lib/crc32.c:51:
+#  define DO_CRC(x) crc = tab[ (crc ^ (x)) & 255 ] ^ (crc>>8)

ERROR: space prohibited after that open square bracket '['
#28: FILE: lib/crc32.c:53:
+#  define DO_CRC(x) crc = tab[ ((crc >> 24) ^ (x)) & 255] ^ (crc<<8)

ERROR: Macros with complex values should be enclosed in parenthesis
#28: FILE: lib/crc32.c:53:
+#  define DO_CRC(x) crc = tab[ ((crc >> 24) ^ (x)) & 255] ^ (crc<<8)

ERROR: spaces required around that '=' (ctx:WxV)
#30: FILE: lib/crc32.c:55:
+	const u32 *b =(u32 *)buf;
 	             ^

ERROR: space required before the open parenthesis '('
#34: FILE: lib/crc32.c:59:
+	if(unlikely(((long)b)&3 && len)) {

ERROR: space required before the open parenthesis '('
#53: FILE: lib/crc32.c:78:
+	if(len) {

total: 8 errors, 1 warnings, 145 lines checked

./patches/crc32-minor-optimizations-and-cleanup.patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Please run checkpatch prior to sending patches

Cc: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      7bc82a6b
    • Joakim Tjernlund's avatar
      Move common crc body to new function crc32_body() cleaup and micro · dd4137bb
      Joakim Tjernlund authored 
      optimize crc32_body for speed and less size.
Signed-off-by: default avatarJoakim Tjernlund <Joakim.Tjernlund@transmode.se>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      dd4137bb