Commits · 15a601eb9cdc2a9cc69d5fc745317805a85c064c · linux / linux-davinci

17 Apr, 2008 40 commits

x86: fix test_poke for vmalloced pages · 15a601eb

Mathieu Desnoyers authored Mar 12, 2008

* Ingo Molnar (mingo@elte.hu) wrote:
>
> * Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca> wrote:
>
> > The shadow vmap for DEBUG_RODATA kernel text modification uses
> > virt_to_page to get the pages from the pointer address.
> >
> > However, I think vmalloc_to_page would be required in case the page is
> > used for modules.
> >
> > Since only the core kernel text is marked read-only, use
> > kernel_text_address() to make sure we only shadow map the core kernel
> > text, not modules.
>
> actually, i think we should mark module text readonly too.
>

Yes, but in the meantime, the x86 tree would need this patch to make
kprobes work correctly on modules.

I suspect that without this fix, with the enhanced hotplug and kprobes
patch, kprobes will use text_poke to insert breakpoints in modules
(vmalloced pages used), which will map the wrong pages and corrupt
random kernel locations instead of updating the correct page.

Work that would write protect the module pages should clearly be done,
but it can come in a later time. We have to make sure we interact
correctly with the page allocation debugging, as an example.

Here is the patch against x86.git 2.6.25-rc5 :

The shadow vmap for DEBUG_RODATA kernel text modification uses virt_to_page to
get the pages from the pointer address.

However, I think vmalloc_to_page would be required in case the page is used for
modules.

Since only the core kernel text is marked read-only, use kernel_text_address()
to make sure we only shadow map the core kernel text, not modules.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
CC: akpm@linux-foundation.org
Signed-off-by: Ingo Molnar <mingo@elte.hu>

15a601eb

x86: clean up vSMP detection · e5699a82

Ravikiran G Thirumalai authored Mar 24, 2008

vSMP detection: access pci config space early in boot to detect if the
system is a vSMPowered box, and cache the result in a flag, so that
is_vsmp_box() retrieves the value of the flag always.
Signed-off-by: Ravikiran Thirumalai <kiran@scalex86.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>

e5699a82

x86: pgtable, document pde bits · 43cdf5d6

Jiri Slaby authored Mar 22, 2008

Some of pde bits weren't documented, add the short description to them.
Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>

43cdf5d6

x86: spinlock ops are always-inlined · 7fda20f1
Ingo Molnar authored Feb 29, 2008
```
Signed-off-by: Ingo Molnar <mingo@elte.hu>
```
7fda20f1

x86: only enable interrupts when kernel state has been set up · d93c870b

Jeremy Fitzhardinge authored Mar 24, 2008

The sysenter path tries to enable interrupts immediately.  Unfortunately
this doesn't work in a paravirt environment, because not enough kernel
state has been set up at that point (namely, pointing %fs to the kernel
percpu data segment).  To fix this, defer ENABLE_INTERRUPTS until after
the kernel state has been set up.

Unfortunately this means that we're running with interrupts disabled
for a while without calling the IRQ tracing code, but that can't be
called without setting up %fs either.
Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>

d93c870b

include/asm-x86/xor_64.h: checkpatch cleanups - formatting only · 687c8054
Joe Perches authored Mar 23, 2008
```
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
```
687c8054
include/asm-x86/xor_32.h: checkpatch cleanups - formatting only · 8fdf7655
Joe Perches authored Mar 23, 2008
```
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
```
8fdf7655
include/asm-x86/voyager.h: checkpatch cleanups - formatting only · d6ae390a
Joe Perches authored Mar 23, 2008
```
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
```
d6ae390a
include/asm-x86/vmi.h: checkpatch cleanups - formatting only · 8948584e
Joe Perches authored Mar 23, 2008
```
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
```
8948584e
include/asm-x86/vm86.h: checkpatch cleanups - formatting only · 9e8a935b
Joe Perches authored Mar 23, 2008
```
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
```
9e8a935b
include/asm-x86/vga.h: checkpatch cleanups - formatting only · 364fe5ef
Joe Perches authored Mar 23, 2008
```
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
```
364fe5ef
include/asm-x86/vdso.h: checkpatch cleanups - formatting only · ac1a7b0e
Joe Perches authored Mar 23, 2008
```
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
```
ac1a7b0e
include/asm-x86/user_64.h: checkpatch cleanups - formatting only · a206ea11
Joe Perches authored Mar 23, 2008
```
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
```
a206ea11
include/asm-x86/user32.h: checkpatch cleanups - formatting only · a3121619
Joe Perches authored Mar 23, 2008
```
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
```
a3121619
include/asm-x86/user_32.h: checkpatch cleanups - formatting only · 826700dc
Joe Perches authored Mar 23, 2008
```
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
```
826700dc
include/asm-x86/unistd_64.h: checkpatch cleanups - formatting only · c489f445
Joe Perches authored Mar 23, 2008
```
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
```
c489f445
include/asm-x86/unistd_32.h: checkpatch cleanups - formatting only · 687fc16b
Joe Perches authored Mar 23, 2008
```
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
```
687fc16b
include/asm-x86/unaligned.h: checkpatch cleanups - formatting only · 6e714b37
Joe Perches authored Mar 23, 2008
```
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
```
6e714b37
include/asm-x86/uaccess_64.h: checkpatch cleanups - formatting only · b896313e
Joe Perches authored Mar 23, 2008
```
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
```
b896313e
include/asm-x86/uaccess_32.h: checkpatch cleanups - formatting only · b1fcec7f
Joe Perches authored Mar 23, 2008
```
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
```
b1fcec7f
include/asm-x86/tsc.h: checkpatch cleanups - formatting only · 2d86e637
Joe Perches authored Mar 23, 2008
```
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
```
2d86e637
include/asm-x86/topology.h: checkpatch cleanups - formatting only · 5d7d03b8
Joe Perches authored Mar 23, 2008
```
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
```
5d7d03b8
include/asm-x86/tlbflush.h: checkpatch cleanups - formatting only · 94cf8de0
Joe Perches authored Mar 23, 2008
```
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
```
94cf8de0
include/asm-x86/thread_info_64.h: checkpatch cleanups - formatting only · b98fff30
Joe Perches authored Mar 23, 2008
```
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
```
b98fff30
include/asm-x86/thread_info_32.h: checkpatch cleanups - formatting only · 89917f28
Joe Perches authored Mar 23, 2008
```
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
```
89917f28
include/asm-x86/tce.h: checkpatch cleanups - formatting only · 7c4d4784
Joe Perches authored Mar 23, 2008
```
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
```
7c4d4784
include/asm-x86/system.h: checkpatch cleanups - formatting only · c5386c20
Joe Perches authored Mar 23, 2008
```
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
```
c5386c20
include/asm-x86/sync_bitops.h: checkpatch cleanups - formatting only · 26b7fcc4
Joe Perches authored Mar 23, 2008
```
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
```
26b7fcc4
include/asm-x86/swiotlb.h: checkpatch cleanups - formatting only · a4c2d7d9
Joe Perches authored Mar 23, 2008
```
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
```
a4c2d7d9
include/asm-x86/suspend_64.h: checkpatch cleanups - formatting only · 1b17fce6
Joe Perches authored Mar 23, 2008
```
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
```
1b17fce6
include/asm-x86/suspend_32.h: checkpatch cleanups - formatting only · cf030ebd
Joe Perches authored Mar 23, 2008
```
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
```
cf030ebd
include/asm-x86/string_64.h: checkpatch cleanups - formatting only · 953b2f1e
Joe Perches authored Mar 23, 2008
```
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
```
953b2f1e
include/asm-x86/string_32.h: checkpatch cleanups - formatting only · 06b0f574
Joe Perches authored Mar 23, 2008
```
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
```
06b0f574
include/asm-x86/srat.h: checkpatch cleanups - formatting only · 7f3a9508
Joe Perches authored Mar 23, 2008
```
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
```
7f3a9508
include/asm-x86/spinlock.h: checkpatch cleanups - formatting only · d3bf60a6
Joe Perches authored Mar 23, 2008
```
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
```
d3bf60a6
include/asm-x86/smp_64.h: checkpatch cleanups - formatting only · ceb7ce10
Joe Perches authored Mar 23, 2008
```
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
```
ceb7ce10
include/asm-x86/smp_32.h: checkpatch cleanups - formatting only · 2fec394a
Joe Perches authored Mar 23, 2008
```
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
```
2fec394a
include/asm-x86/signal.h: checkpatch cleanups - formatting only · 9551b12a
Joe Perches authored Mar 23, 2008
```
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
```
9551b12a
include/asm-x86/sigcontext.h: checkpatch cleanups - formatting only · af1fec15
Joe Perches authored Mar 23, 2008
```
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
```
af1fec15
include/asm-x86/sigcontext32.h: checkpatch cleanups - formatting only · 895b7643
Joe Perches authored Mar 23, 2008
```
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
```
895b7643