1. 16 Jan, 2009 2 commits
    • Roland Dreier's avatar
      IB/mlx4: Fix memory ordering problem when posting LSO sends · 0fd7e1d8
      Roland Dreier authored
      The current work request posting code writes the LSO segment before
      writing any data segments.  This leaves a window where the LSO segment
      overwrites the stamping in one cacheline that the HCA prefetches
      before the rest of the cacheline is filled with the correct data
      segments.  When the HCA processes this work request, a local
      protection error may result.
      
      Fix this by saving the LSO header size field off and writing it only
      after all data segments are written.  This fix is a cleaned-up version
      of a patch from Jack Morgenstein <jackm@dev.mellanox.co.il>.
      
      This fixes <https://bugs.openfabrics.org/show_bug.cgi?id=1383>.
      Reported-by: default avatarJack Morgenstein <jackm@dev.mellanox.co.il>
      Signed-off-by: default avatarRoland Dreier <rolandd@cisco.com>
      0fd7e1d8
    • Andrew Morton's avatar
      mlx4_core: Fix min() warning · d3b924d9
      Andrew Morton authored
      Fix
      
          drivers/net/mlx4/profile.c: In function `mlx4_make_profile':
          drivers/net/mlx4/profile.c:110: warning: comparison of distinct pointer types lacks a cast
      
      This happened because num_possible_cpus() was secretly changed by
      commit ae7a47e7 ("cpumask: make cpumask.h eat its own dogfood.") from
      returning "int" to (now) returning "unsigned int".  I think that was a
      good change, so we should just swallow the fallout.
      
      Cc: "David S. Miller" <davem@davemloft.net>
      Cc: Roland Dreier <rolandd@cisco.com>
      Cc: Yevgeny Petrilin <yevgenyp@mellanox.co.il>
      Cc: Jack Morgenstein <jackm@dev.mellanox.co.il>
      Cc: Vladimir Sokolovsky <vlad@mellanox.co.il>
      Cc: Michael S. Tsirkin <mst@dev.mellanox.co.il>
      Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: default avatarRoland Dreier <rolandd@cisco.com>
      d3b924d9
  2. 13 Jan, 2009 24 commits
  3. 12 Jan, 2009 14 commits