Skip to content

L
linux-davinci
Switch branch/tag
  1. 30 Sep, 2009 1 commit
    • Ben Nizette's avatar
      If len > BUFFER_LEN and !xfer->rx_buf we end up calculating the tx buffer · 0fcf039e
      Ben Nizette authored 
      address as

*tx_dma = xfer->tx_dma + xfer->len - BUFFER_SIZE;

which is constant; i.e.  we just send the last BUFFER_SIZE data over again
until we've reached the right number of bytes.

This patch gets around this by using the /requested/ length when
calculating addresses.

Note there's no way len != *plen when we calculate the rx buffer address
but conceptually we should be using *plen and I don't want someone to come
through later, see the calculations for rx and tx are different and "clean
up" back to what we had.
Signed-off-by: default avatarBen Nizette <bn@niasdigital.com>
Cc: Haavard Skinnemoen <hskinnemoen@atmel.com>
Cc: David Brownell <dbrownell@users.sourceforge.net>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      0fcf039e
  3. 03 Nov, 2009 1 commit
  5. 17 Nov, 2009 5 commits
  7. 16 Oct, 2009 2 commits
    • Andrew Morton's avatar
      ERROR: code indent should use tabs where possible · 8708cd57
      Andrew Morton authored 
      #44: FILE: drivers/hwmon/w83627ehf.c:8:
+                        Daniel J Blueman <daniel.blueman@gmail.com>$

WARNING: line over 80 characters
#88: FILE: drivers/hwmon/w83627ehf.c:306:
+			     4->variable thermal cruise (also called SmartFan III) */

WARNING: line over 80 characters
#111: FILE: drivers/hwmon/w83627ehf.c:544:
+						W83627EHF_REG_FAN_START_OUTPUT[i]);

WARNING: line over 80 characters
#113: FILE: drivers/hwmon/w83627ehf.c:546:
+						W83627EHF_REG_FAN_STOP_OUTPUT[i]);

total: 1 errors, 3 warnings, 153 lines checked

./patches/hwmon-w83627ehf-updates.patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Please run checkpatch prior to sending patches

Cc: Daniel J Blueman <daniel.blueman@gmail.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      8708cd57
    • Daniel J Blueman's avatar
      Add control of fan minimum turn-on output levels, decoupling it from the · ac97f791
      Daniel J Blueman authored 
      fan turn-off output level.  Add control of rate of change of fan output
level.  These in turn allow lower turn-off rotor speed and smoother
transitions for better thermal and acoustic control authority.  Add
support for constant fan speed and proportional-response operations modes.
Signed-off-by: default avatarDaniel J Blueman <daniel.blueman@gmail.com>
Cc: Jean Delvare <khali@linux-fr.org>
Cc: David Hubbard <david.c.hubbard@gmail.com>
Cc: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      ac97f791
  9. 11 Nov, 2009 1 commit
  11. 06 Oct, 2009 1 commit
  13. 11 Nov, 2009 1 commit
  15. 12 Nov, 2009 2 commits
    • Andrew Morton's avatar
      may as well depukify it a bit while we're there. · b25943b2
      Andrew Morton authored 
      

WARNING: plain inline is preferred over __inline__
#22: FILE: lib/crc32.c:47:
+static __inline__ u32

ERROR: space prohibited after that open square bracket '['
#26: FILE: lib/crc32.c:51:
+#  define DO_CRC(x) crc = tab[ (crc ^ (x)) & 255 ] ^ (crc>>8)

ERROR: space prohibited before that close square bracket ']'
#26: FILE: lib/crc32.c:51:
+#  define DO_CRC(x) crc = tab[ (crc ^ (x)) & 255 ] ^ (crc>>8)

ERROR: Macros with complex values should be enclosed in parenthesis
#26: FILE: lib/crc32.c:51:
+#  define DO_CRC(x) crc = tab[ (crc ^ (x)) & 255 ] ^ (crc>>8)

ERROR: space prohibited after that open square bracket '['
#28: FILE: lib/crc32.c:53:
+#  define DO_CRC(x) crc = tab[ ((crc >> 24) ^ (x)) & 255] ^ (crc<<8)

ERROR: Macros with complex values should be enclosed in parenthesis
#28: FILE: lib/crc32.c:53:
+#  define DO_CRC(x) crc = tab[ ((crc >> 24) ^ (x)) & 255] ^ (crc<<8)

ERROR: spaces required around that '=' (ctx:WxV)
#30: FILE: lib/crc32.c:55:
+	const u32 *b =(u32 *)buf;
 	             ^

ERROR: space required before the open parenthesis '('
#34: FILE: lib/crc32.c:59:
+	if(unlikely(((long)b)&3 && len)) {

ERROR: space required before the open parenthesis '('
#53: FILE: lib/crc32.c:78:
+	if(len) {

total: 8 errors, 1 warnings, 145 lines checked

./patches/crc32-minor-optimizations-and-cleanup.patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Please run checkpatch prior to sending patches

Cc: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      b25943b2
    • Joakim Tjernlund's avatar
      Move common crc body to new function crc32_body() cleaup and micro · 528c9ce8
      Joakim Tjernlund authored 
      optimize crc32_body for speed and less size.
Signed-off-by: default avatarJoakim Tjernlund <Joakim.Tjernlund@transmode.se>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      528c9ce8
  17. 16 Oct, 2009 1 commit
  19. 28 Oct, 2009 1 commit
    • Hidetoshi Seto's avatar
      In case if the statement and the conditional are in one line, the line · 3f0ddd7f
      Hidetoshi Seto authored 
      appears in the report doubly.

And items of this check have no blank line before the next item.

This patch fixes these trivial problems, to improve readability of the
report.

[sample.c]
  > if (cond1
  >        && cond2
  >        && cond3) func_foo();
  >
  > if (cond4) func_bar();

Before:
  > ERROR: trailing statements should be on next line
  > #1: FILE: sample.c:1:
  > +if (cond1
  > [...]
  > +       && cond3) func_foo();
  > ERROR: trailing statements should be on next line
  > #5: FILE: sample.c:5:
  > +if (cond4) func_bar();
  > +if (cond4) func_bar();
  > total: 2 errors, 0 warnings, 5 lines checked

After:
  > ERROR: trailing statements should be on next line
  > #1: FILE: sample.c:1:
  > +if (cond1
  > [...]
  > +       && cond3) func_foo();
  >
  > ERROR: trailing statements should be on next line
  > #5: FILE: sample.c:5:
  > +if (cond4) func_bar();
  >
  > total: 2 errors, 0 warnings, 5 lines checked
Signed-off-by: default avatarHidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
Cc: Andy Whitcroft <apw@canonical.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      3f0ddd7f
  21. 11 Nov, 2009 1 commit
  23. 25 Sep, 2009 1 commit
  25. 17 Nov, 2009 1 commit
    • Ben Hutchings's avatar
      Some people run general-purpose distribution kernels on netbooks with · 5caa5915
      Ben Hutchings authored 
      a card that is physically non-removable or logically non-removable
(e.g. used for /home) and cannot be cleanly unmounted during suspend.
Add a module parameter to set whether cards are assumed removable or
non-removable, with the default set by CONFIG_MMC_UNSAFE_RESUME.

In general, it is not possible to tell whether a card present in an MMC
slot after resume is the same that was there before suspend.  So there are
two possible behaviours, each of which will cause data loss in some cases:

CONFIG_MMC_UNSAFE_RESUME=n (default): Cards are assumed to be removed
during suspend.  Any filesystem on them must be unmounted before suspend;
otherwise, buffered writes will be lost.

CONFIG_MMC_UNSAFE_RESUME=y: Cards are assumed to remain present during
suspend.  They must not be swapped during suspend; otherwise, buffered
writes will be flushed to the wrong card.

Currently the choice is made at compile time and this allows that to be
overridden at module load time.
Signed-off-by: default avatarBen Hutchings <ben@decadent.org.uk>
Cc: <linux-mmc@vger.kernel.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      5caa5915
  27. 12 Nov, 2009 1 commit
  29. 11 Nov, 2009 1 commit
  31. 10 Nov, 2009 1 commit
  33. 15 Oct, 2009 1 commit
  35. 09 Oct, 2009 1 commit
  37. 04 Nov, 2009 2 commits
    • Andrew Morton's avatar
      ERROR: code indent should use tabs where possible · 9923e22a
      Andrew Morton authored 
      #28: FILE: arch/arm/mach-msm/include/mach/mmc.h:12:
+        struct sdio_cis cis;$

ERROR: code indent should use tabs where possible
#29: FILE: arch/arm/mach-msm/include/mach/mmc.h:13:
+        struct sdio_cccr cccr;$

ERROR: code indent should use tabs where possible
#30: FILE: arch/arm/mach-msm/include/mach/mmc.h:14:
+        struct sdio_embedded_func *funcs;$

ERROR: code indent should use tabs where possible
#31: FILE: arch/arm/mach-msm/include/mach/mmc.h:15:
+        int num_funcs;$

WARNING: line over 80 characters
#39: FILE: arch/arm/mach-msm/include/mach/mmc.h:23:
+	int (*register_status_notify)(void (*callback)(int card_present, void *dev_id), void *dev_id);

total: 4 errors, 1 warnings, 50 lines checked

./patches/msm_sdccc-add-missing-include-fix-compilation.patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Please run checkpatch prior to sending patches

Cc: Pavel Machek <pavel@ucw.cz>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      9923e22a
    • Pavel Machek's avatar
      Add missing include for msm_sdcc compilation, and remove pwrsink · a8659dd2
      Pavel Machek authored 
      support that is not mainline, yet.
Signed-off-by: default avatarPavel Machek <pavel@ucw.cz>
Cc <linux-mmc@vger.kernel.org>
Cc: Russell King <rmk@arm.linux.org.uk>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      a8659dd2
  39. 03 Nov, 2009 1 commit
  41. 16 Oct, 2009 1 commit
  43. 14 Oct, 2009 1 commit
  45. 29 Sep, 2009 2 commits
  47. 14 Oct, 2009 1 commit
  49. 11 Nov, 2009 2 commits
  51. 10 Nov, 2009 1 commit
  53. 13 Oct, 2009 5 commits