- 08 Oct, 2008 40 commits
-
-
Vlad Yasevich authored
The gabs array in the sctp_tsnmap structure is only used in one place, sctp_make_sack(). As such, carrying the array around in the sctp_tsnmap and thus directly in the sctp_association is rather pointless since most of the time it's just taking up space. Now, let sctp_make_sack create and populate it and then throw it away when it's done. Signed-off-by:
Vlad Yasevich <vladislav.yasevich@hp.com> Signed-off-by:
David S. Miller <davem@davemloft.net>
-
Vlad Yasevich authored
The tsn map currently use is 4K large and is stuck inside the sctp_association structure making memory references REALLY expensive. What we really need is at most 4K worth of bits so the biggest map we would have is 512 bytes. Also, the map is only really usefull when we have gaps to store and report. As such, starting with minimal map of say 32 TSNs (bits) should be enough for normal low-loss operations. We can grow the map by some multiple of 32 along with some extra room any time we receive the TSN which would put us outside of the map boundry. As we close gaps, we can shift the map to rebase it on the latest TSN we've seen. This saves 4088 bytes per association just in the map alone along savings from the now unnecessary structure members. Signed-off-by:
-
Eric Dumazet authored
I noticed sysctl_local_port_range[] and its associated seqlock sysctl_local_port_range_lock were on separate cache lines. Moreover, sysctl_local_port_range[] was close to unrelated variables, highly modified, leading to cache misses. Moving these two variables in a structure can help data locality and moving this structure to read_mostly section helps sharing of this data among cpus. Cleanup of extern declarations (moved in include file where they belong), and use of inet_get_local_port_range() accessor instead of direct access to ports values. Signed-off-by:
Eric Dumazet <dada1@cosmosbay.com> Signed-off-by:
-
Eric Dumazet authored
Current UDP port allocation is suboptimal. We select the shortest chain to chose a port (out of 512) that will hash in this shortest chain. First, it can lead to give not so ramdom ports and ease give attackers more opportunities to break the system. Second, it can consume a lot of CPU to scan all table in order to find the shortest chain. Third, in some pathological cases we can fail to find a free port even if they are plenty of them. This patch zap the search for a short chain and only use one random seed. Problem of getting long chains should be addressed in another way, since we can obtain long chains with non random ports. Based on a report and patch from Vitaly Mayatskikh Signed-off-by:
-
Jarek Poplawski authored
After the last change of requeuing there is no info about such incidents in tc stats. This patch updates the counter, but we should consider this should differ from previous stats because of additional checks preventing to repeat this. On the other hand, previous stats didn't include requeuing of gso_segmented skbs. Signed-off-by:
Jarek Poplawski <jarkao2@gmail.com> Signed-off-by:
-
Ilpo Järvinen authored
While looking for some common code I came across difference in checksum calculation between tcp_v6_send_(reset|ack) I couldn't explain. I checked both v4 and v6 and found out that both seem to have the same "feature". I couldn't find anything in rfc nor anywhere else which would state that md5 option should be ignored like it was in case of reset so I came to a conclusion that this is probably a genuine bug. I suspect that addition of md5 just was fooled by the excessive copy-paste code in those functions and the reset part was never tested well enough to find out the problem. Signed-off-by:
Ilpo Järvinen <ilpo.jarvinen@helsinki.fi> Signed-off-by:
-
Denis V. Lunev authored
Signed-off-by:
Denis V. Lunev <den@openvz.org> Signed-off-by:
-
Denis V. Lunev authored
Signed-off-by:
-
Denis V. Lunev authored
Signed-off-by:
-
Denis V. Lunev authored
Signed-off-by:
-
Denis V. Lunev authored
Removed. Signed-off-by:
-
Denis V. Lunev authored
Signed-off-by:
-
Denis V. Lunev authored
Signed-off-by:
-
Denis V. Lunev authored
Signed-off-by:
-
Denis V. Lunev authored
Signed-off-by:
-
Denis V. Lunev authored
Signed-off-by:
-
Denis V. Lunev authored
Signed-off-by:
-
Denis V. Lunev authored
Signed-off-by:
-
Denis V. Lunev authored
Signed-off-by:
-
Denis V. Lunev authored
Signed-off-by:
-
-
Jan Engelhardt authored
Signed-off-by:
Jan Engelhardt <jengelh@medozas.de> Signed-off-by:
Patrick McHardy <kaber@trash.net>
-
Jan Engelhardt authored
Lots of extensions are completely family-independent, so squash some code. Signed-off-by:
-
Jan Engelhardt authored
Using ->family in struct xt_*_param, multiple struct xt_{match,target} can be squashed together. Signed-off-by: -
Jan Engelhardt authored
By passing in the family through which extensions were invoked, a bit of data space can be reclaimed. The "family" member will be added to the parameter structures and the check functions be adjusted. Signed-off-by:
-
Jan Engelhardt authored
This patch does this for target extensions' destroy functions. Signed-off-by:
-
Jan Engelhardt authored
This patch does this for target extensions' checkentry functions. Signed-off-by:
-
Jan Engelhardt authored
This patch does this for target extensions' target functions. Signed-off-by:
-
Jan Engelhardt authored
This patch does this for match extensions' destroy functions. Signed-off-by:
-
Jan Engelhardt authored
This patch does this for match extensions' checkentry functions. Signed-off-by:
-
Jan Engelhardt authored
The function signatures for Xtables extensions have grown over time. It involves a lot of typing/replication, and also a bit of stack space even if they are not used. Realize an NFWS2008 idea and pack them into structs. The skb remains outside of the struct so gcc can continue to apply its optimizations. This patch does this for match extensions' match functions. A few ambiguities have also been addressed. The "offset" parameter for example has been renamed to "fragoff" (there are so many different offsets already) and "protoff" to "thoff" (there is more than just one protocol here, so clarify). Signed-off-by:
-
Jan Engelhardt authored
Signed-off-by:
-
Jan Engelhardt authored
Signed-off-by:
-
Jan Engelhardt authored
Signed-off-by:
-
Jan Engelhardt authored
ip6t_LOG does certainly not depend on the filter table. (Also, move it so that menuconfig still displays it correctly.) Signed-off-by:
-
Jan Engelhardt authored
The module is called hbh, not hopbyhop. Signed-off-by:
-
Jan Engelhardt authored
It used to be that {ip,ip6,etc}_tables called extension->checkentry themselves, but this can be moved into the xtables core. Signed-off-by: -
Jan Engelhardt authored
Usually -EINVAL is used when checkentry fails (see *_tables). Signed-off-by:
-
Jan Engelhardt authored
Signed-off-by:
-
Jan Engelhardt authored
Signed-off-by:
-
