1. 25 Aug, 2009 1 commit
  2. 17 Aug, 2009 1 commit
    • Yinghai Lu's avatar
      x86, apic: Move dmar_table_init() out of enable_IR() · b7f42ab2
      Yinghai Lu authored
      On an x2apic system, we got:
      
      [    1.818072] ------------[ cut here ]------------
      [    1.820376] WARNING: at kernel/lockdep.c:2461 lockdep_trace_alloc+0xa5/0xe9()
      [    1.835282] Hardware name: ASSY,
      [    1.839006] Modules linked in:
      [    1.841253] Pid: 1, comm: swapper Not tainted 2.6.31-rc5-tip-03926-g39aaa80-dirty #510
      [    1.858056] Call Trace:
      [    1.859913]  [<ffffffff810d13aa>] ? lockdep_trace_alloc+0xa5/0xe9
      [    1.876270]  [<ffffffff81093f37>] warn_slowpath_common+0x8d/0xd0
      [    1.879132]  [<ffffffff81093fa1>] warn_slowpath_null+0x27/0x3d
      [    1.896823]  [<ffffffff810d13aa>] lockdep_trace_alloc+0xa5/0xe9
      [    1.900659]  [<ffffffff810cf5a0>] ? lock_release_holdtime+0x2f/0x199
      [    1.917188]  [<ffffffff81167a3c>] kmem_cache_alloc_notrace+0x42/0x111
      [    1.922320]  [<ffffffff8106fe8c>] ? reserve_memtype+0x152/0x518
      [    1.938137]  [<ffffffff8106f8b1>] ? pat_pagerange_is_ram+0x4a/0x91
      [    1.941730]  [<ffffffff8106fe8c>] reserve_memtype+0x152/0x518
      [    1.958115]  [<ffffffff8106ce62>] __ioremap_caller+0x1dd/0x30f
      [    1.975507]  [<ffffffff81ce2c5c>] ? acpi_os_map_memory+0x2a/0x47
      [    1.978987]  [<ffffffff8106d0fd>] ioremap_nocache+0x2a/0x40
      [    2.031400]  [<ffffffff810d0364>] ? trace_hardirqs_off+0x20/0x36
      [    2.036096]  [<ffffffff81ce2c5c>] acpi_os_map_memory+0x2a/0x47
      [    2.046263]  [<ffffffff815cd642>] acpi_tb_verify_table+0x3d/0x85
      [    2.050349]  [<ffffffff81d34af7>] ? _spin_unlock_irqrestore+0x50/0x76
      [    2.067327]  [<ffffffff815ccad6>] acpi_get_table_with_size+0x64/0xd9
      [    2.070860]  [<ffffffff81d34af7>] ? _spin_unlock_irqrestore+0x50/0x76
      [    2.088000]  [<ffffffff825c88d5>] dmar_table_detect+0x33/0x70
      [    2.092047]  [<ffffffff825c8a01>] dmar_table_init+0x43/0x428
      [    2.106854]  [<ffffffff825a7537>] enable_IR+0x1c/0x8d
      [    2.110256]  [<ffffffff825a7624>] enable_IR_x2apic+0x7c/0x19e
      [    2.127139]  [<ffffffff825a4876>] native_smp_prepare_cpus+0x139/0x3b8
      [    2.145175]  [<ffffffff8259678d>] kernel_init+0x71/0x1da
      [    2.148913]  [<ffffffff8104305a>] child_rip+0xa/0x20
      [    2.152349]  [<ffffffff810429fc>] ? restore_args+0x0/0x30
      [    2.167931]  [<ffffffff8259671c>] ? kernel_init+0x0/0x1da
      [    2.171671]  [<ffffffff81043050>] ? child_rip+0x0/0x20
      [    2.187607] ---[ end trace a7919e7f17c0a725 ]---
      
      Venkatesh Pallipadi said:
      
      | Looks like the problem started with this commit
      |
      | commit ce69a784
      | Author: Gleb Natapov <gleb@redhat.com>
      | Date:   Mon Jul 20 15:24:17 2009 +0300
      |
      | x86/apic: Enable x2APIC without interrupt remapping under KVM
      |
      | Before this commit, dmar_table_init() was getting called
      | with interrupts enabled and after this commit, it is getting
      | called with interrupts disabled.
      
      so try to move out dmar_table_init out of that function.
      Analyzed-by: default avatarVenkatesh Pallipadi <venkatesh.pallipadi@intel.com>
      Signed-off-by: default avatarYinghai Lu <yinghai@kernel.org>
      Cc: Peter Zijlstra <peterz@infradead.org>
      Cc: Gleb Natapov <gleb@redhat.com>
      Cc: Suresh Siddha <suresh.b.siddha@intel.com>
      Cc: "Pallipadi, Venkatesh" <venkatesh.pallipadi@intel.com>
      LKML-Reference: <4A899F3C.2050104@kernel.org>
      Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
      b7f42ab2
  3. 08 Aug, 2009 1 commit
  4. 05 Aug, 2009 4 commits
  5. 02 Aug, 2009 1 commit
  6. 14 Jul, 2009 13 commits
  7. 13 Jul, 2009 11 commits
    • Linus Torvalds's avatar
      Merge branch 'for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4 · 1cf29683
      Linus Torvalds authored
      * 'for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4:
        jbd2: fix race between write_metadata_buffer and get_write_access
        ext4: Fix ext4_mb_initialize_context() to initialize all fields
        ext4: fix null handler of ioctls in no journal mode
        ext4: Fix buffer head reference leak in no-journal mode
        ext4: Move __ext4_journalled_writepage() to avoid forward declaration
        ext4: Fix mmap/truncate race when blocksize < pagesize && !nodellaoc
        ext4: Fix mmap/truncate race when blocksize < pagesize && delayed allocation
        ext4: Don't look at buffer_heads outside i_size.
        ext4: Fix goal inum check in the inode allocator
        ext4: fix no journal corruption with locale-gen
        ext4: Calculate required journal credits for inserting an extent properly
        ext4: Fix truncation of symlinks after failed write
        jbd2: Fix a race between checkpointing code and journal_get_write_access()
        ext4: Use rcu_barrier() on module unload.
        ext4: naturally align struct ext4_allocation_request
        ext4: mark several more functions in mballoc.c as noinline
        ext4: Fix potential reclaim deadlock when truncating partial block
        jbd2: Remove GFP_ATOMIC kmalloc from inside spinlock critical region
        ext4: Fix type warning on 64-bit platforms in tracing events header
      1cf29683
    • dingdinghua's avatar
      jbd2: fix race between write_metadata_buffer and get_write_access · 96577c43
      dingdinghua authored
      The function jbd2_journal_write_metadata_buffer() calls
      jbd_unlock_bh_state(bh_in) too early; this could potentially allow
      another thread to call get_write_access on the buffer head, modify the
      data, and dirty it, and allowing the wrong data to be written into the
      journal.  Fortunately, if we lose this race, the only time this will
      actually cause filesystem corruption is if there is a system crash or
      other unclean shutdown of the system before the next commit can take
      place.
      Signed-off-by: default avatardingdinghua <dingdinghua85@gmail.com>
      Signed-off-by: default avatar"Theodore Ts'o" <tytso@mit.edu>
      96577c43
    • Linus Torvalds's avatar
      Merge git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging-2.6 · 4a390e07
      Linus Torvalds authored
      * git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging-2.6:
        Staging: stlc45xx: convert config_interface to bss_info_changed, fixing a build error
        Staging: comedi: s626: use subvendor:subdevice ids for SAA7146 board
        Staging: prevent rtl8192su from crashing dev_ioctl in SIOCGIWNAME
        Staging: prevent rtl8187se from crashing dev_ioctl() in SIOCGIWNAME
        Staging: rtl8192su: convert to net_device_ops
        Staging: serqt_usb2: declare qt_open static in serqt_usb2
        Staging: serqt_usb2: fix qt_close parameters in serqt_usb2
        Staging: comedi: jr3_pci.c: add required includes
        Staging: meilhaus: add email address to TODO
        Staging: rspiusb: use NULL virtual address instead of a bogus one
        Staging: vt6655: compile fix
        Staging: rt2870: Add USB ID for Sitecom WL-608
      4a390e07
    • Linus Torvalds's avatar
      Merge git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core-2.6 · a4dc3237
      Linus Torvalds authored
      * git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core-2.6:
        wm97xx_batery: replace driver_data with dev_get_drvdata()
        omap: video: remove direct access of driver_data
        Sound: remove direct access of driver_data
        driver model: fix show/store prototypes in doc.
        Firmware: firmware_class, fix lock imbalance
        Driver Core: remove BUS_ID_SIZE
        sparc: remove driver-core BUS_ID_SIZE
        partitions: fix broken uevent_suppress conversion
        devres: WARN() and return, don't crash on device_del() of uninitialized device
      a4dc3237
    • Linus Torvalds's avatar
      Merge git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb-2.6 · 51feb98d
      Linus Torvalds authored
      * git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb-2.6: (48 commits)
        USB: otg: fix module reinsert issue
        USB: handle zero-length usbfs submissions correctly
        USB: EHCI: report actual_length for iso transfers
        USB: option: remove unnecessary and erroneous code
        USB: cypress_m8: remove invalid Clear-Halt
        USB: musb_host: undo incorrect change in musb_advance_schedule()
        USB: fix LANGID=0 regression
        USB: serial: sierra driver id_table additions
        USB serial: Add ID for Turtelizer, an FT2232L-based JTAG/RS-232 adapter.
        USB: fix race leading to a write after kfree in usbfs
        USB: Sierra: fix oops upon device close
        USB: option.c: add A-Link 3GU device id
        USB: Serial: Add support for Arkham Technology adapters
        USB: Fix option_ms regression in 2.6.31-rc2
        USB: gadget audio: select SND_PCM
        USB: ftdi: support NDI devices
        Revert USB: usbfs: deprecate and hide option for !embedded
        USB: usb.h: fix kernel-doc notation
        USB: RNDIS gadget, fix issues talking from PXA
        USB: serial: FTDI with product code FB80 and vendor id 0403
        ...
      51feb98d
    • Dave Kleikamp's avatar
      update JFS entry in MAINTAINERS · 8f8f0134
      Dave Kleikamp authored
      JFS hasn't really been supported for a while.  It's still maintained,
      but saying it's supported is a stretch.  Updating my preferred email
      address as well.
      Signed-off-by: default avatarDave Kleikamp <shaggy@linux.vnet.ibm.com>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      8f8f0134
    • Huang Weiyi's avatar
      mn10300: remove duplicated #include · 5fddcdb7
      Huang Weiyi authored
      Remove duplicated #include('s) in
        arch/mn10300/kernel/sys_mn10300.c
      Signed-off-by: default avatarHuang Weiyi <weiyi.huang@gmail.com>
      Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      5fddcdb7
    • Jean Delvare's avatar
      Fix staging drivers after smp_lock.h redux · 1d03d2bd
      Jean Delvare authored
      Commit 405f5571 ("headers: smp_lock.h
      redux") broke the build of two staging drivers. Fix them.
      Signed-off-by: default avatarJean Delvare <khali@linux-fr.org>
      Cc: Alexey Dobriyan <adobriyan@gmail.com>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      1d03d2bd
    • Theodore Ts'o's avatar
      ext4: Fix ext4_mb_initialize_context() to initialize all fields · 833576b3
      Theodore Ts'o authored
      Pavel Roskin pointed out that kmemcheck indicated that
      ext4_mb_store_history() was accessing uninitialized values of
      ac->ac_tail and ac->ac_buddy leading to garbage in the mballoc
      history.  Fix this by initializing the entire structure to all zeros
      first.
      
      Also, two fields were getting doubly initialized by the caller of
      ext4_mb_initialize_context, so remove them for efficiency's sake.
      Signed-off-by: default avatar"Theodore Ts'o" <tytso@mit.edu>
      833576b3
    • Peng Tao's avatar
      ext4: fix null handler of ioctls in no journal mode · ac046f1d
      Peng Tao authored
      The EXT4_IOC_GROUP_ADD and EXT4_IOC_GROUP_EXTEND ioctls should not
      flush the journal in no_journal mode.  Otherwise, running resize2fs on
      a mounted no_journal partition triggers the following error messages:
      
      BUG: unable to handle kernel NULL pointer dereference at 00000014
      IP: [<c039d282>] _spin_lock+0x8/0x19
      *pde = 00000000 
      Oops: 0002 [#1] SMP
      Signed-off-by: default avatarPeng Tao <bergwolf@gmail.com>
      Signed-off-by: default avatar"Theodore Ts'o" <tytso@mit.edu>
      ac046f1d
    • Curt Wohlgemuth's avatar
      ext4: Fix buffer head reference leak in no-journal mode · e6b5d301
      Curt Wohlgemuth authored
      We found a problem with buffer head reference leaks when using an ext4
      partition without a journal.  In particular, calls to ext4_forget() would
      not to a brelse() on the input buffer head, which will cause pages they
      belong to to not be reclaimable.
      
      Further investigation showed that all places where ext4_journal_forget() and
      ext4_journal_revoke() are called are subject to the same problem.  The patch
      below changes __ext4_journal_forget/__ext4_journal_revoke to do an explicit
      release of the buffer head when the journal handle isn't valid.
      Signed-off-by: default avatarCurt Wohlgemuth <curtw@google.com>
      Signed-off-by: default avatar"Theodore Ts'o" <tytso@mit.edu>
      e6b5d301
  8. 12 Jul, 2009 8 commits