Commit fe9bab2d authored by Eugene Teo's avatar Eugene Teo Committed by Linus Torvalds

[PATCH] Fix sb_mixer use before validation

dev should be validated before it is being used as index to array.

Coverity bug #871
Signed-off-by: default avatarEugene Teo <eugene.teo@eugeneteo.net>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent 1f4d4a80
...@@ -273,14 +273,14 @@ int sb_common_mixer_set(sb_devc * devc, int dev, int left, int right) ...@@ -273,14 +273,14 @@ int sb_common_mixer_set(sb_devc * devc, int dev, int left, int right)
int regoffs; int regoffs;
unsigned char val; unsigned char val;
if ((dev < 0) || (dev >= devc->iomap_sz))
return -EINVAL;
regoffs = (*devc->iomap)[dev][LEFT_CHN].regno; regoffs = (*devc->iomap)[dev][LEFT_CHN].regno;
if (regoffs == 0) if (regoffs == 0)
return -EINVAL; return -EINVAL;
if ((dev < 0) || (dev >= devc->iomap_sz))
return -EINVAL;
val = sb_getmixer(devc, regoffs); val = sb_getmixer(devc, regoffs);
change_bits(devc, &val, dev, LEFT_CHN, left); change_bits(devc, &val, dev, LEFT_CHN, left);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment