Commit fe643414 authored by Jiri Slaby's avatar Jiri Slaby Committed by John W. Linville

wireless: wl12xx, fix lock imbalance

Add omitted mutex_unlock to one of wl12xx_op_start fail paths (when
wl12xx_chip_wakeup fails).

[v2]
Power off the device, because:
\= cite from http://marc.info/?l=linux-kernel&m=124755028209880&w=2
If the chip cannot be booted, why should it remain powered on?
In some rare cases, the chip might fail to initialize, but can
recover if powered off and on again, so turning it off at this
point is the right thing to do. =/
Signed-off-by: default avatarJiri Slaby <jirislaby@gmail.com>
Reviewed-by: default avatarLuciano Coelho <luciano.coelho@nokia.com>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent a94ca4e7
...@@ -349,7 +349,7 @@ static int wl1251_op_start(struct ieee80211_hw *hw) ...@@ -349,7 +349,7 @@ static int wl1251_op_start(struct ieee80211_hw *hw)
ret = wl1251_chip_wakeup(wl); ret = wl1251_chip_wakeup(wl);
if (ret < 0) if (ret < 0)
return ret; goto out;
ret = wl->chip.op_boot(wl); ret = wl->chip.op_boot(wl);
if (ret < 0) if (ret < 0)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment