Commit fcd6dbac authored by Avi Kivity's avatar Avi Kivity

KVM: MMU: Only mark_page_accessed() if the page was accessed by the guest

If the accessed bit is not set, the guest has never accessed this page
(at least through this spte), so there's no need to mark the page
accessed.  This provides more accurate data for the eviction algortithm.

Noted by Andrea Arcangeli.
Signed-off-by: default avatarAvi Kivity <avi@qumranet.com>
parent d39f13b0
...@@ -549,7 +549,8 @@ static void rmap_remove(struct kvm *kvm, u64 *spte) ...@@ -549,7 +549,8 @@ static void rmap_remove(struct kvm *kvm, u64 *spte)
return; return;
sp = page_header(__pa(spte)); sp = page_header(__pa(spte));
page = spte_to_page(*spte); page = spte_to_page(*spte);
mark_page_accessed(page); if (*spte & PT_ACCESSED_MASK)
mark_page_accessed(page);
if (is_writeble_pte(*spte)) if (is_writeble_pte(*spte))
kvm_release_page_dirty(page); kvm_release_page_dirty(page);
else else
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment