Commit f6620cab authored by Stephen Hemminger's avatar Stephen Hemminger Committed by Jeff Garzik

[PATCH] skge: silence mac data parity messages

Using Genesis board, I get harmless error reports. Rather than console
error, turn it into a error counter.
Signed-off-by: default avatarStephen Hemminger <shemminger@osdl.org>
Signed-off-by: default avatarJeff Garzik <jgarzik@pobox.com>
parent b0825488
...@@ -2633,11 +2633,17 @@ static inline void skge_tx_intr(struct net_device *dev) ...@@ -2633,11 +2633,17 @@ static inline void skge_tx_intr(struct net_device *dev)
spin_unlock(&skge->tx_lock); spin_unlock(&skge->tx_lock);
} }
/* Parity errors seem to happen when Genesis is connected to a switch
* with no other ports present. Heartbeat error??
*/
static void skge_mac_parity(struct skge_hw *hw, int port) static void skge_mac_parity(struct skge_hw *hw, int port)
{ {
printk(KERN_ERR PFX "%s: mac data parity error\n", struct net_device *dev = hw->dev[port];
hw->dev[port] ? hw->dev[port]->name
: (port == 0 ? "(port A)": "(port B")); if (dev) {
struct skge_port *skge = netdev_priv(dev);
++skge->net_stats.tx_heartbeat_errors;
}
if (hw->chip_id == CHIP_ID_GENESIS) if (hw->chip_id == CHIP_ID_GENESIS)
skge_write16(hw, SK_REG(port, TX_MFF_CTRL1), skge_write16(hw, SK_REG(port, TX_MFF_CTRL1),
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment