Commit f3abc9b9 authored by Eric Dumazet's avatar Eric Dumazet Committed by Patrick McHardy

netfilter: bridge: refcount fix

commit f216f082
([NETFILTER]: bridge netfilter: deal with martians correctly)
added a refcount leak on in_dev.

Instead of using in_dev_get(), we can use __in_dev_get_rcu(),
as netfilter hooks are running under rcu_read_lock(), as pointed
by Patrick.
Signed-off-by: default avatarEric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: default avatarPatrick McHardy <kaber@trash.net>
parent cce5a5c3
...@@ -359,7 +359,7 @@ static int br_nf_pre_routing_finish(struct sk_buff *skb) ...@@ -359,7 +359,7 @@ static int br_nf_pre_routing_finish(struct sk_buff *skb)
}, },
.proto = 0, .proto = 0,
}; };
struct in_device *in_dev = in_dev_get(dev); struct in_device *in_dev = __in_dev_get_rcu(dev);
/* If err equals -EHOSTUNREACH the error is due to a /* If err equals -EHOSTUNREACH the error is due to a
* martian destination or due to the fact that * martian destination or due to the fact that
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment