Commit f0fda801 authored by bjorn.helgaas@hp.com's avatar bjorn.helgaas@hp.com Committed by Greg Kroah-Hartman

PCI: use dev_printk in quirk messages

Convert quirk printks to dev_printk().

I made the MSI disable messages a little more consistent:

    - always use "disabled", not "deactivated"
    - specify "device MSI disabled" or "subordinate MSI disabled" when
      disabling MSI for only a specific device or subordinate bus
Signed-off-by: default avatarBjorn Helgaas <bjorn.helgaas@hp.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 9f23ed3b
This diff is collapsed.
...@@ -190,9 +190,8 @@ static void __devinit quirk_usb_handoff_ohci(struct pci_dev *pdev) ...@@ -190,9 +190,8 @@ static void __devinit quirk_usb_handoff_ohci(struct pci_dev *pdev)
msleep(10); msleep(10);
} }
if (wait_time <= 0) if (wait_time <= 0)
printk(KERN_WARNING "%s %s: BIOS handoff " dev_warn(&pdev->dev, "OHCI: BIOS handoff failed"
"failed (BIOS bug ?) %08x\n", " (BIOS bug?) %08x\n",
pdev->dev.bus_id, "OHCI",
readl(base + OHCI_CONTROL)); readl(base + OHCI_CONTROL));
/* reset controller, preserving RWC */ /* reset controller, preserving RWC */
...@@ -243,8 +242,7 @@ static void __devinit quirk_usb_disable_ehci(struct pci_dev *pdev) ...@@ -243,8 +242,7 @@ static void __devinit quirk_usb_disable_ehci(struct pci_dev *pdev)
switch (cap & 0xff) { switch (cap & 0xff) {
case 1: /* BIOS/SMM/... handoff support */ case 1: /* BIOS/SMM/... handoff support */
if ((cap & EHCI_USBLEGSUP_BIOS)) { if ((cap & EHCI_USBLEGSUP_BIOS)) {
pr_debug("%s %s: BIOS handoff\n", dev_dbg(&pdev->dev, "EHCI: BIOS handoff\n");
pdev->dev.bus_id, "EHCI");
#if 0 #if 0
/* aleksey_gorelov@phoenix.com reports that some systems need SMI forced on, /* aleksey_gorelov@phoenix.com reports that some systems need SMI forced on,
...@@ -285,9 +283,8 @@ static void __devinit quirk_usb_disable_ehci(struct pci_dev *pdev) ...@@ -285,9 +283,8 @@ static void __devinit quirk_usb_disable_ehci(struct pci_dev *pdev)
/* well, possibly buggy BIOS... try to shut /* well, possibly buggy BIOS... try to shut
* it down, and hope nothing goes too wrong * it down, and hope nothing goes too wrong
*/ */
printk(KERN_WARNING "%s %s: BIOS handoff " dev_warn(&pdev->dev, "EHCI: BIOS handoff failed"
"failed (BIOS bug ?) %08x\n", " (BIOS bug?) %08x\n", cap);
pdev->dev.bus_id, "EHCI", cap);
pci_write_config_byte(pdev, offset + 2, 0); pci_write_config_byte(pdev, offset + 2, 0);
} }
...@@ -306,17 +303,14 @@ static void __devinit quirk_usb_disable_ehci(struct pci_dev *pdev) ...@@ -306,17 +303,14 @@ static void __devinit quirk_usb_disable_ehci(struct pci_dev *pdev)
cap = 0; cap = 0;
/* FALLTHROUGH */ /* FALLTHROUGH */
default: default:
printk(KERN_WARNING "%s %s: unrecognized " dev_warn(&pdev->dev, "EHCI: unrecognized capability "
"capability %02x\n", "%02x\n", cap & 0xff);
pdev->dev.bus_id, "EHCI",
cap & 0xff);
break; break;
} }
offset = (cap >> 8) & 0xff; offset = (cap >> 8) & 0xff;
} }
if (!count) if (!count)
printk(KERN_DEBUG "%s %s: capability loop?\n", dev_printk(KERN_DEBUG, &pdev->dev, "EHCI: capability loop?\n");
pdev->dev.bus_id, "EHCI");
/* /*
* halt EHCI & disable its interrupts in any case * halt EHCI & disable its interrupts in any case
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment