Commit e6bf95ff authored by Breno Leitao's avatar Breno Leitao Committed by David S. Miller

bnx2: fixing a timout error due not refreshing TX timers correctly

When running the following script on an active bnx2 interface:

while(true); do ifconfig ethX mtu 9000; ifconfig ethX mtu 1500; done

A timeout error appears and dumps the following stack:

NETDEV WATCHDOG: eth4 (bnx2): transmit queue 0 timed out
------------[ cut here ]------------
Badness at net/sched/sch_generic.c:261
<snip>

This patch just fixes the way that ->trans_start is refreshed.
Signed-off-by: default avatarBreno Leitao <leitao@linux.vnet.ibm.com>
Acked-by: default avatarMichael Chan <mchan@broadcom.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 4773a47d
...@@ -654,9 +654,17 @@ bnx2_netif_stop(struct bnx2 *bp) ...@@ -654,9 +654,17 @@ bnx2_netif_stop(struct bnx2 *bp)
{ {
bnx2_cnic_stop(bp); bnx2_cnic_stop(bp);
if (netif_running(bp->dev)) { if (netif_running(bp->dev)) {
int i;
bnx2_napi_disable(bp); bnx2_napi_disable(bp);
netif_tx_disable(bp->dev); netif_tx_disable(bp->dev);
bp->dev->trans_start = jiffies; /* prevent tx timeout */ /* prevent tx timeout */
for (i = 0; i < bp->dev->num_tx_queues; i++) {
struct netdev_queue *txq;
txq = netdev_get_tx_queue(bp->dev, i);
txq->trans_start = jiffies;
}
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment