Commit e5b89542 authored by Christian Borntraeger's avatar Christian Borntraeger Committed by Linus Torvalds

virtio-rng: Remove false BUG for spurious callbacks

The virtio-rng drivers checks for spurious callbacks. Since
callbacks can be implemented via shared interrupts (e.g. PCI) this
could lead to guest kernel oopses with lots of virtio devices.
Signed-off-by: default avatarChristian Borntraeger <borntraeger@de.ibm.com>
Cc: Rusty Russell <rusty@rustcorp.com.au>
Cc: stable@kernel.org
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 9f5a6912
...@@ -37,9 +37,9 @@ static void random_recv_done(struct virtqueue *vq) ...@@ -37,9 +37,9 @@ static void random_recv_done(struct virtqueue *vq)
{ {
int len; int len;
/* We never get spurious callbacks. */ /* We can get spurious callbacks, e.g. shared IRQs + virtio_pci. */
if (!vq->vq_ops->get_buf(vq, &len)) if (!vq->vq_ops->get_buf(vq, &len))
BUG(); return;
data_left = len / sizeof(random_data[0]); data_left = len / sizeof(random_data[0]);
complete(&have_data); complete(&have_data);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment