Commit df33c77e authored by Kristen Accardi's avatar Kristen Accardi Committed by Len Brown

libata-acpi: allow _GTF on SATA, but disable on PATA for now

The ACPI specification states, and BIOS implementations depend on,
_STM being called before _GTF.

SATA does this, but PATA does not.  So for now, simply
prevent execution of _GTF on PATA devices.  Longer term we
should implement ACPI support for PATA devices in libata.
Signed-off-by: default avatarKristen Accardi <kristen.c.accardi@intel.com>
Signed-off-by: default avatarLen Brown <len.brown@intel.com>
parent 908e0a8a
...@@ -561,6 +561,13 @@ int ata_acpi_exec_tfs(struct ata_port *ap) ...@@ -561,6 +561,13 @@ int ata_acpi_exec_tfs(struct ata_port *ap)
if (noacpi) if (noacpi)
return 0; return 0;
/*
* TBD - implement PATA support. For now,
* we should not run GTF on PATA devices since some
* PATA require execution of GTM/STM before GTF.
*/
if (!(ap->cbl == ATA_CBL_SATA))
return 0;
for (ix = 0; ix < ATA_MAX_DEVICES; ix++) { for (ix = 0; ix < ATA_MAX_DEVICES; ix++) {
if (!ata_dev_enabled(&ap->device[ix])) if (!ata_dev_enabled(&ap->device[ix]))
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment